[Bug 17563] New: Crash when using TTM_GETTEXT + LPSTR_CALLBACK

http://bugs.winehq.org/show_bug.cgi?id=17563

Summary: Crash when using TTM_GETTEXT + LPSTR_CALLBACK
           Product: Wine
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comdlg32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=19718)
 --> (http://bugs.winehq.org/attachment.cgi?id=19718)
Test application: Pressing the button crashes the program under Wine (the text
shows correctly if you go over the button). Source included.

Any program crashes when the message TTM_GETTEXT is sent to a ToolTip that has
lpszText set to LPSTR_CALLBACK.

The problem seems to be in dlls/comctl32/tooltips.c, in the functions
TOOLTIPS_GetTextA and TOOLTIPS_GetTextW.

The crash happens when Wine tries to copy lpszText, which is 0xFFFFFFFF.

Test application included.

[Bug 17563] Crash when using TTM_GETTEXT + LPSTR_CALLBACK

http://bugs.winehq.org/show_bug.cgi?id=17563

--- Comment #1 from GameZelda   2009-02-28 16:21:33 ---
It seems to work replacing the very last part of TOOLTIPS_GetTextA and
TOOLTIPS_GetTextW with:

---

TOOLTIPS_GetTipText(hwnd, infoPtr, nTool);    
    WideCharToMultiByte(CP_ACP, 0, infoPtr->szTipText, -1,
                        lpToolInfo->lpszText, INFOTIPSIZE, NULL, NULL);

return 0;
}

---

and

---

TOOLTIPS_GetTipText(hwnd, infoPtr, nTool);
    strcpyW (lpToolInfo->lpszText, infoPtr->szTipText);

return 0;
}

[Bug 17563] Crash when using TTM_GETTEXT + LPSTR_CALLBACK

http://bugs.winehq.org/show_bug.cgi?id=17563

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|comdlg32                    |comctl32
           Keywords|                            |source
         OS/Version|All                         |other
           Platform|All                         |Other

--- Comment #2 from Vitaliy Margolen   2009-02-28 21:59:16 ---
Wine version? OS?

[Bug 17563] Crash when using TTM_GETTEXT + LPSTR_CALLBACK

http://bugs.winehq.org/show_bug.cgi?id=17563

--- Comment #3 from GameZelda   2009-03-01 01:20:16 ---
Version: Wine 1.1.16
OS: Linux, but from what I've seen in the code, it will crash on any OS.

[Bug 17563] Crash when using TTM_GETTEXT + LPSTR_CALLBACK

http://bugs.winehq.org/show_bug.cgi?id=17563

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch, testcase

--- Comment #4 from Austin English   2009-03-01 01:24:47 ---
You should convert that testcase to a conformance test and submit it to
[e-mail].

[Bug 17563] Crash when using TTM_GETTEXT + LPSTR_CALLBACK

http://bugs.winehq.org/show_bug.cgi?id=17563

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|other                       |Linux
            Version|unspecified                 |1.1.16

[Bug 17563] Crash when using TTM_GETTEXT + LPSTR_CALLBACK

http://bugs.winehq.org/show_bug.cgi?id=17563

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #5 from Nikolay Sivov   2009-05-24 05:02:49 ---
Confirming. I'll try to look at it.

[Bug 17563] Crash when using TTM_GETTEXT + LPSTR_CALLBACK

http://bugs.winehq.org/show_bug.cgi?id=17563

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

[Bug 17563] Crash when using TTM_GETTEXT + LPSTR_CALLBACK

http://bugs.winehq.org/show_bug.cgi?id=17563

--- Comment #6 from Nikolay Sivov   2009-05-27 14:45:14 ---
Fix sent for that bug. You need both patches to test:

http://www.winehq.org/pipermail/wine-patches/2009-May/073469.html
http://www.winehq.org/pipermail/wine-patches/2009-May/073470.html

[Bug 17563] Crash when using TTM_GETTEXT + LPSTR_CALLBACK

http://bugs.winehq.org/show_bug.cgi?id=17563

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Nikolay Sivov   2009-05-28 09:53:31 ---
Fixed by commit:

http://source.winehq.org/git/wine.git/?a=commit;h=7d32cfef27bdb9d661cfbdc657...

Reopen it if you still have a problem with callback entries.

[Bug 17563] Crash when using TTM_GETTEXT + LPSTR_CALLBACK

http://bugs.winehq.org/show_bug.cgi?id=17563

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard   2009-06-05 12:45:06 ---
Closing bugs fixed in 1.1.23.

[Bug 17563] Crash when using TTM_GETTEXT + LPSTR_CALLBACK

https://bugs.winehq.org/show_bug.cgi?id=17563

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]