[Bug 15494] New: ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

Summary: ddraw_test throws an exception when run
           Product: Wine
           Version: 1.1.5
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Running ddraw_test on wine with make test from the directory dlls/ddraw/tests/
throws the attached exception.

ATI FireGL V5200
3 Gigs of memory
RHEL 5.2

[Bug 15494] ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

--- Comment #1 from chris ahrendt   2008-10-01 20:31:07 ---
Created an attachment (id=16409)
 --> (http://bugs.winehq.org/attachment.cgi?id=16409)
Exception from running d3d test

[Bug 15494] ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

--- Comment #2 from Lei Zhang   2008-10-03 13:34:13 ---
Created an attachment (id=16449)
 --> (http://bugs.winehq.org/attachment.cgi?id=16449)
test patch

Does this patch help?

[Bug 15494] ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

--- Comment #3 from chris ahrendt   2008-10-05 20:00:20 ---
Yes the exception no longer occurs with the patch... 
however it does not explain how the variables are not set.
Also there are alot more Release calls which are not checked.

So not sure that this really fixes the bug or not as it doesn't
determine why the variable is null in the first place.

Chris

[Bug 15494] ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

--- Comment #4 from chris ahrendt   2008-10-07 20:09:29 ---
Created an attachment (id=16529)
 --> (http://bugs.winehq.org/attachment.cgi?id=16529)
addition to the first test patch

I took your patch and expanded on it.. checked the variables before every free
where its not currently checked.. this allows the test to run.. but it still 
makes me wonder why they were not initialized in the first place.
But I guess we can close the bug and submit the patch to the git tree..

chris

[Bug 15494] ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 15494] ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

chris ahrendt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Difficulty|---                         |Minutes
          Component|-unknown                    |testcases
         Resolution|                            |FIXED

--- Comment #5 from chris ahrendt   2008-10-08 07:00:41 ---
additional patch ontop of lei's patch fixes issues...
lei's patch fixes the exception my patch extends the checking  to whole
program.

[Bug 15494] ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

--- Comment #6 from Roderick Colenbrander   2008-10-08 07:06:00 ---
The patches aren't bad but I think they are unneeded as clearly the
CreateSurface call seems to fail and for that reason a test should abort and
not continue. That's I think the issue.

[Bug 15494] ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Difficulty|Minutes                     |---
         Resolution|FIXED                       |

--- Comment #7 from James Hawkins   2008-10-08 12:00:06 ---
A bug is not fixed until the patches are committed...

[Bug 15494] ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

--- Comment #8 from chris ahrendt   2008-10-08 12:02:58 ---
So should I open a bug with the CreateSurface call?

So I probably should put out an error message when I get a null value as well
as just checking for it?

Chris

[Bug 15494] ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

--- Comment #9 from chris ahrendt   2008-10-13 10:00:28 ---
The exception is actually caused by the code not checking the return for Create
Surface call... am working on fixing the patch to just have that...

chris

[Bug 15494] ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

--- Comment #10 from Austin English   2009-04-17 12:21:20 ---
Is this still an issue in current (1.1.19 or newer) wine?

[Bug 15494] ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

chris ahrendt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from chris ahrendt   2009-04-17 19:52:04 ---
Fixed with the latest GIT Tree no execptions.. however lots of ERR

[Bug 15494] ddraw_test throws an exception when run

http://bugs.winehq.org/show_bug.cgi?id=15494

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard   2009-04-24 12:17:13 ---
Closing bugs fixed in 1.1.20.