[Bug 55649] New: quartz:vmr9 - test_changed3ddevice() fails on the TestBot's w11pro64-amd & -nv VMs
https://bugs.winehq.org/show_bug.cgi?id=55649
Bug ID: 55649 Summary: quartz:vmr9 - test_changed3ddevice() fails on the TestBot's w11pro64-amd & -nv VMs Product: Wine Version: unspecified Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: quartz Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com
quartz:vmr9 - test_changed3ddevice() fails on the TestBot's w11pro64-amd & -nv VMs:
vmr9.c:4384: Test failed: got 0
See https://test.winehq.org/data/patterns.html#quartz:vmr9
w11pro64-amd is the TestBot's AMD RX6600 Windows 11 test configuration while w11pro64-nv is the NVidia RTX 3050 one.
This started on 2023-09-12 and corresponds to the commit that introduced the failing test:
commit 3855fc7a60e48632f77be57027d1dc1c51294470 Author: Alfred Agrell floating@muncher.se Date: Mon Sep 11 21:28:05 2023 +0200
quartz/tests: Add test for VMR9SurfaceAllocatorNotify_ChangeD3DDevice.
https://bugs.winehq.org/show_bug.cgi?id=55649
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |3855fc7a60e48632f77be57027d | |1dc1c51294470 Keywords| |regression, source, | |testcase
https://bugs.winehq.org/show_bug.cgi?id=55649
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |blubban@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=55649
--- Comment #1 from blubban@gmail.com --- Yep, that's my fault. I added that test in https://gitlab.winehq.org/wine/wine/-/merge_requests/3792 , forgot that those tests run on Windows too, and guessed wrong on how Windows works.
Unfortunately, I don't have any device able to run that test properly; I have a few VMs, but IVMRSurfaceAllocatorNotify9::SetD3DDevice just returns E_NOINTERFACE no matter what I do with it.
I'd be happy to fix it if I could, but if I can't run it, there's not much I can do. Best I can think of is mark that test as flaky, or delete it.
https://bugs.winehq.org/show_bug.cgi?id=55649
--- Comment #2 from François Gouget fgouget@codeweavers.com --- That's where the TestBot comes in: you can submit patches and tell the TestBot to run the tests on the w11pro64-amd and w11pro64-nv VMs:
https://testbot.winehq.org/Submit.pl
https://bugs.winehq.org/show_bug.cgi?id=55649
--- Comment #3 from blubban@gmail.com --- Ah, that's a neat service. Sure, I can do that.
...except those VMs don't run VMR9 properly either, I'm getting various absurd segfaults, deadlocks, and other problems.
Whatever, I can pick one of the error-returning variants, then check for that error and abandon ship. Not a good solution, but at least it's better than breaking the test suite.
https://gitlab.winehq.org/wine/wine/-/merge_requests/3970
https://bugs.winehq.org/show_bug.cgi?id=55649
--- Comment #4 from François Gouget fgouget@codeweavers.com ---
Whatever, I can pick one of the error-returning variants, then check for that error and abandon ship.
I don't know the quartz code so as long as it's reliable it's fine by me.
https://bugs.winehq.org/show_bug.cgi?id=55649
--- Comment #5 from François Gouget fgouget@codeweavers.com --- This failure sometimes also causes a pair refcount failures, that is I have never seen the latter without the former:
vmr9.c:4384: Test failed: got 0 vmr9.c:4392: Test failed: Got outstanding refcount 1. vmr9.c:4395: Test failed: Got outstanding refcount 1.
(Note that in the past we had similar refcount failures in test_windowless_size() but those were also preceded by other failures and now they don't seem to be happening anymore.)
https://bugs.winehq.org/show_bug.cgi?id=55649
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |z.figura12@gmail.com Fixed by SHA1| |31788cdc8c9cc9f6b0b4bdc2d1b | |96bcd48208fdf Resolution|--- |FIXED
--- Comment #6 from Zeb Figura z.figura12@gmail.com --- Fixed by https://source.winehq.org/git/wine.git/commitdiff/31788cdc8c9cc9f6b0b4bdc2d1b96bcd48208fdf.
https://bugs.winehq.org/show_bug.cgi?id=55649
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 9.0-rc2.
-
WineHQ Bugzilla