[Bug 10567] New: Return value mistake in msiexec.c

http://bugs.winehq.org/show_bug.cgi?id=10567

Summary: Return value mistake in msiexec.c
           Product: Wine
           Version: CVS/GIT
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: wine-programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=9334)
 --> (http://bugs.winehq.org/attachment.cgi?id=9334)
A patch that corrects the return value

I was just looking at the git source for msiexec.c, and noticed that in the
msi_atou() function, it calculates the DWORD, then returns 0 instead of the
calculated value. The file attached is a patch that simply returns the
calculated return value instead of 0.

Please be gentle, this is a lot of firsts for me. It's the first time I've ever
used git, generated a patch, used a bugzilla, or really submitted anything but
a human-language translation to an open-source project. If my patch is not of
the correct format, just let me know and I'll fix it. Also I wasn't sure if
this is the correct venue for submitting this patch.

[Bug 10567] Return value mistake in msiexec.c

http://bugs.winehq.org/show_bug.cgi?id=10567

Zac Brown  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Zac Brown   2007-11-25 01:23:21 ---
This should be submitted to the wine-patches list ([e-mail]).

- Zac

[Bug 10567] Return value mistake in msiexec.c

http://bugs.winehq.org/show_bug.cgi?id=10567

--- Comment #2 from Patrick   2007-11-25 01:30:02 ---
(In reply to comment #1)
> This should be submitted to the wine-patches list ([e-mail]).
> - Zac

Got it, thanks. How should I mark the resolution of this bug?

[Bug 10567] Return value mistake in msiexec.c

http://bugs.winehq.org/show_bug.cgi?id=10567

--- Comment #3 from Zac Brown   2007-11-25 08:44:10 ---
Probably the best way is to submit the patch and when its confirmed that it is
in the tree, then you can change the resolution to "RESOLVED". Until then I'd
leave it as an open bug as its technically not "fixed" till the patch is in the
tree.

Cheers,

Zac

[Bug 10567] Return value mistake in msiexec.c

http://bugs.winehq.org/show_bug.cgi?id=10567

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |patch

--- Comment #4 from Vitaliy Margolen   2007-11-25 11:24:36 ---
Confirming. You can resolve this bug after your change gets into Wine tree. And
close after the next release.

[Bug 10567] Return value mistake in msiexec.c

http://bugs.winehq.org/show_bug.cgi?id=10567

Vijay Kamuju  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Vijay Kamuju   2007-11-27 10:33:51 ---
patch commited

[Bug 10567] Return value mistake in msiexec.c

http://bugs.winehq.org/show_bug.cgi?id=10567

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Dan Kegel   2008-01-28 05:44:56 ---
Closing all RESOLVED FIXED bugs older than four weeks.

[Bug 10567] Return value mistake in msiexec.c

http://bugs.winehq.org/show_bug.cgi?id=10567

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

[Bug 10567] Return value mistake in msiexec.c

http://bugs.winehq.org/show_bug.cgi?id=10567

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other
         OS/Version|All                         |other

--- Comment #7 from Austin English  2012-02-23 15:11:53 CST ---
Removing deprecated 'All' Platform/OS.