[Bug 36713] New: Watch_Dogs does not start

http://bugs.winehq.org/show_bug.cgi?id=36713

Bug ID: 36713
           Summary: Watch_Dogs does not start
           Product: Wine
           Version: 1.7.19
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]

Trying to start watch_dogs.exe gives an error dialog from Disrupt_b64.dll: The
procedure entry point inet_pton could not be located in the dynamic link
library WS2_32.dll.

Console output after closing the dialog:

~/.wine/drive_c/Program Files (x86)/Ubisoft/Ubisoft Game
Launcher/games/Watch_Dogs/bin$ wine watch_dogs.exe 
fixme:heap:HeapSetInformation 0x3b0000 0 0x23fc90 4
fixme:heap:HeapSetInformation 0x4c0000 0 0x23fc90 4
fixme:heap:HeapSetInformation 0x5d0000 0 0x23fc90 4
fixme:heap:HeapSetInformation 0x920000 0 0x23fc90 4
err:module:attach_process_dlls "Disrupt_b64.dll" failed to initialize, aborting
err:module:LdrInitializeThunk Main exe initialization for L"C:\Program Files
(x86)\Ubisoft\Ubisoft Game Launcher\games\Watch_Dogs\bin\watch_dogs.exe"
failed, status c0000142

[Bug 36713] Watch_Dogs does not start

http://bugs.winehq.org/show_bug.cgi?id=36713

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |winsock
           Severity|blocker                     |normal

--- Comment #1 from Nikolay Sivov  ---
According to MSDN, inet_pton() is Vista+. Doesn't look too hard to implement.

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

http://bugs.winehq.org/show_bug.cgi?id=36713

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
            Summary|Watch_Dogs does not start   |Watch_Dogs requires
                   |                            |ws2_32.inet_pton
     Ever confirmed|0                           |1

--- Comment #2 from Bruno Jesus  ---
Confirming. I may have a look at it in the next weeks.

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

http://bugs.winehq.org/show_bug.cgi?id=36713

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Bruno Jesus  ---
Created attachment 48767
  --> http://bugs.winehq.org/attachment.cgi?id=48767
patch

Hopefully this helps, it stills needs some error handling and compilation check
but may do the trick for now.

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

http://bugs.winehq.org/show_bug.cgi?id=36713

Anthony Mattheakakis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

http://bugs.winehq.org/show_bug.cgi?id=36713

Seamus Caveney  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Seamus Caveney  ---
I can confirm this patch does allow Watch_Dogs to proceed past this error.

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

http://bugs.winehq.org/show_bug.cgi?id=36713

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #5 from Bruno Jesus  ---
(In reply to Seamus Caveney from comment #4)
> I can confirm this patch does allow Watch_Dogs to proceed past this error.

Thanks for testing. There are some pending patches related to ws2_32, when they
are commited I'll send this one.

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

http://bugs.winehq.org/show_bug.cgi?id=36713

di3gosand  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from di3gosand  ---
I try to apply patch but it return me an error:

patching file ws2_32.dll
patch: **** malformed patch at line 6: addr, PSTR buffer, SIZE_T len )

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

http://bugs.winehq.org/show_bug.cgi?id=36713

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Sebastian Lackner  ---
try this one:

https://github.com/compholio/wine-compholio/blob/master/patches/ws2_32-inet_...

This one also includes proper error handling.

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

http://bugs.winehq.org/show_bug.cgi?id=36713

Vitaliy Filippov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Vitaliy Filippov  ---
Created attachment 49222
  --> http://bugs.winehq.org/attachment.cgi?id=49222
my inet_pton.patch

Hm... What's wsaErrno() in your case?

Shouldn't it look like this one?

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

http://bugs.winehq.org/show_bug.cgi?id=36713

Erich Hoover  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Erich Hoover  ---
(In reply to Vitaliy Filippov from comment #8)
> Created attachment 49222 [details]
> my inet_pton.patch
>
> Hm... What's wsaErrno() in your case?
>
> Shouldn't it look like this one?

wsaErrno converts Unix "errno()" into a WSA error code (compatible with
SetLastError).  Did you run into a problem with the proposed patch?

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

http://bugs.winehq.org/show_bug.cgi?id=36713

--- Comment #10 from Vitaliy Filippov  ---
No, sorry :) I've ran into the same error yesterday and made my version of
patch... and found this bug only after it :)

Thanks for the explanation :)

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

http://bugs.winehq.org/show_bug.cgi?id=36713

--- Comment #11 from Bruno Jesus  ---
Vitaliy's approach is more like the opposite currently implemented in ws2_32
ntop:
http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ws2_32/socket.c#l6864

I'm not sure if that is required or not, tests may help.

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

http://bugs.winehq.org/show_bug.cgi?id=36713

--- Comment #12 from Erich Hoover  ---
(In reply to Bruno Jesus from comment #11)
> Vitaliy's approach is more like the opposite currently implemented in ws2_32
> ntop:
> http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ws2_32/socket.c#l6864
>
> I'm not sure if that is required or not, tests may help.

I think it would be better to convert the address family (IIRC we already have
a routine to do that).  The #ifdef is not necessary though, inet_pton is
POSIX.1-2001.

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

https://bugs.winehq.org/show_bug.cgi?id=36713

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

https://bugs.winehq.org/show_bug.cgi?id=36713

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |344bc6d72bb901eba97414fe367
                   |                            |718a89b8778a6
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Bruno Jesus  ---
Fixed in git.

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

https://bugs.winehq.org/show_bug.cgi?id=36713

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.31.

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

https://bugs.winehq.org/show_bug.cgi?id=36713

Dan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Dan  ---
I am a noob and I am also having this issue with watch dogs. This thread says
that it has been fixed, but I do not know where to apply the patches or
anything. Can someone please tell me how to apply the fix and which patch I
need of the two provided?

[Bug 36713] Watch_Dogs requires ws2_32.inet_pton

https://bugs.winehq.org/show_bug.cgi?id=36713

--- Comment #16 from Sebastian Lackner  ---
(In reply to Dan from comment #15)
> I am a noob and I am also having this issue with watch dogs. This thread
> says that it has been fixed, but I do not know where to apply the patches or
> anything. Can someone please tell me how to apply the fix and which patch I
> need of the two provided?

Most likely the reason why you are still encountering this bug is because you
are using an outdated version of Wine. The easiest way to fix it would be to
upgrade to a more recent version (>= 1.7.31). If your distribution doesn't
provide an up-to-date version, you can check the download page of winehq.org.

If there is any specific reason why you need this fix with an old version, you
will have to build Wine and apply the patch yourself. You can find more
information about that on the Wiki, for example
https://wiki.winehq.org/Building_Wine. If you need additional help with
building Wine, the WineHQ forums are a better place to ask, by the way.