http://bugs.winehq.org/show_bug.cgi?id=32711
Bug #: 32711 Summary: BSAopt fails with "Unhandled exception: unimplemented function ADVAPI32.dll.RegSetKeyValueA called" Product: Wine Version: 1.5.21 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: advapi32 AssignedTo: wine-bugs@winehq.org ReportedBy: daniel.santos@pobox.com Classification: Unclassified
Created attachment 43163 --> http://bugs.winehq.org/attachment.cgi?id=43163 patch to add RegSetKeyValue{A,W}
BSAopt is "Bethesda Archive Management and Optimization", the tool for managing archives for their games (Skyrim, Fallout, etc., link here: http://skyrim.nexusmods.com/mods/247). I guess not many people use this function so it hasn't really been hit before.
I've only run the tests for dlls/advapi32/tests/registry.c, a menial test of regedit and a few apps for testing, but no problems are apparent.
http://bugs.winehq.org/show_bug.cgi?id=32711
--- Comment #1 from Nikolay Sivov bunglehead@gmail.com 2013-01-13 04:00:55 CST --- Hi, Daniel.
Patches are not picked from bugzilla, please send it to wine-patches.
Here some obvious issues I spotted:
- function documentation uses old parameter names; - spec file should use wstr for W call; - please add some tests for new calls; - don't use tabs to indent.
http://bugs.winehq.org/show_bug.cgi?id=32711
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com 2013-01-13 04:01:13 CST --- Confirming, calls are not implemented.
http://bugs.winehq.org/show_bug.cgi?id=32711
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source CC| |dank@kegel.com
--- Comment #3 from Dan Kegel dank@kegel.com 2013-01-13 11:19:12 CST --- I think it's a third-party open source tool. See https://github.com/Ethatron/bsaopt/blob/master/bsaopt.C
http://bugs.winehq.org/show_bug.cgi?id=32711
--- Comment #4 from Daniel Santos daniel.santos@pobox.com 2013-01-21 15:42:32 CST --- (In reply to comment #1) Thanks Nikolay. I did submit to wine-patches as well, but I'll fix up these issues and re-submit. I was kinda being lazy with it to be honest. :)
http://bugs.winehq.org/show_bug.cgi?id=32711
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de
--- Comment #5 from André H. nerv@dawncrow.de 2013-04-03 10:42:04 CDT --- @Daniel, any update on this?
http://bugs.winehq.org/show_bug.cgi?id=32711
--- Comment #6 from Daniel Santos daniel.santos@pobox.com 2013-04-03 15:54:49 CDT --- Sorry about that, I had forgotten. I'll fix this up in the next few days. Thanks for the reminder! :)
http://bugs.winehq.org/show_bug.cgi?id=32711
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://go.microsoft.com/fwl | |ink/p/?LinkId=248256 CC| |focht@gmx.net Summary|BSAopt fails with |Multiple applications crash |"Unhandled exception: |on unimplemented function |unimplemented function |ADVAPI32.dll.RegSetKeyValue |ADVAPI32.dll.RegSetKeyValue |A/W (Vista+ API)(BSAopt, |A called" |Microsoft OneDrive)
--- Comment #7 from Anastasius Focht focht@gmx.net --- Hello folks,
still present, also needed for Microsoft 'OneDrive'
Prerequisite: 'WinVer' set to 'Vista' or higher.
--- snip --- $ wine ./OneDriveSetup.exe ... Unhandled exception: unimplemented function ADVAPI32.dll.RegSetKeyValueW called in 32-bit code (0x7bc5276a). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7bc5276a ESP:00bee14c EBP:00bee1b0 EFLAGS:00200216( - -- I -A-P- ) EAX:00bee158 EBX:7bcd1000 ECX:00000058 EDX:00110064 ESI:00000000 EDI:001393c0 ... Backtrace: =>0 0x7bc5276a stub_entry_point+0x4b(dll="ADVAPI32.dll", name="RegSetKeyValueW", ret_addr=0x433c29) [/home/focht/projects/wine/wine.repo/src/dlls/ntdll/loader.c:196] in ntdll (0x00bee1b0) 1 0x0034000f (0x00bee678) 2 0x00431b13 in onedrivesetup (+0x31b12) (0x00bee6fc) 3 0x00440ff0 in onedrivesetup (+0x40fef) (0x00bee750) 4 0x0043f481 in onedrivesetup (+0x3f480) (0x00bee924) 5 0x0043eeae in onedrivesetup (+0x3eead) (0x00bee9c4) 6 0x0043e946 in onedrivesetup (+0x3e945) (0x00bee9e8) ... Modules: Module Address Debug info Name (110 modules) PE 400000- 9d1000 Export onedrivesetup ... Threads: process tid prio (all id:s are in hex) ... 0000002a (D) Z:\home\focht\Downloads\OneDriveSetup.exe 0000003d 0 00000037 0 00000041 0 00000040 0 0000003f 0 0000000b 0 00000020 0 0000002f 0 0000002e 0 <== 0000002b 0 --- snip ---
$ sha1sum OneDriveSetup.exe deafc2778dc6b28a59676e325ff57da761f32bcf OneDriveSetup.exe
$ du -sh OneDriveSetup.exe 5.9M OneDriveSetup.exe
$ wine --version wine-1.7.17-53-g5d31c1e
Regards
http://bugs.winehq.org/show_bug.cgi?id=32711
unsuspicious.fakename+wine@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |unsuspicious.fakename+wine@ | |gmail.com
--- Comment #8 from unsuspicious.fakename+wine@gmail.com --- Same problem in: wine-1.7.18 (multiple applications)
Patch still seems to do the trick.
No idea why this didn't make it into the source yet. Should the bug be cloned so it can be reassigned or something?
http://bugs.winehq.org/show_bug.cgi?id=32711
--- Comment #9 from Anastasius Focht focht@gmx.net --- Hello folks,
'Age of Mythology: Extended Edition' (Steam) launcher also needs this Vista+ API.
http://store.steampowered.com/app/266840/
--- snip --- 8. ImageImportDescriptor: OriginalFirstThunk: 0x00007910 TimeDateStamp: 0x00000000 (GMT: Thu Jan 01 00:00:00 1970) ForwarderChain: 0x00000000 Name: 0x000084F0 ("ADVAPI32.dll") FirstThunk: 0x00005000
Ordinal/Hint API name ------------ --------------------------------------- 0x02A2 "RegSetKeyValueA" ... 0x026A "RegDeleteKeyValueA" ... --- snip ---
I'll create another one for 'RegDeleteKeyValueA'
Regards
https://bugs.winehq.org/show_bug.cgi?id=32711
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=32711
--- Comment #10 from Nikolay Sivov bunglehead@gmail.com --- Looking at this now.
http://bugs.winehq.org/show_bug.cgi?id=32711
--- Comment #11 from Daniel Santos daniel.santos@pobox.com --- hah! sorry I was such a lazy bastard! Thanks for picking up the pices of this one :)
https://bugs.winehq.org/show_bug.cgi?id=32711
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |7041b4db8539db28b06bb873c07 | |f3a3006eca41a Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #12 from Anastasius Focht focht@gmx.net --- Hello folks,
this is fixed by commit http://source.winehq.org/git/wine.git/commitdiff/7041b4db8539db28b06bb873c07...
Thanks Nikolay
Regards
https://bugs.winehq.org/show_bug.cgi?id=32711
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #13 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.22.
https://bugs.winehq.org/show_bug.cgi?id=32711
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://go.microsoft.com/fwl |https://web.archive.org/web |ink/p/?LinkId=248256 |/20140819001912/http://wl.d | |lservice.microsoft.com/down | |load/3/7/9/379B6693-4308-44 | |9C-8556-AB1494F184AF/OneDri | |veSetup.exe
--- Comment #14 from Anastasius Focht focht@gmx.net --- Hello folks,
adding stable download link via Internet Archive for documentation.
https://web.archive.org/web/20140819001912/http://wl.dlservice.microsoft.com...
https://www.virustotal.com/gui/file/83d2429a8568ee4ea0ed002c0897560c6b0a3e0b...
$ sha1sum OneDriveSetup.exe 172ea5833afcc53b4876cb8d9849ba122e5e9223 OneDriveSetup.exe
$ du -sh OneDriveSetup.exe 5.9M OneDriveSetup.exe
Regards