[Bug 14151] New: CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

Summary: CJK characters are displayed as squares when browsing
                    files
           Product: Wine
           Version: CVS/GIT
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: fonts
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

I have many files with Chinese/Japanese file names. 
With wine 1.0, I made font links in 
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\FontLink\SystemLink],
and they were displayed properly.
But now, with wine 1.1,this method seems not to work any more.
All those characters become squares.

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #1 from Lei Zhang   2008-07-05 13:10:35 ---
What entries did you have in
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\FontLink\SystemLink?

What file browser are you using? winefile?

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #2 from [e-mail]  2008-07-06 03:14:16 ---
[Software\Microsoft\Windows NT\CurrentVersion\FontLink\SystemLink]
1214960748
"MS UI Gothic"=str(7):"simsun.ttf,SimSun\0"
"Tahoma"=str(7):"simsun.ttf,SimSun\0"

Not exactly a file browser. When I choose to open some file in an application,
it browses files in my filesystem. That's what I was referring to.

BTW, I can see the characters by exporting LANG=ja_JP.utf8, but not
en_US.utf8, which used to work.

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

甘露(Lu Gan)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from 甘露(Lu Gan)   2008-07-21 12:17:54 ---
I confirm it, and there is really bad display quility for Chinese fonts in 1.1
version, which is a big regression for CJK users.
My system configuration:
Arch Linux
wine 1.1
freetype2 2.3.7
fontconfig 2.6.0
cairo 1.6.4
libxft 2.1.13

Thanks.

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #4 from Lei Zhang   2008-09-04 18:21:35 ---
Seems to work ok here, with zh_CN.UTF-8 or en_US.UTF-8. As long as the
FontLinks are setup correctly. If it doesn't work for you, but used to, please
run a regression test:

http://wiki.winehq.org/RegressionTesting

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #5 from 甘露(Lu Gan)   2008-09-05 19:12:14 ---
Created an attachment (id=15853)
 --> (http://bugs.winehq.org/attachment.cgi?id=15853)
Screenshot: emule+wine (1.1.3)

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #6 from 甘露(Lu Gan)   2008-09-05 19:17:51 ---
I found the real problem is not that wine is unable to display CJK charactors
but display them really really badly, which I mean the display is a mess
(Please check out the attachment). 
The problem occurs under freetype  2.3.7 and fontconfig 2.6.0. wine (1.0.0 -
1.1.3).

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

Daniel Kao  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #7 from Daniel Kao   2008-09-05 21:12:54 ---
(In reply to comment #4)
> Seems to work ok here, with zh_CN.UTF-8 or en_US.UTF-8. As long as the
> FontLinks are setup correctly. If it doesn't work for you, but used to, please
> run a regression test:
>
> http://wiki.winehq.org/RegressionTesting

41aad2dce28ca0dd9d23fa6234ad8523302d6054 is first bad commit
commit 41aad2dce28ca0dd9d23fa6234ad8523302d6054
Author: Dmitry Timoshkov 
Date:   Sun Jun 22 22:41:47 2008 +0900

gdi32: Extend the font substitution test, make it pass under Wine.

:040000 040000 58ba5288003610e79936f9c662dc30a73af9f99f
002dc5ea1f27c3966982f0a7688229708d0455cd M      dlls

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #8 from Daniel Kao   2008-09-05 21:19:48 ---
My font links:
[Software\Microsoft\Windows NT\CurrentVersion\FontLink\SystemLink]
1208451304
"Microsoft Sans Serif"=str(7):"odosung.ttc,AR PL New Sung\0"
"Tahoma"=str(7):"odosung.ttc,AR PL New Sung\0"

(In reply to comment #6)
> I found the real problem is not that wine is unable to display CJK charactors
> but display them really really badly, which I mean the display is a mess
> (Please check out the attachment). 
> The problem occurs under freetype  2.3.7 and fontconfig 2.6.0. wine (1.0.0 -
> 1.1.3).

That looks like an issue with the font, is it (P)MingLiU?

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #9 from [e-mail]  2008-09-06 03:44:41 ---
In the regression test I got the same result as Daniel's.

@ Lei Zhang. Would you mind sharing your font links configuration?

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #10 from 甘露(Lu Gan)   2008-09-06 09:14:20 ---
(In reply to comment #8)
> My font links:
> [Software\Microsoft\Windows NT\CurrentVersion\FontLink\SystemLink]
> 1208451304
> "Microsoft Sans Serif"=str(7):"odosung.ttc,AR PL New Sung\0"
> "Tahoma"=str(7):"odosung.ttc,AR PL New Sung\0"
>
> (In reply to comment #6)
> > I found the real problem is not that wine is unable to display CJK charactors
> > but display them really really badly, which I mean the display is a mess
> > (Please check out the attachment). 
> > The problem occurs under freetype  2.3.7 and fontconfig 2.6.0. wine (1.0.0 -
> > 1.1.3).
>
> That looks like an issue with the font, is it (P)MingLiU?

I certainly doubt that, you can see there is good display at the some left
parts in the same screenshot.

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #11 from Daniel Kao   2008-09-06 17:31:08 ---
(In reply to comment #10)
> I certainly doubt that, you can see there is good display at the some left
> parts in the same screenshot.

This is precisely the behavior I expect from (P)MingLiU: it breaks at certain
sizes but renders correctly in others. Supposedly this is due to the
non-standard TrueType technology in (P)MingLiU that assembles characters from
smaller parts.
But all this is assuming that font is indeed (P)MingLiU.

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #12 from 甘露(Lu Gan)   2008-09-06 19:26:48 ---
(In reply to comment #11)
> (In reply to comment #10)
> > I certainly doubt that, you can see there is good display at the some left
> > parts in the same screenshot.
>
> This is precisely the behavior I expect from (P)MingLiU: it breaks at certain
> sizes but renders correctly in others. Supposedly this is due to the
> non-standard TrueType technology in (P)MingLiU that assembles characters from
> smaller parts.
> But all this is assuming that font is indeed (P)MingLiU.

The font is wqy-zenhei, and it is displayed perfectly under Fedora 9 (which has
older version of freetype and fontconfig).

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |1.1.0

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #13 from Daniel Kao   2008-11-11 19:04:04 ---
This bug now occurs with 1.0.1 as well. The commit in comment #7 is present in
the ANNOUNCE file as a change since 1.0.

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #14 from Lei Zhang   2008-12-05 19:35:32 ---
Created an attachment (id=17667)
 --> (http://bugs.winehq.org/attachment.cgi?id=17667)
screenshots

[e-mail]: so is your problem like the one in this screenshot on the
left?

甘露: is your problem the characters are displayed really poorly (as seen in
attachment 15853) compared to the screenshot on the right?

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #15 from 甘露(Lu Gan)   2008-12-06 03:58:42 ---
(In reply to comment #14)
> Created an attachment (id=17667)

--> (http://bugs.winehq.org/attachment.cgi?id=17667) [details]
> screenshots
>
> [e-mail]: so is your problem like the one in this screenshot on the
> left?
>
> 甘露: is your problem the characters are displayed really poorly (as seen in
> attachment 15853 [details]) compared to the screenshot on the right?

My problem is somewhere Chinese characters are displayed as blank box, not only
poorly. I update my screenshot to show the problem more correctly (a
'work-around' patch which needs more reviews), and there is a discuss (Chinese
forum if needed I can tranlate most of them for you) for reference:
http://forum.ubuntu.org.cn/viewtopic.php?f=121&t=169647

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #16 from 甘露(Lu Gan)   2008-12-06 04:06:05 ---
Created an attachment (id=17675)
 --> (http://bugs.winehq.org/attachment.cgi?id=17675)
wine 1.1.9 under Fedora 10, zh_CN.UTF-8 locale

You can see somewhere is correctly displayed, but somewhere isn't.

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17675|application/octet-stream    |image/png
          mime type|                            |

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #17 from [e-mail]  2008-12-07 03:39:54 ---
(In reply to comment #14)
Never tested with emule, but yes, my applications look like that.

PS:
I noticed that only links to Tahoma dont work when I use 
en_US.UTF-8 locale. Under a zh_CN.UTF-8 locale, wine seems to
prefer Microsoft Sans Serif as the default font, and then 
the fontlink works perfectly.

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]      |
             Status|UNCONFIRMED                 |RESOLVED
          Component|fonts                       |-unknown
           Keywords|regression                  |
         Resolution|                            |INVALID

--- Comment #18 from Dmitry Timoshkov   2008-12-07 03:51:11 ---
Then the bug is invalid. You must use appropriate locale.

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Dmitry Timoshkov   2008-12-07 03:51:22 ---
Closing.

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |fonts

--- Comment #20 from Lei Zhang   2008-12-07 04:00:21 ---
(In reply to comment #15)
> My problem is somewhere Chinese characters are displayed as blank box, not only
> poorly. I update my screenshot to show the problem more correctly (a
> 'work-around' patch which needs more reviews), and there is a discuss (Chinese
> forum if needed I can tranlate most of them for you) for reference:
> http://forum.ubuntu.org.cn/viewtopic.php?f=121&t=169647

Lu Gan, In your previous screen shot, attachment 15853, it was working. What
happened?

Did you set up font linking? If so, what are the linked fonts?

If you're compiling Wine yourself, Maybe this patch helps?
http://www.winehq.org/pipermail/wine-patches/2008-December/065543.html

I guess [e-mail] wasn't talking about emule in his original report. Why
don't you open a new bug for CJK character support in eMule?

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|fonts                       |-unknown

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #21 from 甘露(Lu Gan)   2008-12-07 17:27:25 ---
(In reply to comment #20)
> (In reply to comment #15)
> > My problem is somewhere Chinese characters are displayed as blank box, not only
> > poorly. I update my screenshot to show the problem more correctly (a
> > 'work-around' patch which needs more reviews), and there is a discuss (Chinese
> > forum if needed I can tranlate most of them for you) for reference:
> > http://forum.ubuntu.org.cn/viewtopic.php?f=121&t=169647
>
> Lu Gan, In your previous screen shot, attachment 15853 [details], it was working. What
> happened?
>
> Did you set up font linking? If so, what are the linked fonts?
>
> If you're compiling Wine yourself, Maybe this patch helps?
> http://www.winehq.org/pipermail/wine-patches/2008-December/065543.html
>
> I guess [e-mail] wasn't talking about emule in his original report. Why
> don't you open a new bug for CJK character support in eMule?

The second sreenshot, I don't touch anything, For poorly working 1# one, I set
MS Shell Dlg as empty in HKLM\Software\Microsoft\Windows
NT\CurrentVersion\FontSubstitutes, and link Tohama font to a chinese font in
HKLM\Software\Microsoft\Windows NT\CurrentVersion\FontLink\Systemlink.
Your patch could work, but I can't try currently, thank you very much.

[Bug 14151] CJK characters are displayed as squares when browsing files

http://bugs.winehq.org/show_bug.cgi?id=14151

--- Comment #22 from [e-mail]  2008-12-10 19:14:59 ---
(In reply to comment #20)
> If you're compiling Wine yourself, Maybe this patch helps?
> http://www.winehq.org/pipermail/wine-patches/2008-December/065543.html

Thank you Lei Zhang. Your patch works like a charm!