http://bugs.winehq.org/show_bug.cgi?id=33719
Bug #: 33719 Summary: comctl32:propsheet custom window proc test failure Product: Wine Version: 1.5.19 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: comctl32 AssignedTo: wine-bugs@winehq.org ReportedBy: fgouget@codeweavers.com Classification: Unclassified
A number of VMs report one of these two related test failures:
Elevated privileges (or pre-Vista):
propsheet.c:746: Test failed: property sheet with custom window proc: the msg 0x001c was expected, but got msg 0x0047 instead
or not elevated privileges:
propsheet.c:746: Test failed: property sheet with custom window proc: the msg 0x0046 was expected, but got msg 0x0210 instead
They have been seen on the following systems: comctl32 5.81.4968.2500 Windows 2000 Professional SP4 + IE55 (rare ~1/50) comctl32 5.82.3790.3959 Windows 2003 Enterprise Server SP2 + IE8 (rare ~1/50) comctl32 5.82.6002.18305 Windows Vista Home Premium SP2+IE9 comctl32 5.82.7601.17514 Windows 7 Ultimate SP1 64-bit (+IE8) (32-bit tests) comctl32 5.82.7601.17514 Windows 7 Ultimate SP1 64-bit + IE9 (32-bit tests) comctl32 5.82.7601.17514 Windows 7 SP1 (not one of mine) comctl32 5.82.9200.16384 Windows 8
http://bugs.winehq.org/show_bug.cgi?id=33719
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source
http://bugs.winehq.org/show_bug.cgi?id=33719
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OS/Version|Linux |Windows
http://bugs.winehq.org/show_bug.cgi?id=33719
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, testcase
https://bugs.winehq.org/show_bug.cgi?id=33719
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression URL| |http://test.winehq.org/data | |/tests/comctl32:propsheet.h | |tml Regression SHA1| |43aa5f6b2e61d070121993d6f20 | |3c2ea195de3ed
--- Comment #1 from François Gouget fgouget@codeweavers.com --- This test failure still happens but seems to only plague the Windows 7 and Windows 8/8.1 systems (including my Acer laptop) these days. See:
http://test.winehq.org/data/tests/comctl32:propsheet.html
The commit that introduced the test is:
commit 43aa5f6b2e61d070121993d6f203c2ea195de3ed Author: Bernhard Übelacker bernhardu@vr-web.de Date: Sat Nov 6 09:54:12 2010 +0100
comctl32: Test for window messages of a property sheet with custom dialog proc.
https://bugs.winehq.org/show_bug.cgi?id=33719
--- Comment #2 from Austin English austinenglish@gmail.com --- This fails under valgrind consistently, bug 36237. There's also a leak it shows, bug 36236.
https://bugs.winehq.org/show_bug.cgi?id=33719
--- Comment #3 from Austin English austinenglish@gmail.com --- (In reply to Austin English from comment #2)
This fails under valgrind consistently, bug -edited- There's also a leak it shows, bug 36236.
valgrind bugs are bug 36236 and bug 36238
https://bugs.winehq.org/show_bug.cgi?id=33719
Bernhard Übelacker bernhardu@vr-web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bernhardu@vr-web.de
--- Comment #4 from Bernhard Übelacker bernhardu@vr-web.de --- A patch was sent last year to try to solve this issue here (which made it not into git): https://www.winehq.org/pipermail/wine-patches/2014-May/132374.html (This patch tried to make sure the tested windows are in foreground.)
However, the tests started to succeed since the 26.05.2015.
(Not only the propsheet but also the listview test succeeds since then. listview test succeeded last year also when brought to foreground.)
Could not find a specific change addressed to this issue in git history.
So is the succeeding a side effect of another patch or has something changed on testbot?
https://bugs.winehq.org/show_bug.cgi?id=33719
--- Comment #5 from François Gouget fgouget@codeweavers.com --- propsheet.c:746: Test failed: property sheet with custom window proc: the msg 0x0046 was expected, but got msg 0x0210 instead
This test failure still happens on the following WineTest boxes. All are running the test in an administrator account without elevated privileges: fg-win7u64-1spie9adm - Windows 7 Ultimate 32 bit cw-gtx560-t64 - Windows 8.1 64 bit cw-hd6800-t32 - Windows 8.1 32 bit cw-hd6800-t64 - Windows 8.1 64 bit
The common point seems to be the lack of sufficient privileges.
https://bugs.winehq.org/show_bug.cgi?id=33719
--- Comment #6 from François Gouget fgouget@codeweavers.com --- When trying to reproduce this failure outside WineTest I found out that it was caused by cmd.exe:batch.
The cmd tests were running regedit to clean up the registry even though they had insufficient privileges to modify it in the first place. This caused regedit (or Windows?) to pop up a dialog asking whether to allow regedit to modify the registry, causing a timeout of the cmd.exe:batch test. When the timeout occurred the cmd.exe_test.exe process got killed by winetest.exe. This left the regedit process around though it did exit seemingly almost immediately. Still I think it's the dialog that was causing the comctl32:propsheet error.
I wonder if something should be done at the WineTest level to avoid this situation. A simple solution might be to wait a couple of seconds. A better one may be to kill the whole process tree in case of a timeout.
I sent a fix for cmd.exe:batch so comctl32:propsheet should not be bothered by it. On Windows 7 cmd.exe:batch seemed to cause comctl32 failures in header, listview, pager, progress and syslink} too which this fixed too. So I don't know if it still make sense to apply this patch to comctl32:propsheet. I guess it would make that test more robust but at the cost of added complexity and in theory the same patch should be added to all these other tests too.
https://bugs.winehq.org/show_bug.cgi?id=33719
joaopa jeremielapuree@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr
--- Comment #7 from joaopa jeremielapuree@yahoo.fr --- Is still a bug in current wine(3.20)?
https://bugs.winehq.org/show_bug.cgi?id=33719
Huw Davies huw.davies@physics.ox.ac.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |huw.davies@physics.ox.ac.uk
--- Comment #8 from Huw Davies huw.davies@physics.ox.ac.uk --- There haven't been any recent propsheet failures.
https://bugs.winehq.org/show_bug.cgi?id=33719
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 4.0-rc5.