http://bugs.winehq.org/show_bug.cgi?id=22100
Summary: SystemFunction036 has wrong prototype Product: Wine Version: 1.1.41 Platform: x86 OS/Version: All Status: UNCONFIRMED Severity: normal Priority: P2 Component: advapi32 AssignedTo: wine-bugs@winehq.org ReportedBy: mtr1999@gmx.com
SystemFunction036 in advapi32/crypt.c returns BOOLEAN instead of BOOL. http://msdn.microsoft.com/en-us/library/aa387694%28VS.85%29.aspx
These two types are different. http://msdn.microsoft.com/en-us/library/aa383751%28VS.85%29.aspx
typedef int BOOL; typedef BYTE BOOLEAN;
This doesn't fail the SystemFunction036 winetest because the prototype there is wrong too.
The ntsecapi.h header has the right prototype.
http://bugs.winehq.org/show_bug.cgi?id=22100
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OS/Version|All |other Severity|normal |trivial
--- Comment #1 from Dmitry Timoshkov dmitry@codeweavers.com 2010-03-21 03:48:10 --- In reality this doesn't change anything. Feel free to send a patch.
http://bugs.winehq.org/show_bug.cgi?id=22100
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Component|advapi32 |-unknown Resolution| |INVALID
--- Comment #2 from Dmitry Timoshkov dmitry@codeweavers.com 2010-03-21 03:50:15 --- Actually this bug is invalid, you are confusing ntdll and advapi32.
http://bugs.winehq.org/show_bug.cgi?id=22100
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #3 from Dmitry Timoshkov dmitry@codeweavers.com 2010-03-21 03:50:32 --- Closing invalid.
http://bugs.winehq.org/show_bug.cgi?id=22100
Andrew Nguyen arethusa26@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |UNCONFIRMED Resolution|INVALID |
--- Comment #4 from Andrew Nguyen arethusa26@gmail.com 2010-03-21 10:39:48 --- (In reply to comment #2)
Actually this bug is invalid, you are confusing ntdll and advapi32.
I don't see how this is the case, as SystemFunction036 is exclusvely exported in advapi32, and RtlGenRandom is just a define for that function. I've sent a patch that corrects the prototype:
http://source.winehq.org/patches/data/59564
http://bugs.winehq.org/show_bug.cgi?id=22100
Andrew Nguyen arethusa26@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #5 from Andrew Nguyen arethusa26@gmail.com 2010-03-21 10:40:13 --- Confirming the bug.
http://bugs.winehq.org/show_bug.cgi?id=22100
--- Comment #6 from Dmitry Timoshkov dmitry@codeweavers.com 2010-03-22 02:11:43 --- You are right: http://blogs.msdn.com/michael_howard/archive/2005/01/14/353379.aspx
http://bugs.winehq.org/show_bug.cgi?id=22100
Andrew Nguyen arethusa26@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #7 from Andrew Nguyen arethusa26@gmail.com 2010-03-22 12:27:42 --- This should be fixed by commit 890ce5360dd4ef14dcbebfa694d9af34f35e07bc.
http://bugs.winehq.org/show_bug.cgi?id=22100
--- Comment #8 from mtr1999@gmx.com 2010-03-22 23:56:58 --- I think that line 1096 of dlls/advapi32/tests/crypt.c should be changed too.
Thanks
http://bugs.winehq.org/show_bug.cgi?id=22100
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org 2010-04-02 12:52:32 --- Closing bugs fixed in 1.1.42.
-
wine-bugs＠winehq.org