[Bug 19489] New: WinHttpSendRequest does not support empty string ("") as headers argument

http://bugs.winehq.org/show_bug.cgi?id=19489

Summary: WinHttpSendRequest does not support empty string ("")
                    as headers argument
           Product: Wine
           Version: 1.1.26
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: winhttp
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=22659)
 --> (http://bugs.winehq.org/attachment.cgi?id=22659)
simple fix for problem mentioned

When using WinHttpSendRequest() with an empty string as 'headers' argument and
-1 as a value for the header length, an INVALID_PARAMETER error is returned.

add_request_headers() in winhttp/request.c correctly performs a strlen() on the
headers argument if header length is specified as -1.

The problem is that if headers is an empty string, and there is no actual
header, the search for '\r\n\ fails, the terminating zero is found, and
add_request_header breaks out of the loop with a FALSE return value.

Under Windows, this call is successful.

Attached simple return statement fixes the problem (but maybe should be fixed
in a different way).

Thanks,
Arnoud.

[Bug 19489] WinHttpSendRequest does not support empty string ("") as headers argument

http://bugs.winehq.org/show_bug.cgi?id=19489

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Hans Leidekker   2009-07-28 09:33:06 ---
Please send the patch to [e-mail] in diff -u format.

[Bug 19489] WinHttpSendRequest does not support empty string ("") as headers argument

http://bugs.winehq.org/show_bug.cgi?id=19489

--- Comment #2 from Austin English   2009-07-28 11:12:45 ---
(In reply to comment #0)
> Created an attachment (id=22659)

--> (http://bugs.winehq.org/attachment.cgi?id=22659) [details]
> simple fix for problem mentioned
>
> When using WinHttpSendRequest() with an empty string as 'headers' argument and
> -1 as a value for the header length, an INVALID_PARAMETER error is returned.
>
> add_request_headers() in winhttp/request.c correctly performs a strlen() on the
> headers argument if header length is specified as -1.
>
> The problem is that if headers is an empty string, and there is no actual
> header, the search for '\r\n\ fails, the terminating zero is found, and
> add_request_header breaks out of the loop with a FALSE return value.
>
> Under Windows, this call is successful.

Please add a testcase before submitting to wine-patches.

[Bug 19489] WinHttpSendRequest does not support empty string ("") as headers argument

http://bugs.winehq.org/show_bug.cgi?id=19489

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Dan Kegel   2009-10-29 12:50:12 ---
Committed,
http://www.winehq.org/pipermail/wine-cvs/2009-October/061094.html

What apps did this affect?

[Bug 19489] WinHttpSendRequest does not support empty string ("") as headers argument

http://bugs.winehq.org/show_bug.cgi?id=19489

--- Comment #4 from Arnoud   2009-11-03 07:34:28 ---
(In reply to comment #3)
> Committed,
> http://www.winehq.org/pipermail/wine-cvs/2009-October/061094.html
>
> What apps did this affect?

Thanks. That was a private app that I had to port to wine. Just wanted to
backport some patches I did for that project, as the app acted conform the
APIs.

[Bug 19489] WinHttpSendRequest does not support empty string ("") as headers argument

http://bugs.winehq.org/show_bug.cgi?id=19489

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Vitaliy Margolen   2009-11-03 07:56:55 ---
Patch accepted - fixed

[Bug 19489] WinHttpSendRequest does not support empty string ("") as headers argument

http://bugs.winehq.org/show_bug.cgi?id=19489

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard   2009-11-13 12:44:15 ---
Closing bugs fixed in 1.1.33.