[Bug 15013] New: Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

Summary: Thunder:Can't finish any task.
           Product: Wine
           Version: 1.1.3
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Thunder(xunlei) download link(You need to install it
first):http://down.sandai.net/Thunder5.8.4.572.exe

I can't use it to finish tasks.(It is the main use of this software)You can
read the picture below to know the situation.(The task stop at the 99.9%)
http://appdb.winehq.org/appimage.php?iId=19736
Here is a test link.You can try to use Thunder(xunlei) to download it and you
may know what the bug I find is.(only
4M)ftp://202.107.228.143:26/pub/games/games/koei/sea2a.zip

distribution:RedFlag Linux Desktop 6.0 SP1
compiler:
Using built-in specs.
Target: i386-pc-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man
--infodir=/usr/share/info --enable-shared --enable-threads=posix
--enable-checking=release --with-system-zlib --enable-__cxa_atexit
--disable-libunwind-exceptions --enable-libgcj-multifile --disable-libmudflap
--enable-languages=c,c++,java,fortran --disable-libgcj --with-cpu=generic
--host=i386-pc-linux
Thread model: posix
gcc version 4.2.1
command line:wine  .wine/drive_c/Program\ Files/Thunder\
Network/Thunder/Thunder.exe

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

--- Comment #1 from LIU An   2008-08-25 22:46:40 ---
dll needed:mfc42.dll You've to copy this dll into windows/system32 directory.

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://down.sandai.net/Thund
                   |                            |er5.8.4.572.exe
           Keywords|                            |download

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

--- Comment #2 from Vijay Kamuju   2008-08-26 12:46:24 ---
does it have english language options?
if so I would like you to provide that link.
I tried to replicate the issue.
Its giving an E_ACCESS_VIOLATION error and crashing.

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

--- Comment #3 from LIU An   2008-08-27 02:48:25 ---
(In reply to comment #2)
> does it have english language options?
> if so I would like you to provide that link.
> I tried to replicate the issue.
> Its giving an E_ACCESS_VIOLATION error and crashing.

Sorry, I've never found the English language options in xunlei.But I can
provide some help.
Although Thunder(xunlei) doesn't support English mode,there is a similar
software called "gigaget". It is an English version of Thunder(xunlei).But
"gigaget" is rarely used in mainland China.

Thunder(xunlei) and "gigaget" is developed by the same corporation.But
"gigaget" works well,no error happened.
You can download gigaget here.http://www.gigaget.com/setup.exe

Now,I'll provide some help.
You can press <Ctrl+N> to add a task,press <F5> to resume the task,press <F6>
to pause the task.You can try.

I'll add two attachments.
The first attachment is about how to add a task.
The second is the moment that error happening.

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

--- Comment #4 from LIU An   2008-08-27 02:58:57 ---
Created an attachment (id=15675)
 --> (http://bugs.winehq.org/attachment.cgi?id=15675)
Add a task.(ogm file)

I the file,I click on the add button.You can also press<Ctrl+N> to add the
task.

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

--- Comment #5 from LIU An   2008-08-27 03:36:21 ---
Created an attachment (id=15676)
 --> (http://bugs.winehq.org/attachment.cgi?id=15676)
When the error happened.The task progress keeping at 99.9%.

I run md5sum to compare two file.One is downloaded by gigaget.(normal)The other
is downloaded by Thunder(xunlei)5.8.x.y.(abnormal,I force stop the task when
the progress staying at 99.9% so as to got this file)I got the conclusion
below.

340b0c760fd8592ddbd4b57af3bd0839  sea2a.zip  \normal file
b4dc49e4efc62aab06c9d62712a5b1e3  sea2a.zip  \abnormal file

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

--- Comment #6 from LIU An   2008-08-27 04:17:41 ---
(In reply to comment #2)
> does it have english language options?
> if so I would like you to provide that link.
> I tried to replicate the issue.
> Its giving an E_ACCESS_VIOLATION error and crashing.

The EXCEPTION_ACCESS_VIOLATION error is another bug.You can read
http://bugs.winehq.org/show_bug.cgi?id=15012

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

--- Comment #7 from LIU An   2008-08-27 21:21:30 ---
Created an attachment (id=15699)
 --> (http://bugs.winehq.org/attachment.cgi?id=15699)
Backtrace

Well,I successfully replicate the issue again by taking the followning
steps.And I finally get the backtrace.
remove the .wine directory
running winecfg to rebuild the .wine directory
copy mfc42.dll into system32 directory
install the Thunder(xunlei)
run xunlei using wine
add the task
replicate the issue

Here is a usable version of Thunder.It is more stable than Thunder 5.8.4.572.
http://down.sandai.net/Thunder5.5.6.274.exe
You can successfully download the files with Thunder5.5.6.274.This version has
no bugs.But it lack of functions(i.e. BitTorrent)

You can consult the appDB
http://appdb.winehq.org/objectManager.php?sClass=application&iId=6598

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #8 from Austin English   2010-06-04 00:08:46 ---
Still present in wine-1.2-rc2-111-g9aa9a12

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

fracting  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from fracting  2011-12-20 23:29:28 CST ---
*** Bug 28120 has been marked as a duplicate of this bug. ***

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Bruno Jesus  2012-12-04 19:23:17 CST ---
Patch commited to implement SetFileValidData:
http://source.winehq.org/git/wine.git/?a=commit;h=c019083240e70b52fb119dad46...

Since bug 28120 was about this function and it was marked as duplicate of this
one I bet this one is fixed.

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

--- Comment #11 from Qian Hong  2012-12-04 19:39:14 CST ---
(In reply to comment #10)
> Patch commited to implement SetFileValidData:
> http://source.winehq.org/git/wine.git/?a=commit;h=c019083240e70b52fb119dad46...
>
> Since bug 28120 was about this function and it was marked as duplicate of this
> one I bet this one is fixed.

Dear Bruno, thanks for reminder :)

Unfortunately no luck from my test result, Hans also told me 'that
SetFileValidData is a performance optimization, so unless it checks the return
value this patch is not likely to have an effect on this application.'

So it seems not related to this bug.

I doubt this bug is related to I/O Completion Ports and ws2_32, but I'm not
familiar with those things.

Thanks anyone for any trying to improve this!

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

Ma Xiaojun  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Ma Xiaojun  2012-12-20 15:06:18 CST ---
Thunder Mini is the minimalistic version of Thunder.
It should make studying of this bug a little easier.

http://dl.dropbox.com/u/45139465/thunder_mini.ogv
The above video demo how to reproduce this bug using Thunder Mini, starting
from installation.
The locale is en_US.UTF-8 and the wine version is 1.5.19

The cheat sheet used in the video is pasted here:
wget http://dl.dropbox.com/u/45139465/ThunderMini1.5.3.288.exe
575af18f955f71d2dcd0b33bfd5878f34d4d2588 ThunderMini1.5.3.288.exe
http://down.sandai.net/mini/ThunderMiniInstall.exe

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

--- Comment #13 from Ma Xiaojun  2012-12-20 16:16:05 CST ---
In case someone want canonical download link of Thunder Mini 1.5.3.288, it is:
http://down.sandai.net/mini/ThunderMini1.5.3.288.exe

As I just tried it works with wget.
I have no idea whether the link will become invalid when new version of Thunder
Mini is released.

An also canonical and more general download link of Thunder Mini is:
http://down.sandai.net/mini/ThunderMiniInstall.exe

It also works wget at this point.
But I have no clue why file downloaded with this link has a different SHA-1
(tried two times).

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

lizhenbo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

--- Comment #14 from lizhenbo  2013-01-30 06:49:59 CST ---
Confirmed in Wine 1.5.22
(after winetrick mfc42)

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

Guo Jian  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 15013] Thunder:Can't finish any task.

http://bugs.winehq.org/show_bug.cgi?id=15013

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 15013] Thunder:Can't finish any task.

https://bugs.winehq.org/show_bug.cgi?id=15013

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |553ba810b8e5034415992d99bf9
                   |                            |70b2ebb7a85ce
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Qian Hong  ---
Fixed by

commit 553ba810b8e5034415992d99bf970b2ebb7a85ce
Author: Alexandre Julliard 
Date:   Wed Sep 10 13:49:40 2014 +0200

kernel32: Pass the correct completion values in ReadFileScatter and
WriteFileGather.

Test case based on a patch by Guo Jian.

Thanks Alexandre and Guo Jian!

[Bug 15013] Thunder:Can't finish any task.

https://bugs.winehq.org/show_bug.cgi?id=15013

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.27.

[Bug 15013] Thunder:Can't finish any task.

https://bugs.winehq.org/show_bug.cgi?id=15013

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |kernel32