[Bug 28259] New: Jedi Knight demo crashes in ddraw

http://bugs.winehq.org/show_bug.cgi?id=28259

Summary: Jedi Knight demo crashes in ddraw
           Product: Wine
           Version: 1.3.27
          Platform: x86
               URL: http://www.gamefront.com/files/3058720/Star-Wars-Jedi-
                    Knight-Dark-Forces-II-Demo/
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-ddraw
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
   Regression SHA1: 76fecde8fb2d335e4855bec6d36ffe16cbed04f3

Created an attachment (id=36211)
 --> (http://bugs.winehq.org/attachment.cgi?id=36211)
terminal output

This bug (regression) appeared a couple of days ago in git and it prevents bug
#28157 from testing.

Symptom: The demo crashes right after starting in Wine's ddraw component.

This is caused by

76fecde8fb2d335e4855bec6d36ffe16cbed04f3 is the first bad commit
commit 76fecde8fb2d335e4855bec6d36ffe16cbed04f3
Author: Stefan Dösinger 
Date:   Fri Aug 26 14:22:40 2011 +0200

ddraw: Introduce a function to convert a DDSURFACEDESC to a DDSURFACEDESC2.

:040000 040000 5e597610866aded4d579f3406fb158e950e740c3
5bffaefddf571ab094cca924f12bc5544ade8c1b M    dlls

Fedora 15 x86
Nvidia gfx card / driver 280.13

[Bug 28259] Jedi Knight demo crashes in ddraw

http://bugs.winehq.org/show_bug.cgi?id=28259

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
             Blocks|                            |28157

[Bug 28259] Jedi Knight demo crashes in ddraw

http://bugs.winehq.org/show_bug.cgi?id=28259

--- Comment #1 from Stefan Dösinger  2011-09-03 13:44:41 CDT ---
The issue is fairly straightforward, EnumDisplayFormats and friends should
check for NULL before trying to convert the DDSD. I have a patch with tests,
I'll send it later today or tomorrow.

[Bug 28259] Jedi Knight demo crashes in ddraw

http://bugs.winehq.org/show_bug.cgi?id=28259

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from GyB  2011-09-07 13:25:43 CDT ---
Fixed in wine-1.3.27-357-gac0a7b6 by
http://source.winehq.org/git/wine.git/commit/8e79a7e6644fd6f1e0cfeb8b826e683...

Thank you

[Bug 28259] Jedi Knight demo crashes in ddraw

http://bugs.winehq.org/show_bug.cgi?id=28259

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  2011-09-09 12:54:43 CDT ---
Closing bugs fixed in 1.3.28.

[Bug 28259] Jedi Knight demo crashes in ddraw

http://bugs.winehq.org/show_bug.cgi?id=28259

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |8e79a7e6644fd6f1e0cfeb8b826
                   |                            |e683d171d723a

[Bug 28259] Jedi Knight demo crashes in ddraw

http://bugs.winehq.org/show_bug.cgi?id=28259

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-ddraw               |directx-d3d