[Bug 38962] New: expr.c:234 and 235 attempted computation of 1 << 31 should be 1u << 31

https://bugs.winehq.org/show_bug.cgi?id=38962

Bug ID: 38962
           Summary: expr.c:234 and 235 attempted computation of 1 << 31
                    should be 1u << 31
           Product: Wine
           Version: 1.7.47
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: tools
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Running widl, in tools/widl/expr.c lines 234 and 235:

cast_mask = ((1 << (cast_type_bits - 1)) - 1) | 
                            1 << (cast_type_bits - 1);

cast_type_bits is 32 thus causing computation of 1 << 31 which cannot be
represented in type 'int'.
This is illegal and undefined.
It should be 
cast_mask = ((1u << (cast_type_bits - 1)) - 1) | 
                            1u << (cast_type_bits - 1);

instead.

[Bug 38962] expr.c:234 and 235 attempted computation of 1 << 31 should be 1u << 31

https://bugs.winehq.org/show_bug.cgi?id=38962

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

--- Comment #1 from Ken Sharp  ---
If you know how to fix an issue then it saves time to simply submit the
patches.
http://wiki.winehq.org/SubmittingPatches

[Bug 38962] expr.c:234 and 235 attempted computation of 1 << 31 should be 1u << 31

https://bugs.winehq.org/show_bug.cgi?id=38962

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38962] expr.c:234 and 235 attempted computation of 1 << 31 should be 1u << 31

https://bugs.winehq.org/show_bug.cgi?id=38962

lizhenbo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38962] expr.c:234 and 235 attempted computation of 1 << 31 should be 1u << 31

https://bugs.winehq.org/show_bug.cgi?id=38962

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from [e-mail] ---
https://source.winehq.org/patches/data/123511

This bug should be fixed with commit id

bb9b2f33ae5894478ef509fae3f4b8e24267682a

[Bug 38962] expr.c:234 and 235 attempted computation of 1 << 31 should be 1u << 31

https://bugs.winehq.org/show_bug.cgi?id=38962

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |bb9b2f33ae5894478ef509fae3f
                   |                            |4b8e24267682a

--- Comment #3 from Bruno Jesus  ---
(In reply to super_man from comment #2)
> https://source.winehq.org/patches/data/123511
>
> This bug should be fixed with commit id
>
> bb9b2f33ae5894478ef509fae3f4b8e24267682a

Thanks.

[Bug 38962] expr.c:234 and 235 attempted computation of 1 << 31 should be 1u << 31

https://bugs.winehq.org/show_bug.cgi?id=38962

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.13.

[Bug 38962] expr.c:234 and 235 attempted computation of 1 << 31 should be 1u << 31

https://bugs.winehq.org/show_bug.cgi?id=38962

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
   Target Milestone|---                         |1.8.x

[Bug 38962] expr.c:234 and 235 attempted computation of 1 << 31 should be 1u << 31

https://bugs.winehq.org/show_bug.cgi?id=38962

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.8.x                       |---

--- Comment #5 from Michael Stefaniuc  ---
Removing 1.8.x milestone from bugs included in 1.8.4.