[Bug 51911] New: vbscript does not handle strings in if clauses

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51911

Bug ID: 51911
           Summary: vbscript does not handle strings in if clauses
           Product: Wine
           Version: 6.19
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: vbscript
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

This is followup from https://bugs.winehq.org/show_bug.cgi?id=50758

Test with postgresql-9.3 installer from [1]. It runs a script during
installation 
similar to
https://github.com/three-plus-three/tpt_env_amd64/blob/master/postgresql/ins...
that reports non-critical error to main install, script itself terminates.

Reduced test case for this looks like this:

---
if "0" then 
end if
---

That leads to the following fixme, exactly that happens with the installer:

---
00f8:fixme:vbscript:stack_pop_bool unsupported for 000000000003C740 {VT_BSTR:
L"0"}
---

[1] https://www.enterprisedb.com/postgresql-tutorial-resources-training?cid=340

[Bug 51911] vbscript does not handle strings in if clauses

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51911

Robert Wilhelm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://web.archive.org/web
                   |                            |/20211009084355if_/https://
                   |                            |get.enterprisedb.com/postgr
                   |                            |esql/postgresql-9.3.25-1-wi
                   |                            |ndows-x64.exe
           Keywords|                            |download

[Bug 51911] vbscript does not handle strings in if clauses

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51911

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] ---
patch from 218656 got merged into wine, so fixed?

[Bug 51911] vbscript does not handle strings in if clauses

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51911

Robert Wilhelm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |b9e38a41eabbe444ba55eab7a0a
                   |                            |5573dfb7f9a6b
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Robert Wilhelm  ---
Yes, after

https://source.winehq.org/git/wine.git/commit/b9e38a41eabbe444ba55eab7a0a557...

fixme:vbscript:stack_pop_bool unsupported for 000000000005E080 {VT_BSTR: L"0"}

is gone. Setting status fixed.

There are still scrrun and wbem issues with the script, most often 
fixme:scrrun:folder_CreateTextFile (004987D8)->(L"radF75FC.tx" ffffffff 0
0031EFC0): stub

But this deserves a distinct bug report.

[Bug 51911] vbscript does not handle strings in if clauses

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51911

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 6.21.

[Bug 51911] vbscript does not handle strings in if clauses

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51911

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |6.0.x

[Bug 51911] vbscript does not handle strings in if clauses

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51911

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|6.0.x                       |---

--- Comment #4 from Michael Stefaniuc  ---
Removing the 6.0.x milestone from bug fixes included in 6.0.4.