[Bug 47724] New: Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

Bug ID: 47724
           Summary: Office 2007 SP3 not installing
                    (msi_apply_patch_package failed to open patch
                    collection)
           Product: Wine
           Version: 4.15
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 65198
  --> https://bugs.winehq.org/attachment.cgi?id=65198
WINEDEBUG=+msxml wine office2007sp3-kb2526086-fullfile-en-us.exe &> sp3.log

Clear wine prefix, WINEARCH=win32 (win64 doesn't work too), no tweaks or
winetricks. Windows 7 and Windows XP mode.

1. Installation of en_office_enterprise_2007_dvd_vl_x12-19574.iso (wine
setup.exe) goes fine
2. "wine office2007sp3-kb2526086-fullfile-en-us.exe" aparenttly goes right, I
receive the message "Do you want to reboot now to complete the installation of
this package? YES NO". The wine process ends.
3. Every files in C:\Program Files\Microsoft Office\Office12 are dated <= 2006,
and the version of Word, Excel, etc, does not report SP, only original "MSO
(12.0.4518.1014)"

# wine --version
wine-4.15

[Attachment] Log contains errors like
0009:err:msi:MSI_OpenDatabaseW unknown flag 00000000
0009:err:msi:msi_apply_patch_package failed to open patch collection ...

[SHA1]
en_office_enterprise_2007_dvd_vl_x12-19574.iso
83c9b8cb7f4799737a8f8494041f0a9e0ad7cc92

office2007sp3-kb2526086-fullfile-en-us.exe
69a5828265249c9de7f3503102003fe006dc162d

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #1 from Allan  ---
Created attachment 65199
  --> https://bugs.winehq.org/attachment.cgi?id=65199
Office installer logs (C:\users\allan\Temp*.log)

The only error that caught my attention in Office logs is:

MarshalPatchProperties_PublishP:  ERROR:
OcaSetProperty(PublishPatchARPMachine): property name should be no longer than
20 chars

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #2 from Hans Leidekker  ---
(In reply to Allan from comment #0)
> Created attachment 65198 [details]
> WINEDEBUG=+msxml wine office2007sp3-kb2526086-fullfile-en-us.exe &> sp3.log

Can you run this again with +msi,+msidb flags and attach the log here?

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #3 from Allan  ---
(In reply to Hans Leidekker from comment #2)
> (In reply to Allan from comment #0)
> > Created attachment 65198 [details]
> > WINEDEBUG=+msxml wine office2007sp3-kb2526086-fullfile-en-us.exe &> sp3.log
>
> Can you run this again with +msi,+msidb flags and attach the log here?

Sure. The log is large (>900MB), I compressed to 32MB here:
https://drive.google.com/file/d/1L_Tn7O6NvXJbEzNcXz8uUuiU_P0I_fvN/view?usp=s...

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #4 from Allan  ---
wine-4.0 (Debian 4.0-2) installs SP3 as expected

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #5 from Hans Leidekker  ---
I don't see this in current git Wine with the standard version of Office 2007.

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #5 from Hans Leidekker  ---
I don't see this in current git Wine with the standard version of Office 2007.

--- Comment #6 from Allan  ---
I was able to downgrade wine and track what version introduced this issue. From
4.9 to 4.10

4.15: FAIL
4.14: FAIL
4.13: FAIL
4.12: FAIL
4.11: FAIL
4.10: FAIL
4.9: SUCCESS
4.8: SUCCESS

I'm using Arch Linux (https://archive.archlinux.org/packages/w/wine/)

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #7 from Hans Leidekker  ---
(In reply to Allan from comment #6)
> I was able to downgrade wine and track what version introduced this issue.
> From 4.9 to 4.10
>
> 4.15: FAIL
> 4.14: FAIL
> 4.13: FAIL
> 4.12: FAIL
> 4.11: FAIL
> 4.10: FAIL
> 4.9: SUCCESS
> 4.8: SUCCESS
>
> I'm using Arch Linux (https://archive.archlinux.org/packages/w/wine/)

Can you perform a regression test to find the commit between 4.9 and 4.10 that
broke it? See https://wiki.winehq.org/Regression_Testing

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #8 from Allan  ---
(In reply to Hans Leidekker from comment #7)
> (In reply to Allan from comment #6)
> > I was able to downgrade wine and track what version introduced this issue.
> > From 4.9 to 4.10
> >
> > 4.15: FAIL
> > 4.14: FAIL
> > 4.13: FAIL
> > 4.12: FAIL
> > 4.11: FAIL
> > 4.10: FAIL
> > 4.9: SUCCESS
> > 4.8: SUCCESS
> >
> > I'm using Arch Linux (https://archive.archlinux.org/packages/w/wine/)
>
> Can you perform a regression test to find the commit between 4.9 and 4.10
> that broke it? See https://wiki.winehq.org/Regression_Testing

I have a basic knowledge of git, c, compiling in Linux... So, sorry if I delay
to reply. I'm very interested to improve in these things and thanks for
pointing out the Regression Testing.

I made a big mistake of judge wine-4.10 as bisect bad and wine-4.9 as good.
Made the bisect till the end just to see that 4.10 runs as expected. LOL

The current master fails to install SP3, returning
004b:err:msi:msi_apply_patch_package failed to open patch collection

I'll try to track down the real git tag that is failing, and then do the
bisect.

Question: there's some trick to accelerate build time? I'm currently building
win64, then win32 and the whole proccess takes more than 1 hour with my laptop.

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #9 from Allan  ---
Created attachment 65210
  --> https://bugs.winehq.org/attachment.cgi?id=65210
My script to build wine, based on PKGBUILD from Arch Linux wine package

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #10 from Hans Leidekker  ---
(In reply to Allan from comment #8)
> I made a big mistake of judge wine-4.10 as bisect bad and wine-4.9 as good.
> Made the bisect till the end just to see that 4.10 runs as expected. LOL
>
> The current master fails to install SP3, returning
> 004b:err:msi:msi_apply_patch_package failed to open patch collection
>
> I'll try to track down the real git tag that is failing, and then do the
> bisect.

It could be a build issue. Can you attach your config.log here?
> Question: there's some trick to accelerate build time? I'm currently
> building win64, then win32 and the whole proccess takes more than 1 hour
> with my laptop.

You could cut that in half by only building 32-bit Wine. Office 2007 is a
32-bit application.

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #11 from Allan  ---
Created attachment 65214
  --> https://bugs.winehq.org/attachment.cgi?id=65214
(4.15) wine-32-build/config.log

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

Allan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #12 from Allan  ---
git bisect between wine-4.10 and wine-4.11:
7cd3c9f0734d217e1d08319e72a9df91fe2ef882 is the first bad commit

commit 7cd3c9f0734d217e1d08319e72a9df91fe2ef882                                 
Author: Alexandre Julliard                                 
Date:   Thu Jun 13 08:42:35 2019 +0200

msi: Build with msvcrt.

https://source.winehq.org/git/wine.git/commit/7cd3c9f0734d217e1d08319e72a9df...

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

Allan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |7cd3c9f0734d217e1d08319e72a
                   |                            |9df91fe2ef882

[Bug 47724] Office 2007 SP3 not installing ( msi_apply_patch_package failed to open patch collection)

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #13 from Allan  ---
It seems that this issue is reproducible with some dotnet installer.
See #47663, #47740, and https://github.com/Winetricks/winetricks/issues/1273

[Bug 47724] Office 2007 SP3 not installing

https://bugs.winehq.org/show_bug.cgi?id=47724

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Office 2007 SP3 not         |Office 2007 SP3 not
                   |installing                  |installing
                   |(msi_apply_patch_package    |
                   |failed to open patch        |
                   |collection)                 |

--- Comment #14 from Zebediah Figura  ---
(In reply to Allan from comment #13)
> It seems that this issue is reproducible with some dotnet installer.
> See #47663, #47740, and https://github.com/Winetricks/winetricks/issues/1273

I wouldn't assert those are the same bugs. Any given message in the terminal
doesn't necessarily imply the cause of a bug.

[Bug 47724] Office 2007 SP3 not installing

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #15 from Allan  ---
(In reply to Zebediah Figura from comment #14)
> (In reply to Allan from comment #13)
> > It seems that this issue is reproducible with some dotnet installer.
> > See #47663, #47740, and https://github.com/Winetricks/winetricks/issues/1273
>
> I wouldn't assert those are the same bugs. Any given message in the terminal
> doesn't necessarily imply the cause of a bug.

Of course, and that's why I used "It seems" instead of "WITHOUT DOUBTS" and
"FOR SURE". To me, as layman, it's high probable to be the same cause.

Indeed, this is what I get running "winetricks dotnet35sp1" from clear
wine-4.15
002f:err:msi:MSI_OpenDatabaseW unknown flag 00000000
002f:err:msi:msi_apply_patch_package failed to open patch collection
L"y:\31167f154c467316cd32\wcu\dotNetFramework\dotnetfx20\ASPNET.msp"
002f:err:msi:ITERATE_Actions Execution halted, action
L"CA_ScheduleCacheGACAssembly.3643236F_FC70_11D3_A536_0090278A1BB8" returned
1627

wine-4.10-85-g5182813ae0 (env WINE=/home/allan/git/wine/wine-32-build/wine sh
winetricks dotnet35sp1):
.NET Framework 3.5 SP1 has been installed successfully.

The next time you have something to say in bug reports, it'll be more useful if
you have something to contribute to, instead of "I wouldn't assert those" and
do nothing to help.

[Bug 47724] .NET Framework 3.5 SP1 not installing

https://bugs.winehq.org/show_bug.cgi?id=47724

Allan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Office 2007 SP3 not         |.NET Framework 3.5 SP1 not
                   |installing                  |installing

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

Jens Reyer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #16 from Allan  ---
Adding "--without-mingw" to "configure" fixes this issue.

1) How this can be handled to package maintainers? (i.e. Debian, Arch Linux)
2) So, this is likely a mingw-w64 issue. What's the best way to report or track
the root of this issue? Any expert welcome...

Thanks

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #17 from Allan  ---
(In reply to Allan from comment #16)
> Adding "--without-mingw" to "configure" fixes this issue.

Well, my assumption is wrong. Building wine32 "--without-mingw" works for me in
Arch Linux. But that flag is already in the building rules from Debian
package[1], and I just tested here with wine-4.16 and the result was the same
as before. Unsuccessful install of dotnet35sp1.

Sorry about my precipitated conclusion. I think that this bug will cause some
problems in the future if it wasn't properly verified by Wine experts/devs.

[1] https://salsa.debian.org/wine-team/wine/blob/master/debian/rules

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #18 from Allan  ---
Sorry for all the mess about this bug report.

When I think that something was on the way, I found another thing that doesn't
make sense. My original report was about wine not installing Office SP3. Later,
I find out that dotnet35sp1 installer triggers the same issue. And now I find
that Debian package wine-4.0.2 installs Office 2007 SP3, but fails dotnet35sp1
with "MSI_OpenDatabaseW unknown flag (nil)".

Summary:

[Git]
I'm building from Arch Linux, using these parameters, based on PKGBUILD from
Arch Linux package[1]:

export CFLAGS="${CFLAGS/-fno-plt/}"
export LDFLAGS="${LDFLAGS/,-z,-now/}"
sed 's|OpenCL/opencl.h|CL/opencl.h|g' -i configure*
rm -rf wine-32-build
mkdir wine-32-build
export PKG_CONFIG_PATH="/usr/lib32/pkgconfig"
cd wine-32-build
CC="ccache gcc" CFLAGS="-g -O0" ../configure --verbose --disable-tests \
        --prefix=/usr \
        --with-x \
        --with-gstreamer \
        --libdir=/usr/lib32
make

tags:
wine-4.10 = good
wine-4.11 = bad

git bisect:
7cd3c9f0734d217e1d08319e72a9df91fe2ef882 is the first bad commit

I made the git bisect testing only Office 2007 SP3 installer.

Appending --without-mingw to configure, I was able to install both Office 2007
SP3 and dotnet35sp1 (i.e. wine-4.15-40-g363b8809f3)

[Arch Linux]
Downgrade package from Arch Linux archive. Tested with both (dotnet35sp1 and
Office 2007 SP3)

4.15: FAIL
4.14: FAIL
4.13: FAIL
4.12: FAIL
4.11: FAIL
4.10: FAIL
4.9: SUCCESS
4.8: SUCCESS

[Debian]
wine-4.0.2: Success with Office 2007 SP3. Fails dotnet35sp1 (Just "discovered"
today)
wine-development-4.11-1: Fails dotnet35sp1
wine-development-4.16-1: Fails dotnet35sp1

--
[1]
https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packa...

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

Alexander Shpilkin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

Kevin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from Kevin  ---
*** Bug 47663 has been marked as a duplicate of this bug. ***

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #20 from Kevin  ---
Maybe add some to name of bug like "MSI_OpenDatabaseW" error for better search?
Same error triggers in .Net 2.0 x64 for example installing in clean wine
4.15-4.18 at least (Archlinux wine and wine-staging)

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #21 from Kevin  ---
Created attachment 65520
  --> https://bugs.winehq.org/attachment.cgi?id=65520
Wine x64 WinXP installing .Net 2.0 error

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #22 from Hans Leidekker  ---
This might be fixed by cce9a5f124ae6d3fffcc7772cab6523f09a1e3d1, please test.

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

Felix Yan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #23 from Jens Reyer  ---
I can confirm that "winetricks dotnet35sp1" failed with 4.19, but succeeded
with cce9a5f124ae6d3fffcc7772cab6523f09a1e3d1.

This was also reported by the submitter in https://bugs.debian.org/940192,
which I just closed.

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |cce9a5f124ae6d3fffcc7772cab
                   |                            |6523f09a1e3d1
         Resolution|---                         |FIXED

--- Comment #24 from Hans Leidekker  ---
Reported fixed by cce9a5f124ae6d3fffcc7772cab6523f09a1e3d1.

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

--- Comment #25 from Austin English  ---
(In reply to Hans Leidekker from comment #22)
> This might be fixed by cce9a5f124ae6d3fffcc7772cab6523f09a1e3d1, please test.

I'm a bit late, but yes, this fixes it for me with mingw and without mingw.

[Bug 47724] .NET Framework 3.5 SP1 not installing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #26 from Alexandre Julliard  ---
Closing bugs fixed in 4.21.

[Bug 47724] .NET Framework 2.0 SP1/SP2, 3.0 SP1, 3.5 installers fail with 'err:msi:MSI_OpenDatabaseW unknown flag (nil)' ... 'err:msi:msi_apply_patch_package failed' when Wine was built with GCC 9.x/10.x or MinGW

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47724

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://web.archive.org/web
                   |                            |/20091027141450/http://down
                   |                            |load.microsoft.com/download
                   |                            |/6/0/f/60fc5854-3cb8-4892-b
                   |                            |6db-bd4f42510f28/dotnetfx35
                   |                            |.exe
                 CC|                            |[e-mail]
           Keywords|                            |dotnet
            Summary|.NET Framework 3.5 SP1 not  |.NET Framework 2.0 SP1/SP2,
                   |installing                  |3.0 SP1, 3.5 installers
                   |                            |fail with
                   |                            |'err:msi:MSI_OpenDatabaseW
                   |                            |unknown flag (nil)' ...
                   |                            |'err:msi:msi_apply_patch_pa
                   |                            |ckage failed' when Wine was
                   |                            |built with GCC 9.x/10.x or
                   |                            |MinGW

--- Comment #27 from Anastasius Focht  ---
Hello folks,

for documentation: It breaks *any* Wine version built with modern GCC/MinGW
toolchains. Just came across this again while testing .NET Frameworks
installation for old Wine 2.x and 3.x releases.

--- snip ---
err:msi:msi_apply_patch_package failed to open patch collection
L"y:\3490b4bd8a5ed6aec4b87623ff\wcu\dotNetFramework\dotnetfx20\ASPNET.msp"
err:msi:ITERATE_Actions Execution halted, action
L"CA_ScheduleCacheGACAssembly.3643236F_FC70_11D3_A536_0090278A1BB8" returned
1627
--- snip ---

Affected .NET Framework installers:

* .NET Framework 2.0 SP1
* .NET Framework 2.0 SP2
* .NET Framework 3.0 SP1
* .NET Framework 3.5
* .NET Framework 3.5 SP1 (3.5 is a prerequisite)

I'm refining the summary to get better search results in Wine Bugzilla and
Internet search engines. This is a major pain for bisecting of older Wine
releases for .NET Framework 2.x SPx and 3.x installer/winetricks issues. It
requires a back-port of the patch to *any* old Wine version.

Regards