[Bug 44580] New: Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

Bug ID: 44580
           Summary: Outlook 2007 cannot read MSG files anymore
           Product: Wine
           Version: 3.2
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

I use wine to drive Outlook 2007 to produce automatically printed PDF files
from MSG files (created by Outlook 2007 under Windows) in a batch script under
linux.

For that I use cupspdf as default printer and call Outlook with the '/p' switch
and the respective file as the second argument.

I have implemented this script well before the 3.0 release. I think it is
running since more than one year. Initially I ran into the issue that Outlook
could not open an MSG file and spit out 'Cannot start Microsoft Office
Outlook'.

So currently I am working around that issue by firstly trying to open the MSG.
If above error is given, I convert the MSG file to an EML file via

http://search.cpan.org/dist/Email-Outlook-Message/

and then reconvert it back to MSG via:

https://labs.rebex.net/mail-converter

Usually, Outlook 2007 can then start and open the file correctly. So there is
already something not in order in view of parsing MSG files created by Outlook
itself.

This was before the update to wine 3.2

Since wine 3.2, no MSG file can be opened. Outlook always drops above error
message regardless if the MSG had been converted or not.

For now I have reverted back to wine 3.1 and everything works as it should.
However, something had been introduced, what breaks Outlook 2007.

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |regression

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #1 from marlemion  ---
I just tested this on wine 3.3 and it seems to be resolved!

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #2 from marlemion  ---
Ah, sorry, I somehow did something wrong when updating to wine 3.3. So, the
problem is still present in wine 3.3!

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #3 from marlemion  ---
Ok, I have bisected this issue down to this commit:

https://github.com/wine-mirror/wine/compare/b21eb6733fab6d777886a8e0271cecb8...

Before this commit, everthing works fine, after it, Outlook is broken.

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #4 from marlemion  ---
Still present in wine 3.4

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #5 from Jeff Zaroyko  ---
could you please try reverting the patch that you identified, then recompile to
confirm? https://wiki.winehq.org/Regression_Testing#Reverting_the_patch

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #6 from marlemion  ---
Hi Jeff,

thanks for your answer. Unfortunately, I am not a git guru. So I have cloned
wine on github and cloned my repository to a local computer. There, I issued
the following command:

git revert -n 5d10abde503fc4a952c114c658fed74f97bff090

error: could not revert 5d10abde50... comctl32: Introduce Button control.
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>

Could you please help me how to proceed further?

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #7 from Nikolay Sivov  ---
There's a test patch at https://bugs.winehq.org/show_bug.cgi?id=44677#c14 that
revert to old Button control, please try that one.

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #8 from marlemion  ---
I have checked out the wine-mirror repository, cloned it locally, applied this
patch:

https://bugs.winehq.org/attachment.cgi?id=60816&action=diff

and built it as I have built all the other wine versions when bisecting (using
arch's wine-git PKGBUILD). I get this error:

make[1]: Entering directory
'/home/PKGBUILD/wine-git/src/wine-git-32-build/dlls/winex11.drv'
gcc -m32 -c -o vulkan.o ../../../wine-git/dlls/winex11.drv/vulkan.c -I.
-I../../../wine-git/dlls/winex11.drv \
  -I../../include -I../../../wine-git/include -D__WINESRC__ -D_REENTRANT -fPIC
-Wall -pipe \
  -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body
-Wignored-qualifiers \
  -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits
-Wunused-but-set-parameter -Wvla \
  -Wwrite-strings -Wpointer-arith -Wlogical-op -fno-omit-frame-pointer
-D_FORTIFY_SOURCE=2 -march=x86-64 -mtune=generic -O2 -pipe
-fstack-protector-strong -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0
In file included from ../../../wine-git/dlls/winex11.drv/vulkan.c:29:0:
../../../wine-git/dlls/winex11.drv/vulkan.c: In function 'get_vulkan_driver':
../../../wine-git/include/wine/debug.h:358:56: error: '__wine_dbch___default'
undeclared (first use in this function)
 #define WINE_ERR                   __WINE_DPRINTF(_ERR,__wine_dbch___default)
                                                        ^
../../../wine-git/include/wine/debug.h:75:43: note: in definition of macro
'__WINE_GET_DEBUGGING_ERR'
 #define __WINE_GET_DEBUGGING_ERR(dbch)  ((dbch)->flags & (1 <<
__WINE_DBCL_ERR))
                                           ^~~~
../../../wine-git/include/wine/debug.h:85:11: note: in expansion of macro
'__WINE_GET_DEBUGGING'
   do { if(__WINE_GET_DEBUGGING(dbcl,(dbch))) { \
           ^~~~~~~~~~~~~~~~~~~~
../../../wine-git/include/wine/debug.h:358:36: note: in expansion of macro
'__WINE_DPRINTF'
 #define WINE_ERR                   __WINE_DPRINTF(_ERR,__wine_dbch___default)
                                    ^~~~~~~~~~~~~~
../../../wine-git/include/wine/debug.h:398:36: note: in expansion of macro
'WINE_ERR'
 #define ERR                        WINE_ERR
                                    ^~~~~~~~
../../../wine-git/dlls/winex11.drv/vulkan.c:536:5: note: in expansion of macro
'ERR'
     ERR("Wine was built without Vulkan support.\n");
     ^~~
../../../wine-git/include/wine/debug.h:358:56: note: each undeclared identifier
is reported only once for each function it appears in
 #define WINE_ERR                   __WINE_DPRINTF(_ERR,__wine_dbch___default)
                                                        ^
../../../wine-git/include/wine/debug.h:75:43: note: in definition of macro
'__WINE_GET_DEBUGGING_ERR'
 #define __WINE_GET_DEBUGGING_ERR(dbch)  ((dbch)->flags & (1 <<
__WINE_DBCL_ERR))
                                           ^~~~
../../../wine-git/include/wine/debug.h:85:11: note: in expansion of macro
'__WINE_GET_DEBUGGING'
   do { if(__WINE_GET_DEBUGGING(dbcl,(dbch))) { \
           ^~~~~~~~~~~~~~~~~~~~
../../../wine-git/include/wine/debug.h:358:36: note: in expansion of macro
'__WINE_DPRINTF'
 #define WINE_ERR                   __WINE_DPRINTF(_ERR,__wine_dbch___default)
                                    ^~~~~~~~~~~~~~
../../../wine-git/include/wine/debug.h:398:36: note: in expansion of macro
'WINE_ERR'
 #define ERR                        WINE_ERR
                                    ^~~~~~~~
../../../wine-git/dlls/winex11.drv/vulkan.c:536:5: note: in expansion of macro
'ERR'
     ERR("Wine was built without Vulkan support.\n");
     ^~~
make[1]: *** [Makefile:538: vulkan.o] Error 1
make[1]: Leaving directory
'/home/PKGBUILD/wine-git/src/wine-git-32-build/dlls/winex11.drv'
make: *** [Makefile:8648: dlls/winex11.drv] Error 2

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #9 from Gijs Vermeulen  ---
(In reply to marlemion from comment #8)
Try applying this patch as well: https://source.winehq.org/patches/data/143658

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #10 from marlemion  ---
Thanks for your replies. With both patches attached, I can confirm that Outlook
is working again!

To be sure what we are talking about, you can find my repository including the
two patches here:

https://github.com/marlemion/wine

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #11 from marlemion  ---
applied, not attached...

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #12 from Nikolay Sivov  ---
(In reply to marlemion from comment #10)
> Thanks for your replies. With both patches attached, I can confirm that
> Outlook is working again!

Ok, that's good. Now please attach +win,+actctx,+msg,+button,+loaddll log with
button patch reverted.

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #13 from marlemion  ---
Created attachment 60823
  --> https://bugs.winehq.org/attachment.cgi?id=60823
Output of opening outlook with wine 3.4 (not patch applied)

I ran the command again with wine 3.4 as supplied by arch to speed up the
response. Please find the respective output with
+win,+actctx,+msg,+button,+loaddll enabled below.

If it is required I could also test current master without patches, but I would
have to recompile for that.

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #14 from Nikolay Sivov  ---
Please retest with Wine 3.5.

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #15 from Nikolay Sivov  ---
And if it still doesn't work with 3.5, I'll need step by step instructions on
how to trigger this.

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #16 from marlemion  ---
Sorry for my late answer (easter holidays). I can confirm that with wine 3.5
the regression went away and Outlook is opening MSG files again properly.

Many thanks for your patience and effort!

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

marlemion  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #17 from marlemion  ---
Marking this as fixed.

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

--- Comment #18 from Nikolay Sivov  ---
Great, thanks for testing.

[Bug 44580] Outlook 2007 cannot read MSG files anymore

https://bugs.winehq.org/show_bug.cgi?id=44580

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Alexandre Julliard  ---
Closing bugs fixed in 3.6.