[Bug 32718] New: Crash on call to SHELL32.dll.709 (SHGetSetFolderCustomSettings)

http://bugs.winehq.org/show_bug.cgi?id=32718

Bug #: 32718
           Summary: Crash on call to SHELL32.dll.709
                    (SHGetSetFolderCustomSettings)
           Product: Wine
           Version: 1.5.21
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: shell32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 43171
  --> http://bugs.winehq.org/attachment.cgi?id=43171
Terminal output

The XLN Online Installer, our simple package manager, crashes when it tries to
set the folder icon for the start menu folder upon installing / updating
itself.

I ran the "XLN Online Installer.exe" in
http://xlnaudio.s3.amazonaws.com/products/XLN%20Online%20Installer/xln-onlin...
with wine64, set to emulate windows 7, on gentoo.

The culprit code and terminal output is attached.

[Bug 32718] Crash on call to SHELL32.dll.709 (SHGetSetFolderCustomSettings)

http://bugs.winehq.org/show_bug.cgi?id=32718

--- Comment #1 from Kim  2013-01-15 06:48:27 CST ---
Created attachment 43172
  --> http://bugs.winehq.org/attachment.cgi?id=43172
Culprit code

[Bug 32718] Crash on call to SHELL32.dll.709 (SHGetSetFolderCustomSettings)

http://bugs.winehq.org/show_bug.cgi?id=32718

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, testcase

[Bug 32718] Crash on call to SHELL32.dll.709 (SHGetSetFolderCustomSettings)

http://bugs.winehq.org/show_bug.cgi?id=32718

--- Comment #2 from Austin English  2013-01-15 16:25:28 CST ---
Created attachment 43185
  --> http://bugs.winehq.org/attachment.cgi?id=43185
stub

Try this.

[Bug 32718] Crash on call to SHELL32.dll.709 (SHGetSetFolderCustomSettings)

http://bugs.winehq.org/show_bug.cgi?id=32718

--- Comment #3 from Kim  2013-01-17 03:54:43 CST ---
With a small addition in that it needs its explicit ordinal 709 in the
shell32.spec file, that worked a treat. I found a list of api calls that need
explicit ordinals at
http://www.geoffchappell.com/studies/windows/shell/shell32/history/ords500.h...
which might be useful.

Thanks!

[Bug 32718] Crash on call to SHELL32.dll.709 (SHGetSetFolderCustomSettings)

http://bugs.winehq.org/show_bug.cgi?id=32718

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |605f2f941e52e2f641ef38eabc0
                   |                            |465add4ac6a11
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Austin English  2013-01-18 16:58:41 CST ---
http://source.winehq.org/git/wine.git/commitdiff/605f2f941e52e2f641ef38eabc0...

[Bug 32718] Crash on call to SHELL32.dll.709 (SHGetSetFolderCustomSettings)

http://bugs.winehq.org/show_bug.cgi?id=32718

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  2013-02-01 04:56:20 CST ---
Closing bugs fixed in 1.5.23.