[Bug 25728] New: UFO Extraterrestrials Gold crashes at start if wine's builtin dsound and dmusic are being used
http://bugs.winehq.org/show_bug.cgi?id=25728
Summary: UFO Extraterrestrials Gold crashes at start if wine's builtin dsound and dmusic are being used Product: Wine Version: 1.3.11 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-dsound AssignedTo: wine-bugs@winehq.org ReportedBy: mooroon2@mail.ru
Created an attachment (id=32774) --> (http://bugs.winehq.org/attachment.cgi?id=32774) WINEDEBUG="+all,err+all,warn+all,trace-all" output
Game crashes at start with "Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0050403c)".
Installing Direct Music and Direct Sound using winetricks fixes the issue: game starts up normally and have no problems playing music or sound effects.
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #1 from Alexey Loukianov mooroon2@mail.ru 2011-01-08 08:09:38 CST --- Created an attachment (id=32775) --> (http://bugs.winehq.org/attachment.cgi?id=32775) WINEDEBUG="+all,err+all,warn+all,trace+all" output, bzipped
http://bugs.winehq.org/show_bug.cgi?id=25728
Alexey Loukianov mooroon2@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mooroon2@mail.ru
http://bugs.winehq.org/show_bug.cgi?id=25728
Alexey Loukianov mooroon2@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|UFO Extraterrestrials Gold |UFO: Extraterrestrials Gold |crashes at start if wine's |- crash at start caused by |builtin dsound and dmusic |wine's built-in |are being used |dsound/directmusic
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #2 from Alexey Loukianov mooroon2@mail.ru 2011-09-11 01:03:23 CDT --- Still problem up till the commit 901af51ea32f2d192a598808abab2d1b6a940773. Can't test with later Wine versions (1.3.25+) as this commit renders mentioned native dsound/dmusic workaround useless.
http://bugs.winehq.org/show_bug.cgi?id=25728
Andrew Eikum aeikum@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |aeikum@codeweavers.com
--- Comment #3 from Andrew Eikum aeikum@codeweavers.com 2011-09-29 14:28:03 CDT --- Now that the dsound rework is in, can you attach a log with the channels requested at http://wiki.winehq.org/Sound? Don't bother trying with the native DLLs, it should work with just Wine's dsound.
Also would you object to marking Bug 28340 as a duplicate of this one? The bug seems to be that Wine's dsound causes a crash at launch for this application.
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #4 from Alexey Loukianov mooroon2@mail.ru 2011-09-29 16:55:54 CDT --- Andrew, I track wine's git almost daily so I'm aware that currently there are a lot of changes happening to dsound thanks to your efforts. Bug #28430 is slightly different to this one: this one about UFO:ET crash with Wine's dsound implementation, and #28430 is about regression introduced with your recent work that it is no longer possible to use MS native dsound/directmusic to workaround the crash at startup caused by Wine's built-in dsound/dmusic implementation. Thus they are not dupes obviously but are closely related and I think that #28430 would become very low priority (if not the obsolete) as soon as you would re-implement dsound/dmusic to a state when UFO:ET won't be crashing with.
As for requested logs - I'm in process of compiling todays git a.t.m., would test and post logs here soon.
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #5 from Alexey Loukianov mooroon2@mail.ru 2011-09-29 21:10:44 CDT --- Created attachment 36608 --> http://bugs.winehq.org/attachment.cgi?id=36608 WINEDEBUG="+tid,+winmm,+mmdevapi,+midi,+dsound,+oss,+alsa" UFO_ET.exe crash logs.
Attaching logs as requested. Recorded with fresh wineprefix + winetricks nocrashdialog d3dx9_26.
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #6 from Alexey Loukianov mooroon2@mail.ru 2011-10-14 08:45:05 CDT --- Had some free time today and so I had tried to look at the issue under OllyDBG/winedbg. As the game copy I have is a Steam release it's pretty hard to analyze such executables under debugger. So I tried to fool the dog: downloaded latest patch for original version of UFO:ET from Chaos Concept official site and got UFO_ET.exe from there - I had heard that they had removed copy protection in latest patch for original version so I was hoping it would easier to debug the crash in case it would behave the same UFO:ET Gold behaved. Unfortunately it's not the case.
Game launches up and works pretty good when using data files from Steam release of UFO:ET Gold + UFO_ET.exe from latest official patch, including native dsound/dmusic workaround working with Wine version prior to 1.3.25. But the trouble is there's no crash at all when running it with builtin dsound/dmusic. Game simply starts without sound/music and that's pretty much all the story :-(. I had sent a mail to the Chaos Concept support in hopes that they would provide me with DRM-freem UFO_ET.exe from "Gold" version which would crash just like Steam version does and thus I would finally able to lay my hand over it under debugger. Let's wait and hope.
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #7 from Alexey Loukianov mooroon2@mail.ru 2012-04-17 04:35:54 CDT --- Created attachment 39831 --> http://bugs.winehq.org/attachment.cgi?id=39831 WINEDEBUG="-all,err+all,+tid,+loaddll,+fps,+winmm,+mmdevapi,+midi,+dsound,+oss,+alsa" UFO_ET.exe crash logs with Wine 1.5.2.
Here are freshly-captured logs of the crash with Wine 1.5.2.
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #8 from Andrew Eikum aeikum@codeweavers.com 2012-04-17 09:38:45 CDT --- Thanks Alexey. Unfortunately, nothing stands out as wrong in that log.
What would be most interesting is one or both of these, preferably in a clean 1.5.2 WINEPREFIX if it's not too much work:
Built-in everything, with the following debug channels: +tid,+mmdevapi,+winmm,+driver,+midi,+dsound,+dmusic,+mci,+oss,+alsa,+coreaudio,+dmime,+dmloader,+dmfile,+dmfileraw,+dmdump,+dmband,+dmusic,+dmcompos,+dmscript,+dmstyle,+dmsynth,+dmusic32,+dswave
or
Native directmusic as installed by winetricks, with the same debug channels.
The first will help us repair Wine's dmusic implementation. The second will help us get Native dmusic working again (which is Bug 28340).
I'm not sure how native dsound might be involved here...
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #9 from Alexey Loukianov mooroon2@mail.ru 2012-04-17 09:47:44 CDT --- (In reply to comment #8)
What would be most interesting is one or both of these, preferably in a clean 1.5.2 WINEPREFIX if it's not too much work:
No problems, would do it in about an hour. Today happened to be a day I spend on activities related to Wine's APPDB and Bugzilla, so it won't hurt to spend a bit more time recompiling Wine and capturing traces.
http://bugs.winehq.org/show_bug.cgi?id=25728
Alexey Loukianov mooroon2@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #39831|0 |1 is obsolete| |
--- Comment #10 from Alexey Loukianov mooroon2@mail.ru 2012-04-17 10:37:17 CDT --- Created attachment 39838 --> http://bugs.winehq.org/attachment.cgi?id=39838 Wine 1.5.2 + UFO_ET.EXE crash logs with additional debug channels (builtin dlls being used)
WINEDEBUG="+tid,+loaddll,+fps,+mmdevapi,+winmm,+driver,+midi,+dsound,+dmusic,+mci,+oss,+alsa,+coreaudio,+dmime,+dmloader,+dmfile,+dmfileraw,+dmdump,+dmband,+dmusic,+dmcompos,+dmscript,+dmstyle,+dmsynth,+dmusic32,+dswave" WINE 1.5.2
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #11 from Alexey Loukianov mooroon2@mail.ru 2012-04-17 10:38:17 CDT --- Created attachment 39839 --> http://bugs.winehq.org/attachment.cgi?id=39839 Wine 1.5.2 + UFO_ET.EXE crash logs with additional debug channels (native directmusic)
WINEDEBUG="+tid,+loaddll,+fps,+mmdevapi,+winmm,+driver,+midi,+dsound,+dmusic,+mci,+oss,+alsa,+coreaudio,+dmime,+dmloader,+dmfile,+dmfileraw,+dmdump,+dmband,+dmusic,+dmcompos,+dmscript,+dmstyle,+dmsynth,+dmusic32,+dswave"
WINE 1.5.2
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #12 from Alexey Loukianov mooroon2@mail.ru 2012-04-17 10:40:49 CDT --- Andrew, I had attached the requested traces to this bug. As far as I can see, there's still nothing suspicious in logs IMO which can be easily identified as a "bug trigger" :-(.
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #13 from Alexey Loukianov mooroon2@mail.ru 2012-04-17 10:50:28 CDT --- Well, spoke too fast. There's a query for an unsupported COM interface 2a8af120-e9de-4132-aaa5-4bdda5f325b8 in logs. Googling for it leads mostly to other sound-related bugs in Wine.
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #14 from Andrew Eikum aeikum@codeweavers.com 2012-04-17 11:21:27 CDT --- Created attachment 39840 --> http://bugs.winehq.org/attachment.cgi?id=39840 dmime: Don't try to create a standard audio path if the client didn't ask for one
I found the problem with builtin. I've attached a patch here. It should get past that crash, but we might run into another crash later on. Give it a try, anyway.
(In reply to comment #13)
Well, spoke too fast. There's a query for an unsupported COM interface 2a8af120-e9de-4132-aaa5-4bdda5f325b8 in logs. Googling for it leads mostly to other sound-related bugs in Wine.
Yeah. What confuses me is how it ever worked. We've never implemented that interface as far as I'm aware.
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #15 from Alexey Loukianov mooroon2@mail.ru 2012-04-17 12:12:27 CDT --- Created attachment 39841 --> http://bugs.winehq.org/attachment.cgi?id=39841 WINE 1.5.2 + UFO_ET.EXE debug traces with dmime patch applied.
Well, it had got better, but still far from perfect.
With patch in place the game is able to start up and show its main menu, but neither in-game sound not music are working - soundcard outputs remain silent. Trying to start up a new game succeeds with "geoscape" mode working perfectly, but as soon as the game tries to switch into "tactical combat" mode it "softly" crashes to desktop displaying a messagebox about the internal error. It also provides me with an "error details" file which I'm asked to send to game developers, but there's no relevant info inside that file except for next few lines:
... [00:00:15.055] Loading mission terrain: levels\scififactory level:level_8 file: scififactory [00:00:24.673] CData::setLoopPoints::Unsuccessful. [00:00:24.673] Int values:1 Float values:1 String values:3 Bool values:1 Object values:0 List values:1 Null values:2
[00:00:24.915] scripts done [00:00:24.992] Waiting for sounds to stop playing [00:00:25.534] Done waiting for messages. [00:00:25.534] Switching console to window output [00:00:25.866] graphics done [00:00:25.867] input done [00:00:25.867] event done [00:00:25.869] Exiting with error ...
I had tried to start up the game under Wine 1.3.24 + native DM/DS to check if the game itself is not corrupt. Apparently it is not - I was able to load the same save and successfully got into "tactical combat" mode.
What shell we do next? This bug is kind-a fixed with your patch, but the sound in game is still non-functional and the game itself isn't playable also. Should we close this bug FIXED and open up a two new about "No in-game sounds/music" and "Game fails to enter into tactical combat stage" or it'd be more convenient to track the progress within this report until the game would finally be working well having no sound-related problems?
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #16 from Andrew Eikum aeikum@codeweavers.com 2012-04-17 12:53:32 CDT --- No, let's stick with this bug until the crashes are fixed. We can see where we're at after that.
Unfortunately that log doesn't show the crash. How about another log with the same channels and also +seh,+msgbox,+dialog. Just get to the crash as quickly as possible and post the log.
By the way, does the dialog look like a standard Wine message box, or is it more application-specific?
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #17 from Alexey Loukianov mooroon2@mail.ru 2012-04-17 13:38:11 CDT --- (In reply to comment #16)
Unfortunately that log doesn't show the crash. How about another log with the same channels and also +seh,+msgbox,+dialog. Just get to the crash as quickly as possible and post the log.
The CTD that happen is not a hard crash like unhandled seh or some fatal condition (SIGSEGV, e.t.c.), it is an graceful application-initialized shutdown due to some internal error checking mechanism reporting that things got wrong. Looks like an app detects some kind of internal error condition, logs some details to a "crash report txt file" I had mentioned earlier and terminates itself showing a messagebox with an error message.
So, to be more clear: the crash this bug was about initially is no more, app execution flow manages to pass by the problematic place and get into app's main menu. There's no sound and music output though, and the game terminates itself with an error message as soon as it finishes loading a savegame which. With Wine 1.3.24 + native DM/DS there are no problem loading this particular save, so chances are pretty high that an app terminates itself due some factor that is a consequence to a non-working sound and music.
BTW, is your dmime patch backwards compatible with, say, Wine 1.3.25? It might be worth checking if an app would work with that version + fix and compare run traces with 1.3.24 + native DM/DS.
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #18 from Andrew Eikum aeikum@codeweavers.com 2012-04-17 14:33:32 CDT --- (In reply to comment #17)
(In reply to comment #16)
Unfortunately that log doesn't show the crash. How about another log with the same channels and also +seh,+msgbox,+dialog. Just get to the crash as quickly as possible and post the log.
The CTD that happen is not a hard crash like unhandled seh or some fatal condition (SIGSEGV, e.t.c.), it is an graceful application-initialized shutdown due to some internal error checking mechanism reporting that things got wrong. Looks like an app detects some kind of internal error condition, logs some details to a "crash report txt file" I had mentioned earlier and terminates itself showing a messagebox with an error message.
So, to be more clear: the crash this bug was about initially is no more, app execution flow manages to pass by the problematic place and get into app's main menu. There's no sound and music output though, and the game terminates itself with an error message as soon as it finishes loading a savegame which. With Wine 1.3.24 + native DM/DS there are no problem loading this particular save, so chances are pretty high that an app terminates itself due some factor that is a consequence to a non-working sound and music.
It's possible that the application installed an exception handler to handle a segfault and display the dialog box. This won't show up in a log file without +seh. It's also possible that you're correct, I don't know.
The hope was that one of those debug channels would give us an indication of where the problem occurs in the log file. E.g. if it's a standard user32 MessageBoxA() dialog box, then we should see that on the +msgbox channel in the log file.
BTW, is your dmime patch backwards compatible with, say, Wine 1.3.25? It might be worth checking if an app would work with that version + fix and compare run traces with 1.3.24 + native DM/DS.
It should apply, but I don't know if that's useful. Wine's dmusic implementation is basically completely wrong. We just need to find out which wrong bit is responsible for this particular error, and fix it :)
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #19 from Alexey Loukianov mooroon2@mail.ru 2012-04-18 06:00:03 CDT --- (In reply to comment #18)
It's possible that the application installed an exception handler to handle a segfault and display the dialog box. This won't show up in a log file without +seh. It's also possible that you're correct, I don't know.
The hope was that one of those debug channels would give us an indication of where the problem occurs in the log file. E.g. if it's a standard user32 MessageBoxA() dialog box, then we should see that on the +msgbox channel in the log file.
No problems, would capture new logs with these channels enabled and post them here in about half an hour. Most likely it is really MessageBoxA/W(), basing on the visual appearance of the dialog box.
It should apply, but I don't know if that's useful. Wine's dmusic implementation is basically completely wrong. We just need to find out which wrong bit is responsible for this particular error, and fix it :)
Yeah, as always :-). All in all, my goal was to check if the "graceful CTD" I've been getting is really dmusic/dsound related one and not something that had regressed on a way from 1.3.24 to 1.5.2. So I had tried to apply your patch to 1.3.24 sources and tested the game with it. Looks like we're "lucky", as this CTD also happens in 1.3.24 with builtins + your patch, and doesn't happen with same 1.3.24 + native dsound/dmusic. Looks like it is more or less safe to stick with latest git HEAD and use it as a base for further testing.
http://bugs.winehq.org/show_bug.cgi?id=25728
Alexey Loukianov mooroon2@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #39841|0 |1 is obsolete| |
--- Comment #20 from Alexey Loukianov mooroon2@mail.ru 2012-04-18 07:22:40 CDT --- Created attachment 39851 --> http://bugs.winehq.org/attachment.cgi?id=39851 WINE 1.5.2 + UFO_ET.EXE debug traces with dmime patch applied, with seh/dlg/msgbox debug channels.
Here they are.
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #21 from Andrew Eikum aeikum@codeweavers.com 2012-04-18 08:44:21 CDT --- And here's the crash:
0054:trace:dmime:IDirectMusicSegment8Impl_IDirectMusicSegment8_SetLoopPoints (0x11f45bf0, 0, 0) 0054:trace:seh:raise_exception code=e06d7363 flags=1 addr=0x7b83a1f2 ip=7b83a1f2 tid=0054
Looks like the segment header isn't being loaded correctly, so SetLoopPoints() thinks it's being called with invalid parameters and returns an error code. That causes UFO:ET to raise an exception and display that dialog.
Looking into it briefly, this is a result of Wine's dmusic COM implementation, which is in really bad shape. Michael Stefaniuc is researching how it _should_ work, and is sending patches to improve it. Once he's finished fixing dmusic's COM implementation, we can take a closer look at fixing this.
I'm going to put this bug "on hold" until the COM stuff is fixed. In the meantime, I'll try looking at Bug 28340 more closely to see if we can get the native workaround working again.
Thanks for being so generous with the logs.
http://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #22 from Alexey Loukianov mooroon2@mail.ru 2012-04-18 08:49:27 CDT --- (In reply to comment #21)
Looking into it briefly, this is a result of Wine's dmusic COM implementation, which is in really bad shape. Michael Stefaniuc is researching how it _should_ work, and is sending patches to improve it. Once he's finished fixing dmusic's COM implementation, we can take a closer look at fixing this.
I'm going to put this bug "on hold" until the COM stuff is fixed. In the meantime, I'll try looking at Bug 28340 more closely to see if we can get the native workaround working again.
Thanks for being so generous with the logs.
You're welcome. Feel free to contact me in case there'd be need to test some dmusic patches with this game, chances are I'd be able to do it in pretty timely manner. And, traditionally, thanks once again for spending your time working hard on Wine's sound subsystem.
http://bugs.winehq.org/show_bug.cgi?id=25728
Jörg Höhle hoehle@users.sourceforge.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|directx-dsound |directx-dmusic
http://bugs.winehq.org/show_bug.cgi?id=25728
Andrew Eikum aeikum@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |titan.costa@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=25728
Saulius K. saulius2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |saulius2@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=25728
Béla Gyebrószki gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |gyebro69@gmail.com Ever confirmed|0 |1
--- Comment #23 from Béla Gyebrószki gyebro69@gmail.com --- Confirming..still present in wine-1.7.20-102-g889cce4
https://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #24 from Austin English austinenglish@gmail.com --- This is your friendly reminder that there has been no bug activity for over a year. Is this still an issue in current (1.7.51 or newer) wine?
https://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #25 from Alexey Loukianov mooroon2@mail.ru --- Thanks for kicking on this one. I'm traveling ATM, would try to find some time and test it with latest released wine on the next weekend.
https://bugs.winehq.org/show_bug.cgi?id=25728
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=25728
joaopa jeremielapuree@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr
--- Comment #26 from joaopa jeremielapuree@yahoo.fr --- Does the bug still occur with current wine(4.0-rc2)?
https://bugs.winehq.org/show_bug.cgi?id=25728
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair@hotmail.com Attachment #39840|0 |1 is obsolete| |
--- Comment #27 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Comment on attachment 39840 --> https://bugs.winehq.org/attachment.cgi?id=39840 dmime: Don't try to create a standard audio path if the client didn't ask for one
This patch has been accepted upstream.
Can you please confirm, if this is a still an issue.
https://bugs.winehq.org/show_bug.cgi?id=25728
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|patch |
https://bugs.winehq.org/show_bug.cgi?id=25728
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO
https://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #28 from Béla Gyebrószki gyebro69@gmail.com --- Created attachment 65973 --> https://bugs.winehq.org/attachment.cgi?id=65973 Wine 5.0-rc1 audio debug log
Still present in 5.0-rc1 Staging, tested with UFO:ET Gold (available on Steam). The game starts without sound/music, but doesn't crash (yet). The crash happens when loading a tactical mission. During the mission loading stage the error message "Internal error occurred - please send error log file..." appears then the game quits.
https://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #29 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Can you please attached log with the following channels. dsound,dsound3d,dmcompos,dmfile,dmobj,dmband,dmime,dmloader,dmdump,dmscript,dmstyle,dmsynth,dmusic,pulse,winmm
https://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #30 from Béla Gyebrószki gyebro69@gmail.com --- Created attachment 65980 --> https://bugs.winehq.org/attachment.cgi?id=65980 Wine 5.0-rc1 dmusic debug log
(In reply to Alistair Leslie-Hughes from comment #29)
Can you please attached log with the following channels. dsound,dsound3d,dmcompos,dmfile,dmobj,dmband,dmime,dmloader,dmdump,dmscript, dmstyle,dmsynth,dmusic,pulse,winmm
I attached the log file you requested.
https://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #31 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Created attachment 65981 --> https://bugs.winehq.org/attachment.cgi?id=65981 Loader patch
Can you please try the attached patch?
https://bugs.winehq.org/show_bug.cgi?id=25728
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #32 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Alistair Leslie-Hughes from comment #31)
Created attachment 65981 [details] Loader patch
Can you please try the attached patch?
The patch doesn't prevent the game from crashing.
https://bugs.winehq.org/show_bug.cgi?id=25728
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mstefani@winehq.org Status|NEEDINFO |NEW
--- Comment #33 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- (In reply to Béla Gyebrószki from comment #30)
I attached the log file you requested.
Thank you.
The first issue I think that needs to be addressed is the fact CreateStandardAudioPath is called over and over again without any cleanup.
Searching for this in the log and you can see that it's being called multiple times. IDirectMusicPerformance8Impl_CreateStandardAudioPath (03D5E2C0)
This accounts for the warnings of 0111:warn:dsound:DSOUND_PrimaryDestroy Destroying primary buffer while references held (7 1)
https://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #34 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- (In reply to Alistair Leslie-Hughes from comment #33)
(In reply to Béla Gyebrószki from comment #30)
I attached the log file you requested.
Thank you.
There are multiple issues 1. The primary buffer isn't being Released when the IDirectMusicAudioPath object is being destroyed (patch sent)
2. For the IDirectMusicAudioPath to be released, the game must receive a end segment notification.
3. The Unknown Object isn't being released in FreePMsg. (patch sent)
https://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #35 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- (In reply to Alistair Leslie-Hughes from comment #34)
- The primary buffer isn't being Released when the IDirectMusicAudioPath
object is being destroyed (patch sent)
https://source.winehq.org/patches/data/175989
- The Unknown Object isn't being released in FreePMsg. (patch sent)
https://source.winehq.org/patches/data/175990
https://bugs.winehq.org/show_bug.cgi?id=25728
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #65981|0 |1 is obsolete| |
--- Comment #36 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Created attachment 66187 --> https://bugs.winehq.org/attachment.cgi?id=66187 Dont error on valid input
Can you please try this patch?
https://bugs.winehq.org/show_bug.cgi?id=25728
--- Comment #37 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Alistair Leslie-Hughes from comment #36)
Created attachment 66187 [details] Dont error on valid input
Can you please try this patch?
The patch fixes the crash when loading a mission, thanks a lot.
https://bugs.winehq.org/show_bug.cgi?id=25728
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |01d521e5afc39dfcfc1487f6010 | |2afe0e58337b8 Resolution|--- |FIXED
--- Comment #38 from Michael Stefaniuc mstefani@winehq.org --- Patch got committed: https://source.winehq.org/git/wine.git/?a=commit;h=01d521e5afc39dfcfc1487f60...
Thanks Alistair!
https://bugs.winehq.org/show_bug.cgi?id=25728
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #39 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.0-rc5.
https://bugs.winehq.org/show_bug.cgi?id=25728
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.0.x
https://bugs.winehq.org/show_bug.cgi?id=25728
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.0.x |---
--- Comment #40 from Michael Stefaniuc mstefani@winehq.org --- Removing the 4.0.x milestone from bug fixes included in 4.0.4.
-
wine-bugs＠winehq.org -
WineHQ Bugzilla