[Bug 10973] New: Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

Summary: Regression: Commandos 3 - menu not properly rendered
           Product: Wine
           Version: 0.9.52.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wine-directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Created an attachment (id=9918)
 --> (http://bugs.winehq.org/attachment.cgi?id=9918)
Incorrectly rendered menu

Hi,

In latest wine 0.9.52 there is a regression in Commandos 3 affecting rendering
of menu and fonts in the game. I did a regression test and found this commit
with git bisect:

[f3df6cf42b4e705b5e687df08b9f8c3ff8b2d41c] wined3d: Only store the palette
index

Attached is screenshot of the menu.

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

Alexander Dorofeyev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #1 from Alexander Dorofeyev   2007-12-31 15:28:25 ---
Confirming with demo.
http://www.eidosinteractive.com/downloads/search.html?gmid=143

Hmm. I think the patch has to be correct. Maybe there is some other bug that
was hidden by previous behavior.

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.eidosinteractive.
                   |                            |com/downloads/search.html?gm
                   |                            |id=143
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |download

--- Comment #2 from Austin English   2007-12-31 17:27:31 ---
I'm seeing this as well. Confirming, wine 0.9.52, ubuntu feisty.

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #3 from Alexander Dorofeyev   2007-12-31 17:57:08 ---
I see in the logs that the app is setting shaders, and it uses P8 textures.
Perhaps that's the problem, that its shaders are unhappy with the "behind the
stage" magic Wine does with P8 textures?

BTW it's not like it was perfect before. I tried wine-0.9.50 and there are
visible artifacts there as well + cursor has a Black rectangle. But it
certainly got a lot worse in 0.9.52.

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #4 from Roderick Colenbrander   2008-01-13 16:33:01 ---
I have looked into the bug. The palette index patch is in fact correct. The
problem somehow seems to be that some wrong value is stored in the alpha
component of the palette. Setting index_in_alpha hided the problem. I'm not
sure what is wrong.

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Roderick Colenbrander   2008-01-13 16:35:46 ---
*** Bug 11169 has been marked as a duplicate of this bug. ***

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #6 from Alexander Dorofeyev   2008-01-23 17:40:33 ---
Created an attachment (id=10427)
 --> (http://bugs.winehq.org/attachment.cgi?id=10427)
alpha from palette fix

I think it wants alpha from palette entries (msdn says device9 & 8 palettes
contain ARGB data). Relevant msdn page:

http://msdn2.microsoft.com/en-us/library/bb206252(VS.85).aspx

With the attached fix the menu seems to render flawlessly. There are other
rendering issues later on, within the level, but that's probably different bugs
(they were there before this "regression").

This needs good testing though, I'm not sure that as is it won't break some
other games. Theoretically, games like Starcraft probably shouldn't be
affected, because device palettes seem to be specific to d3d8 and d3d9, but I
haven't yet verified this assumption in practice :).

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #7 from joaopa   2008-01-24 00:59:12 ---
your parch fixes Madden NFL 2004 demo.

great job

Joaopa

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #8 from Pawel Nadolski   2008-01-24 15:55:35 ---
The patch not only fixes regression in Commandos 3, but it also solves some
issues with black background around objects like mouse cursor, sniper scope and
hud elements. Thanks!

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

bigoten  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from bigoten   2008-01-31 09:31:00 ---
Hi. Please, you do we install this patch? I am completely lost here... Using
Ubuntu Gutsy. Thanks in advance

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #10 from Austin English   2008-01-31 11:19:49 ---
(In reply to comment #9)
> Hi. Please, you do we install this patch? I am completely lost here... Using
> Ubuntu Gutsy. Thanks in advance

http://wiki.winehq.org/RegressionTesting

Look at the section on patching your git tree. You have to download the wine
source, patch it, then rebuild it.

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #11 from bigoten   2008-01-31 18:14:12 ---
I shall try this asap. I'm sorry for asking as I did, but it's the very first
time I need to do it and I'm still a noob at linux. Many thanks for the tip, I
shall post whether it works or not. Thanks:)

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #12 from bigoten   2008-02-01 06:06:19 ---
Well, it failed to work with me:(

I don't see what I did wrong. Basically I followed these steps:
- installed git-core, ccache (with Synaptic)
- downloaded the wine source code:
      git clone git://source.winehq.org/git/wine.git wine-git
      cd wine-git
- downloaded palette_alpha_fix.diff and installed it:
      patch -p1 < palette_alpha_fix.diff
At this point the Terminal should say something like "dlls/wined3d has been
patched" (according to the help you suggested to me), but instead it said only
that it was patching dlls/wine3d/surface.c (I think, I'm writing this by heart)
- finally I did: ./configure && make clean && make depend && make

And the game is the same as it was (the menu is not configured).
Am I missing some step somewhere?
Thank you once again.

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #13 from joaopa   2008-02-01 07:42:51 ---
You forgot to do "make install" as root
or /home/name_of_users/wine-git/wine nameofapplication.exe

Joaopa

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #14 from joaopa   2008-02-01 16:38:17 ---
I tried the demo with the patch. It fixed the problem. Since the patch fixes
several games, it is correct surely.
Will it be sent to wine-patches to be commited?

Joaopa

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #15 from James Hawkins   2008-02-01 16:46:18 ---
Fixing a lot of apps by itself does not mean a patch is correct.

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #16 from Roderick Colenbrander   2008-02-02 02:08:10 ---
Sorry but the patch is not correct. For instance it breaks a lot of DirectDraw
games like Red Alert and others.

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #17 from bigoten   2008-02-10 16:08:29 ---
(In reply to comment #13)
> You forgot to do "make install" as root
> or /home/name_of_users/wine-git/wine nameofapplication.exe
>
> Joaopa

Well, this is really not working for me, I think I'm taking the wrong steps
somewhere.
I've uninstalled the git-core and started all over again. When I try to install
palette_alpha_fix.diff (in ~/wine-git) I now get this error:

"patching file dlls/wined3d/surface.c
Hunk #1 FAILED at 1907.
1 out of 1 hunk FAILED -- saving rejects to file dlls/wined3d/surface.c.rej"

And I don't know what to do.
Moreover, I didn't understand how to execute your suggestion (the "make
install" part). Can you specify in noob words (sorry, I am one...)?
Thanks for your patience:)

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #18 from Roderick Colenbrander   2008-02-10 16:24:46 ---
The patch won't apply anymore because I changed some stuff in the function.
Second the patch which was proposed here is not correct. Something along those
lines might need to be done in certain cases but not in all. We need to find
out when it is needed and when not.

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #19 from joaopa   2008-02-18 13:05:01 ---
Bug is still here in NFL 2004 demo with git dated of today, in despite of
Roderick'patches.

Joaopa

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #20 from Alexander Dorofeyev   2008-02-18 14:12:02 ---
A revised patch has been sent to wine-patches, hopefully it will be in for
0.9.56.

http://article.gmane.org/gmane.comp.emulators.wine.patches/47240

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #21 from Alexander Dorofeyev   2008-02-19 12:02:06 ---
Patch is in git, so I believe the bug has been fixed.

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #22 from Roderick Colenbrander   2008-02-19 12:42:11 ---
In order to fix some bugs and to make the code easier to maintain I have been
thinking about ways to restructure it. Today I noticed for the first time that
there is a d3d8/9 palette called 'palette9' in the code but it isn't really
used. Perhaps we should be using palette9... Second I'm also researching Red
Alert again on why it enters the NULL path and third I plan on removing most
alpha code from the init palette function as we should use the color key in
glAlphaFunc.

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

--- Comment #23 from joaopa   2008-02-19 12:56:48 ---
Bug is fixed for NFL Madden 2004 demo.

Great job,

Joaopa

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

Pawel Nadolski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #24 from Pawel Nadolski   2008-02-20 17:37:32 ---
Fixed in wine-0.9.55-388-gea56370. Closing.

Thank you!

[Bug 10973] Regression: Commandos 3 - menu not properly rendered

http://bugs.winehq.org/show_bug.cgi?id=10973

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #25 from Dan Kegel   2008-02-22 11:39:53 ---
0.9.56 released, so closing all bugs marked as RESOLVED FIXED.