[Bug 18071] New: Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

Summary: Core Media Player - installer "Cannot read access
                    control list"
           Product: Wine
           Version: 1.1.19
          Platform: PC-x86-64
               URL: http://www.tucows.com/preview/299014
        OS/Version: Linux
            Status: NEW
          Keywords: download, Installer
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

My roommate despises VLC, and is in love with this media player. Step 1 in his
dogfood transition to Ubuntu would be getting this media player to work in
Wine.

First problem: on install, get this error. It's been reported on wine-users
(http://www.winehq.org/pipermail/wine-users/2008-March/031475.html) but I
haven't seen a bug for it. Looks like it may be related to NTFS ACL's.

Error
Cannot read access control lists.
Error code: 1400
OK

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

--- Comment #1 from Jeff Zaroyko   2009-04-16 00:38:35 ---
(In reply to comment #0)
> First problem: on install, get this error. It's been reported on wine-users
> (http://www.winehq.org/pipermail/wine-users/2008-March/031475.html) but I
> haven't seen a bug for it. Looks like it may be related to NTFS ACL's.
>
> Error
> Cannot read access control lists.
> Error code: 1400
> OK

The post on wine-users refers to the FL Studio 7 and 8 installer which reports
the problem 3-4 times.

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

--- Comment #2 from Austin English   2009-04-16 00:47:29 ---
(In reply to comment #1)
> (In reply to comment #0)
> > First problem: on install, get this error. It's been reported on wine-users
> > (http://www.winehq.org/pipermail/wine-users/2008-March/031475.html) but I
> > haven't seen a bug for it. Looks like it may be related to NTFS ACL's.
> >
> > Error
> > Cannot read access control lists.
> > Error code: 1400
> > OK
>
> The post on wine-users refers to the FL Studio 7 and 8 installer which reports
> the problem 3-4 times.

Yeah, it does it twice on Core Media Player.

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Louis Lenders   2009-04-16 02:06:03 ---
(In reply to comment #2)
> (In reply to comment #1)
> > (In reply to comment #0)
> > > First problem: on install, get this error. It's been reported on wine-users
> > > (http://www.winehq.org/pipermail/wine-users/2008-March/031475.html) but I
> > > haven't seen a bug for it. Looks like it may be related to NTFS ACL's.

Looks like it's not happy with what GetNamedSecurityInfo returns if descriptor
=0. Hack below gets rid of the errormessage. You'd have to test i guess what
happens on windows if descriptor=0.

diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c
index f8715e0..2a3c29c 100644
--- a/dlls/advapi32/security.c
+++ b/dlls/advapi32/security.c
@@ -5082,8 +5082,8 @@ DWORD WINAPI GetNamedSecurityInfoW( LPWSTR name,
SE_OBJECT_TYPE type,
     TRACE( "%s %d %d %p %p %p %p %p\n", debugstr_w(name), type, info, owner,
            group, dacl, sacl, descriptor );

-    if (!name || !descriptor) return ERROR_INVALID_PARAMETER;
-
+    if (!name ) return ERROR_INVALID_PARAMETER;
+    if (!descriptor) descriptor = HeapAlloc(GetProcessHeap(), 0,
sizeof(PSECURITY_DESCRIPTOR));
     needed = sizeof(SECURITY_DESCRIPTOR_RELATIVE);
     if (info & OWNER_SECURITY_INFORMATION)
         needed += sizeof(sidWorld);

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

--- Comment #4 from Austin English   2009-04-16 11:34:51 ---
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > (In reply to comment #0)
> > > > First problem: on install, get this error. It's been reported on wine-users
> > > > (http://www.winehq.org/pipermail/wine-users/2008-March/031475.html) but I
> > > > haven't seen a bug for it. Looks like it may be related to NTFS ACL's.
>
> Looks like it's not happy with what GetNamedSecurityInfo returns if descriptor
> =0. Hack below gets rid of the errormessage. You'd have to test i guess what
> happens on windows if descriptor=0.

I added a testcase:

http://www.winehq.org/pipermail/wine-patches/2009-April/071934.html

but on 2k at least, returns ERROR_INVALID_PARAMETER.

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

Niko Sandschneider  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Niko Sandschneider   2009-08-04 06:23:02 ---
Still present in wine 1.1.26

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

Ilya Mizus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Ilya Mizus   2009-09-21 06:46:40 ---
Still reproduced on FLStudio 9

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Jeff Zaroyko   2010-05-29 03:50:48 ---
*** Bug 22923 has been marked as a duplicate of this bug. ***

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

--- Comment #8 from Alex   2010-06-01 09:28:50 ---
I've submitted a test to WineTestBot
(https://testbot.winehq.org/JobDetails.pl?Key=2414)

and what I understand is that a security descriptor may be NULL if at least one
pointer is not NULL. Otherwise, it returns ERROR_INVALID_ARGUMENT.

So I guess doing what comment #3 suggests is not sufficient.
We should check that the "at least" condition and then allocate what's needed.

But before sending a patch, I'd have your opinion.
So what do you think ?

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

--- Comment #9 from Austin English   2010-06-03 13:38:32 ---
Testcase looks fine, go ahead and submit to wine-patches.

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

--- Comment #10 from Alex   2010-08-24 12:00:45 ---
Should be fixed by
http://source.winehq.org/git/wine.git/?a=commitdiff;h=2c127dd320ac066b98793b....

Please retest with latest wine

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

--- Comment #11 from Niko Sandschneider   2010-08-24 13:53:16 ---
Yes, the installer works indeed fine with wine-1.3.1-135-g2c127dd, so this is
fixed.

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #12 from Dan Kegel   2010-08-24 18:55:19 ---
Reported fixed, yay.

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

--- Comment #13 from Austin English   2010-08-24 19:07:31 ---
(In reply to comment #12)
> Reported fixed, yay.

Yep, installs great in git. Crashes on run though, need qdvd.dll to fix that. I
filed bug 24127 for that.

[Bug 18071] Core Media Player - installer "Cannot read access control list"

http://bugs.winehq.org/show_bug.cgi?id=18071

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard  2010-09-03 14:05:32 CDT ---
Closing bugs fixed in 1.3.2.