[Bug 16188] New: Wine should prompt users to save files upon system shutdown

http://bugs.winehq.org/show_bug.cgi?id=16188

Summary: Wine should prompt users to save files upon system
                    shutdown
           Product: Wine
           Version: 1.1.9
          Platform: Other
               URL: http://www.x.org/docs/SM/SMlib.pdf
        OS/Version: other
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

http://groups.google.com/group/comp.emulators.ms-windows.wine/msg/9f45abb0f1...
asks, reasonably,
"When I have unsaved document in any wine application (like notepad) and
I log out or shut down the PC, Wine application doesn't offer me to save
the document, it just kills everything. Can something be done about it?"

My google-fu led me to
http://lists.freedesktop.org/archives/xdg/2004-August/002898.html
which led me to
http://www.x.org/docs/SM/xsmp.pdf and
http://www.x.org/docs/SM/SMlib.pdf

Wine should probably support those somehow, and use them to notify applications
of impending system shutdown.

[Bug 16188] Wine should prompt users to save files upon system shutdown

http://bugs.winehq.org/show_bug.cgi?id=16188

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 16188] Wine should prompt users to save files upon system shutdown

http://bugs.winehq.org/show_bug.cgi?id=16188

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |download, integration

[Bug 16188] Wine should prompt users to save files upon system shutdown

http://bugs.winehq.org/show_bug.cgi?id=16188

--- Comment #1 from Damjan Jovanovic   2009-01-03 02:08:32 ---
Created an attachment (id=18421)
 --> (http://bugs.winehq.org/attachment.cgi?id=18421)
XSMP support

Well I've got the beginning of a patch for this (changed to configure not
included), but it has a number of issues:

1. Apparently (according to gnome-session 2.22 source) libSM doesn't like
re-entry.

2. On xfce-session, this correctly stops a shutdown if applications are busy.
However if applications allow a shutdown, it pauses for about a minute before
shutting down. Could be related to (1).

3. The libICE connection is only processed when there are X11 messages in the
queue, so nothing happens until you move the mouse over the window :-).

4. The biggest problem, is that XSMP is considered an ancient standard that
doesn't play nicely with today's power management and suspend/resume.
Gnome-session 2.24 (used on Ubuntu 8.10 and the new Fedora) doesn't work at
all, since that version of gnome-session has started moving to a new DBus based
(and currently Gnome proprietary) session manager protocol and support for the
legacy XSMP stuff has not been finished yet
(https://bugs.launchpad.net/ubuntu/+source/gnome-session/+bug/249373).

So I am not sure it's worth it to continue with this XSMP-based patch, or wait
a few months for the new, better, DBus API to get standardised.

[Bug 16188] Wine should prompt users to save files upon system shutdown

http://bugs.winehq.org/show_bug.cgi?id=16188

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 16188] Wine should prompt users to save files upon system shutdown

http://bugs.winehq.org/show_bug.cgi?id=16188

--- Comment #2 from Austin English   2010-07-10 21:56:52 ---
Still present. Easy test:

terminal 1:
$ wine notepad # type some text

terminal 2
$ wineboot -e #end-session

notepad will prompt you to save the text
if you use wineboot -s or wineboot -r (restart/shutdown), you are NOT prompted.

wine is still not warning apps though, so if you do:
$ wine notepad # type asdf
then shutdown/restart your system, you'll get no warning.

[Bug 16188] Wine should prompt users to save files upon system shutdown

http://bugs.winehq.org/show_bug.cgi?id=16188

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Damjan Jovanovic   2010-07-27 09:19:14 ---
*** Bug 23482 has been marked as a duplicate of this bug. ***

[Bug 16188] Wine should prompt users to save files upon system shutdown

http://bugs.winehq.org/show_bug.cgi?id=16188

nathan.n  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 16188] Wine should prompt users to save files upon system shutdown

http://bugs.winehq.org/show_bug.cgi?id=16188

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #4 from Damjan Jovanovic   2010-07-29 08:24:01 ---
I've submitted a patch that fixes this for notepad
(http://source.winehq.org/patches/data/64395).

Please test with uTorrent.

[Bug 16188] Wine should prompt users to save files upon system shutdown

http://bugs.winehq.org/show_bug.cgi?id=16188

--- Comment #5 from Alex Y. Shalimov   2010-07-30 23:36:51 ---
Should I apply your first path (XSMP support) as well? It doesn't apply to the
latest revision from git. I've tried to apply only second patch, but it doesn't
work even with notepad (seems like start_session_management doesn't get
called). I've run autoconf and autoheader after patching, as you wrote. How do
you invoke notepad so that shutdown works?

[Bug 16188] Wine should prompt users to save files upon system shutdown

http://bugs.winehq.org/show_bug.cgi?id=16188

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from [e-mail] 2012-05-18 06:05:06 CDT ---
This bug has not been updated for two years and OP by four. Is this still an
issue i current (1.5.4) or newer wine ? You may also close this as abandoned if
you feel that that this is issue is no longer relevant to you.

[Bug 16188] Wine should prompt users to save files upon system shutdown

http://bugs.winehq.org/show_bug.cgi?id=16188

--- Comment #7 from Damjan Jovanovic  2012-05-18 08:54:40 CDT ---
(In reply to comment #6)
> This bug has not been updated for two years and OP by four. Is this still an
> issue i current (1.5.4) or newer wine ? You may also close this as abandoned if
> you feel that that this is issue is no longer relevant to you.

Yes, it absolutely is still an issue. Large bugs like this don't stay open by
accident.

[Bug 16188] Wine should prompt users to save files upon system shutdown

https://bugs.winehq.org/show_bug.cgi?id=16188

--- Comment #8 from Ken Sharp  ---
No change in Wine 1.7.45.

[Bug 16188] Wine should prompt users to save files upon system shutdown

https://bugs.winehq.org/show_bug.cgi?id=16188

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from [e-mail] ---
The patch here doesnt apply cleanly anymore.

patching file configure.ac
Hunk #1 FAILED at 77.
Hunk #2 succeeded at 1111 (offset 220 lines).
Hunk #3 succeeded at 1223 with fuzz 2 (offset 230 lines).
1 out of 3 hunks FAILED -- saving rejects to file configure.ac.rej
patching file programs/explorer/Makefile.in
Hunk #1 FAILED at 7.
1 out of 1 hunk FAILED -- saving rejects to file
programs/explorer/Makefile.in.rej
patching file programs/explorer/desktop.c
Hunk #1 succeeded at 35 with fuzz 1 (offset 6 lines).
Hunk #2 succeeded at 909 (offset 651 lines).
Hunk #3 succeeded at 1208 with fuzz 2 (offset 657 lines).

[Bug 16188] Wine should prompt users to save files upon system shutdown

https://bugs.winehq.org/show_bug.cgi?id=16188

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from joaopa  ---
Can an administrator close this bug as WONTFIX?

[Bug 16188] Wine should prompt users to save files upon system shutdown

https://bugs.winehq.org/show_bug.cgi?id=16188

--- Comment #11 from Zebediah Figura  ---
(In reply to joaopa from comment #10)
> Can an administrator close this bug as WONTFIX?

Why?

[Bug 16188] Wine should prompt users to save files upon system shutdown

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=16188

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from [e-mail] ---
See

https://askubuntu.com/questions/293312/execute-a-script-upon-logout-reboot-s...

Check if wine is running, terminate it properly upon shutdown.

A packaging issue. As Austin pointed out wineboot --end-session provides for
the required features.