[Bug 10905] New: thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

Summary: thinstall firefox demo requires native msvcrt
           Product: Wine
           Version: CVS/GIT
          Platform: Other
               URL: http://thinstall.com/downloads/firefox_autoplay.exe
        OS/Version: other
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: wine-msvcrt
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Running http://thinstall.com/downloads/firefox_autoplay.exe
aborts silently and quickly just as it's getting
started.  Using native msvcrt works around this.
Looking at the log, it seems the suspicious bit is right around
this line:

trace:msvcrt:read_i (111),
"[General]\r\nStartWithLastProfile=1\r\n\r\n[Profile0]\r\nName=default\r\nIsRelative=1\r\nPath=Profiles/fm4cpmjr.default\r\n\r\n"
trace:msvcrt:read_i already at EOF, returning 0

so I suspect a problem in our fread().
I'll attach the segment of the log from the fopen to the ExitProcess.

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

--- Comment #1 from Dan Kegel   2007-12-27 07:04:25 ---
Created an attachment (id=9819)
 --> (http://bugs.winehq.org/attachment.cgi?id=9819)
+relay,+msvcrt log showing leadup to abort

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

--- Comment #2 from Eric Pouech   2007-12-28 08:46:43 ---
Created an attachment (id=9843)
 --> (http://bugs.winehq.org/attachment.cgi?id=9843)
proposed solution

Actually, fread is not to blame. Thinstall hooks its own procedure to lots of
kernel32 entries (I assume in order not to pollute the disk with lots of
temporary files, but rather look at them in a compressed way from the
executable itself).
And Thinsall did not hook into SetFilePointerEx but only SetFilePointer.
So changing our msvcrt to use only the former (and no longer the later) seems
to satisfy the installer.

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

Eric Pouech  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

Ge van Geldorp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Ge van Geldorp   2007-12-28 14:54:25 ---
Actually, we (= Thinstall) should already be hooking SetFilePointerEx(). I'll
investigate why our hook fails under Wine and will report back.

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

--- Comment #4 from Ge van Geldorp   2007-12-29 15:16:55 ---
The Firefox demo on the Thinstall website was created with a rather old
Thinstall version, which indeed didn't hook the SetFilePointerEx() function.
We've rebuilt the demo with the latest Thinstall version so there's no need for
the SetFilePointer() work around anymore.

With the latest Thinstall version, I did run into another problem though.
Thinstall now calls SHGetFolderPath() with a non-NULL (and non-Default) token.
I'll submit a patch to wine-patches to get the desired behavior.

I think this bug can be closed.

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

--- Comment #5 from Dan Kegel   2007-12-29 17:44:11 ---
Thanks, all.

Can't close it until the patch is committed.

I'd test but I can't get to thinstall.com at the moment.

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

--- Comment #6 from Ge van Geldorp   2008-01-09 02:25:56 ---
Patch seems to have disappeared into the wine-patches blackhole. Available
here: http://www.winehq.org/pipermail/wine-patches/2007-December/048437.html

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|msvcrt                      |shell32
           Keywords|                            |patch
   Target Milestone|---                         |1.0.0

--- Comment #7 from Dan Kegel   2008-01-09 07:46:15 ---
Fixed category, added 'patch' keyword, nominating for 1.0.
That should help keep it from falling through the cracks.

Normal protocol on wine-patches is:
if patch is not accepted on first send, improve it if possible
(e.g. by adding a conformance test) and resend with [take 2]
or [resend] in the subject line (the latter if it's unchanged).

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

--- Comment #8 from Austin English   2008-02-18 15:07:50 ---
In today's git, pops up an error:

Module Not Found
C:\Program Files\Mozilla Firefox\firefox.exe->js3250.dll

Then exits after clicking okay. Adding that dll to system32 and overriding it
in winecfg makes no difference.

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

--- Comment #9 from Ge van Geldorp   2008-03-09 16:27:07 ---
I was unable to reproduce the js3250.dll problem with todays git (after
applying http://www.winehq.org/pipermail/wine-patches/2008-March/051252.html)

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

--- Comment #10 from Dan Kegel   2008-03-27 14:11:08 ---
With today's git, it's still aborting with the
js3250.dll dialog.

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.0.0                       |1.2.0

--- Comment #11 from Dan Kegel   2008-03-30 10:47:23 ---
Deferring.

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

Steven Edwards  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Steven Edwards   2008-04-12 23:30:35 ---
I submitted a new patch for the js3250.dll issue

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

--- Comment #13 from Dan Kegel   2008-04-13 20:58:34 ---
Your patch,
http://winehq.org/pipermail/wine-patches/2008-April/053265.html
totally works.  We should commit it.  Thanks!

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.2.0                       |1.0.0

--- Comment #14 from Dan Kegel   2008-04-13 20:59:23 ---
Retargeting to 1.0

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.0.0                       |1.2.0

--- Comment #15 from Dan Kegel   2008-05-01 14:04:30 ---
Alexandre pushed back:
http://www.mail-archive.com/[e-mail]/msg44267.html

Deferring to 1.2.

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

Jim Hawking  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Jim Hawking   2008-12-06 15:30:39 ---
6 month update.

The programme still cannot find JS3250.dll but I guess that's no surprise. I
guess we wait for 1.2

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

--- Comment #17 from Ge van Geldorp   2008-12-06 17:17:09 ---
Thinstall was acquired in January 2008 by VMware, the Thinstall product lives
on as VMware ThinApp. Alexandre indicated (see link in comment #15) that this
wasn't a Wine problem, but a Thinstall/ThinApp problem and we (= ThinApp
engineers) agree with that. So we fixed it.
Earlier this week we released ThinApp 4.0.1 which has a fix for this problem. I
hadn't gotten around to rebuilding and updating the Firefox demo but I've done
so now, the updated version is available at same location
http://thinstall.com/downloads/firefox_autoplay.exe.
This new version works fine with todays Git. As a matter of fact, I'm typing
this in a virtual Firefox running under Wine.

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #18 from Dan Kegel   2008-12-06 17:37:57 ---
woot!  Marking fixed.

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

--- Comment #19 from Austin English   2008-12-06 18:10:34 ---
Shouldn't this be invalid then?

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |INVALID

--- Comment #20 from Dan Kegel   2008-12-06 20:27:28 ---
Yeah, sorry, I thought one of those two patches got in to wine.

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #21 from Austin English   2008-12-08 04:23:11 ---
Closing.

[Bug 10905] thinstall firefox demo requires native msvcrt

http://bugs.winehq.org/show_bug.cgi?id=10905

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.2.0                       |---
            Version|CVS/GIT                     |unspecified