https://bugs.winehq.org/show_bug.cgi?id=56379
Bug ID: 56379 Summary: d2d1 regression unable to build after: https://gitlab.winehq.org/wine/wine/-/commit/167103114 389c7f487f7d6aa398f56abf9cc5572 Product: Wine Version: 9.1 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: dofficialgman@gmail.com Distribution: ---
Regression after https://gitlab.winehq.org/wine/wine/-/commit/167103114389c7f487f7d6aa398f56a...
unable to build with the following errors:
i686-w64-mingw32-gcc -c -o dlls/d2d1/i386-windows/effect.o ../wine-9.3/dlls/d2d1/effect.c -Idlls/d2d1 -I../wine-9.3/dlls/d2d1 -Iinclude \ -I../wine-9.3/include -I../wine-9.3/include/msvcrt -D_UCRT -D__WINESRC__ -D__WINE_PE_BUILD -Wall \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Winit-self \ -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla \ -Wwrite-strings -Wpointer-arith -Wlogical-op -fno-omit-frame-pointer -mpreferred-stack-boundary=2 \ -gdwarf-4 -g -O2 ../wine-9.3/dlls/d2d1/effect.c: In function 'd2d_effects_init_builtins': ../wine-9.3/dlls/d2d1/effect.c:296:41: error: initializer element is not constant { &CLSID_D2D12DAffineTransform, _2d_affine_transform_description }, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../wine-9.3/dlls/d2d1/effect.c:296:41: note: (near initialization for 'builtin_effects[0].description') ../wine-9.3/dlls/d2d1/effect.c:297:46: error: initializer element is not constant { &CLSID_D2D13DPerspectiveTransform, _3d_perspective_transform_description},
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../wine-9.3/dlls/d2d1/effect.c:297:46: note: (near initialization for 'builtin_effects[1].description') ../wine-9.3/dlls/d2d1/effect.c:298:33: error: initializer element is not constant { &CLSID_D2D1Composite, composite_description }, ^~~~~~~~~~~~~~~~~~~~~ ../wine-9.3/dlls/d2d1/effect.c:298:33: note: (near initialization for 'builtin_effects[2].description') ../wine-9.3/dlls/d2d1/effect.c:299:28: error: initializer element is not constant { &CLSID_D2D1Crop, crop_description }, ^~~~~~~~~~~~~~~~ ../wine-9.3/dlls/d2d1/effect.c:299:28: note: (near initialization for 'builtin_effects[3].description') ../wine-9.3/dlls/d2d1/effect.c:300:30: error: initializer element is not constant { &CLSID_D2D1Shadow, shadow_description }, ^~~~~~~~~~~~~~~~~~ ../wine-9.3/dlls/d2d1/effect.c:300:30: note: (near initialization for 'builtin_effects[4].description') ../wine-9.3/dlls/d2d1/effect.c:301:33: error: initializer element is not constant { &CLSID_D2D1Grayscale, grayscale_description }, ^~~~~~~~~~~~~~~~~~~~~ ../wine-9.3/dlls/d2d1/effect.c:301:33: note: (near initialization for 'builtin_effects[5].description') Makefile:27950: recipe for target 'dlls/d2d1/i386-windows/effect.o' failed make: *** [dlls/d2d1/i386-windows/effect.o] Error 1
https://bugs.winehq.org/show_bug.cgi?id=56379
--- Comment #1 from Nikolay Sivov bunglehead@gmail.com --- What kind of tools are you using? Might be best to attach your config.log file.
https://bugs.winehq.org/show_bug.cgi?id=56379
--- Comment #2 from Dmitry Timoshkov dmitry@baikal.ru --- Created attachment 76125 --> https://bugs.winehq.org/attachment.cgi?id=76125 patch
Does the attached patch help?
https://bugs.winehq.org/show_bug.cgi?id=56379
--- Comment #3 from dofficialgman@gmail.com --- (In reply to Dmitry Timoshkov from comment #2)
Created attachment 76125 [details] patch
Does the attached patch help?
yes that fixes the build issue
https://bugs.winehq.org/show_bug.cgi?id=56379
--- Comment #4 from dofficialgman@gmail.com --- (In reply to Nikolay Sivov from comment #1)
What kind of tools are you using? Might be best to attach your config.log file.
ubuntu bionic amd64 with the ubuntu provided tooling (gcc/mingw/etc) configure args added were `--enable-archs=i386,x86_64`
https://bugs.winehq.org/show_bug.cgi?id=56379
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |d2d Regression SHA1| |167103114389c7f487f7d6aa398 | |f56abf9cc5572 Summary|d2d1 regression unable to |d2d1 unable to build |build after: | |https://gitlab.winehq.org/w | |ine/wine/-/commit/167103114 | |389c7f487f7d6aa398f56abf9cc | |5572 | Severity|normal |major Keywords| |patch, regression
https://bugs.winehq.org/show_bug.cgi?id=56379
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |354ddcb382f7dffe515fa72a961 | |b5910839b60dc Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #5 from Dmitry Timoshkov dmitry@baikal.ru --- Fixed by 354ddcb382f7dffe515fa72a961b5910839b60dc.
https://bugs.winehq.org/show_bug.cgi?id=56379
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 9.5.