[Bug 42067] New: Disney Universe doesn't scale gamescreen properly

https://bugs.winehq.org/show_bug.cgi?id=42067

Bug ID: 42067
           Summary: Disney Universe doesn't scale gamescreen properly
           Product: Wine
           Version: 1.7.25
          Hardware: x86
               URL: http://store.steampowered.com/app/316260/
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: b005ad6f905dc0051b17ea45b3690e0662e48481
      Distribution: ---

Created attachment 56559
  --> https://bugs.winehq.org/attachment.cgi?id=56559
terminal output

The game screen isn't stretched properly in Disney Universe (Steam).
Whatever screen resolution is selected in the video option menu, the actual
game screen doesn't fit the screen, it is always smaller than the selected
resolution.
This occurs both in fullscreen and virtual desktop mode.

Regression from 1.7.25:

commit b005ad6f905dc0051b17ea45b3690e0662e48481
Author: Henri Verbeet 
Date:   Thu Aug 21 09:55:55 2014 +0200

wined3d: Use rendertarget views for color output instead of surfaces.

The game screen is scaled properly with the previous commit.

The upcoming screenshots were taken in virtual desktop mode @1440x900 (my
native  screen resolution).

wine-2.0-rc3
Fedora 25
XFCE 4.12 (compositor disabled)
XOrg 1.19.0
OpenGL vendor string: NVIDIA Corporation
OpenGL renderer string: GeForce GT 730/PCIe/SSE2
OpenGL core profile version string: 4.5.0 NVIDIA 375.26

[Bug 42067] Disney Universe doesn't scale gamescreen properly

https://bugs.winehq.org/show_bug.cgi?id=42067

--- Comment #1 from Béla Gyebrószki  ---
Created attachment 56560
  --> https://bugs.winehq.org/attachment.cgi?id=56560
menu screen before the regression

[Bug 42067] Disney Universe doesn't scale gamescreen properly

https://bugs.winehq.org/show_bug.cgi?id=42067

--- Comment #2 from Béla Gyebrószki  ---
Created attachment 56561
  --> https://bugs.winehq.org/attachment.cgi?id=56561
the menu screen in current Wine

[Bug 42067] Disney Universe doesn't scale gamescreen properly

https://bugs.winehq.org/show_bug.cgi?id=42067

--- Comment #3 from Béla Gyebrószki  ---
Created attachment 56562
  --> https://bugs.winehq.org/attachment.cgi?id=56562
gameplay (good)

[Bug 42067] Disney Universe doesn't scale gamescreen properly

https://bugs.winehq.org/show_bug.cgi?id=42067

--- Comment #4 from Béla Gyebrószki  ---
Created attachment 56563
  --> https://bugs.winehq.org/attachment.cgi?id=56563
gameplay (current)

[Bug 42067] Disney Universe doesn't scale gamescreen properly

https://bugs.winehq.org/show_bug.cgi?id=42067

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Józef Kucia  ---
Created attachment 56704
  --> https://bugs.winehq.org/attachment.cgi?id=56704
Hack

The source of the problem is "wined3d_rendertarget_view" cached in
"d3d9_surface". The "width" and "height" fields in "wined3d_rendertarget_view"
are not updated after the "Reset()" call.

The attached hack fixes the problem. I'm not sure how we want to fix this.

[Bug 42067] Disney Universe doesn't scale gamescreen properly

https://bugs.winehq.org/show_bug.cgi?id=42067

--- Comment #6 from Béla Gyebrószki  ---
(In reply to Józef Kucia from comment #5)
> Created attachment 56704 [details]
> Hack
>
> The source of the problem is "wined3d_rendertarget_view" cached in
> "d3d9_surface". The "width" and "height" fields in
> "wined3d_rendertarget_view" are not updated after the "Reset()" call.
>
> The attached hack fixes the problem. I'm not sure how we want to fix this.

The patch works here as well.

[Bug 42067] Disney Universe doesn't scale gamescreen properly

https://bugs.winehq.org/show_bug.cgi?id=42067

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 42067] Disney Universe doesn't scale gamescreen properly

https://bugs.winehq.org/show_bug.cgi?id=42067

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56704|0                           |1
        is obsolete|                            |

--- Comment #7 from Józef Kucia  ---
Created attachment 56728
  --> https://bugs.winehq.org/attachment.cgi?id=56728
Patch

This patch is a more proper fix.

[Bug 42067] Disney Universe doesn't scale gamescreen properly

https://bugs.winehq.org/show_bug.cgi?id=42067

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |e8360b8eaa802c8854cf357479f
                   |                            |33b7e3d4b4dfe
         Resolution|---                         |FIXED

--- Comment #8 from Józef Kucia  ---
Fixed with commit e8360b8eaa802c8854cf357479f33b7e3d4b4dfe
http://source.winehq.org/git/wine.git/?a=commit;h=e8360b8eaa802c8854cf357479...

[Bug 42067] Disney Universe doesn't scale gamescreen properly

https://bugs.winehq.org/show_bug.cgi?id=42067

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 2.0-rc5.