[Bug 16684] New: cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

Summary: cnsconf.exe fails to start, fixup error
           Product: Wine
           Version: 1.1.11
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P1
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=18334)
 --> (http://bugs.winehq.org/attachment.cgi?id=18334)
cnsconf details

Trying to launch the program cnsconf.exe wine report a fixup error message,
please see attach file for details.

[Bug 16684] cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

--- Comment #1 from Andrew Nguyen   2008-12-30 16:01:40 ---
Is there a download or demo available for this program? And looking at your log
snippet, have you overridden any DLLs?

[Bug 16684] cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |normal

--- Comment #2 from Jeff Zaroyko   2008-12-30 17:44:48 ---
definitely not a blocker, read the severity details:
http://bugs.winehq.org/page.cgi?id=fields.html#bug_severity

[Bug 16684] cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P2

[Bug 16684] cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

--- Comment #3 from Dmitry Timoshkov   2009-01-04 03:53:50 ---
Remove ~/.wine and try again *without* any native dlls.

[Bug 16684] cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

--- Comment #4 from Eduardo Silva   2009-01-28 08:16:59 ---
Please find the program here:

http://conference.oracle.com/imtapp/res/jar/cnsconf_en.cab

(need to extract the cab to find the .exe file)

[Bug 16684] cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

--- Comment #5 from Eduardo Silva   2009-01-28 08:34:21 ---
Official public installer:

https://conference.oracle.com/imtapp/app/nuf_sys.uix

[Bug 16684] cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

Eduardo Silva  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://conference.oracle.co
                   |                            |m/imtapp/app/nuf_sys.uix
           Severity|normal                      |critical
           Platform|Other                       |All
            Version|1.1.11                      |1.1.13

[Bug 16684] cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
           Platform|All                         |Other
            Version|1.1.13                      |1.1.11

[Bug 16684] cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 16684] cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #6 from Louis Lenders   2009-08-16 10:55:13 ---
Tried the official installer from comment #5. Multiple problems encountered.
The installer only finishes fine after doing 'winetricks msxml3'. Running
cnsconf.exe just reteurns to the console silently. Running it the second time
it crashes into an unimplemented function in ntoskrnl.exe, after that it exits
again silently. A +reley log showed:

0009:Call shlwapi.StrCpyNW(0017fc88,00000000,00000104) ret=004306b2
0009:trace:seh:raise_exception code=c0000005 flags=0 addr=0x7ee58f4f
ip=7ee58f4f tid=0009
0009:trace:seh:raise_exception  info[0]=00000000
.
.
.
0009:Call KERNEL32.CreateFileA(0045c3c0 "C:\users\louis\Local
Se.ttings\Application Data\Oracle\RTC
Client\crash-(null)-2009-08-16.log",c0000000,00000000,00000000,00000002,80000000,00000000)
ret=00431aef
0009:Ret  KERNEL32.CreateFileA() retval=000000c8 ret=00431aef

With native shlwapi at least the gui shows up, though it complains it cannot
connect to the server.

Patch/hack below fixes the problem:

diff --git a/dlls/shlwapi/string.c b/dlls/shlwapi/string.c
index 755360d..694a696 100644
--- a/dlls/shlwapi/string.c
+++ b/dlls/shlwapi/string.c
@@ -498,7 +498,7 @@ LPWSTR WINAPI StrCpyW(LPWSTR lpszStr, LPCWSTR lpszSrc)
 LPWSTR WINAPI StrCpyNW(LPWSTR lpszStr, LPCWSTR lpszSrc, int iLen)
 {
   TRACE("(%p,%s,%i)\n", lpszStr, debugstr_w(lpszSrc), iLen);
-
+  if(!lpszSrc) return 0;
   lstrcpynW(lpszStr, lpszSrc, iLen);
   return lpszStr;
 }

For now I suggest to make this bug about the shlwapi problem.

[Bug 16684] cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

--- Comment #7 from Louis Lenders   2009-08-23 16:29:26 ---
Created an attachment (id=23230)
 --> (http://bugs.winehq.org/attachment.cgi?id=23230)
test some cornercases of StrCpyNW, +patch

This patch fixes the bug, however i'm not 100% sure i did the tests 100% right,
maybe someone could have a quick look

[Bug 16684] cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |shlwapi

[Bug 16684] cnsconf.exe fails to start

http://bugs.winehq.org/show_bug.cgi?id=16684

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|cnsconf.exe fails to start, |cnsconf.exe fails to start
                   |fixup error                 |

--- Comment #8 from Louis Lenders   2009-08-29 06:35:27 ---
I sent a patch. Also corrected title of bug.

[Bug 16684] cnsconf.exe fails to start

http://bugs.winehq.org/show_bug.cgi?id=16684

--- Comment #9 from Louis Lenders   2009-09-02 05:26:26 ---
Sent in the patch here
http://www.winehq.org/pipermail/wine-patches/attachments/20090829/2c4195dd/a...
, but got no response whatsoever; looks like another waste of time again.

[Bug 16684] cnsconf.exe fails to start

http://bugs.winehq.org/show_bug.cgi?id=16684

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Hans Leidekker   2009-09-02 06:46:15 ---
+      if(lpszSrc)
+        lstrcpynW(lpszStr, lpszSrc, iLen);
+      else
+        *lpszStr = '\0';
+    }

It would be cleaner to copy the relevant part of lstrcpynW and
make it deal with a NULL src buffer.

[Bug 16684] cnsconf.exe fails to start

http://bugs.winehq.org/show_bug.cgi?id=16684

--- Comment #11 from Louis Lenders   2009-09-04 11:11:23 ---
(In reply to comment #10)
> -
>  if(lpszSrc)
> -
>    lstrcpynW(lpszStr, lpszSrc, iLen);
> -
>  else
> -
>    *lpszStr = '\0';
> - }
>
> It would be cleaner to copy the relevant part of lstrcpynW and
> make it deal with a NULL src buffer.

i'm not sure what you mean, you mean copy the whole part of code from lstrcpynw
from kernel32? Anyway, maybe i resend the tests, but as for the fix i'll leave
that to someone else

[Bug 16684] cnsconf.exe fails to start

http://bugs.winehq.org/show_bug.cgi?id=16684

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 16684] cnsconf.exe fails to start

http://bugs.winehq.org/show_bug.cgi?id=16684

--- Comment #12 from Hans Leidekker   2009-09-04 12:33:56 ---
> i'm not sure what you mean, you mean copy the whole part of code
> from lstrcpynw from kernel32?

Yes, I would copy the implementation from kernel32. The exception
handler is probably not needed, but that could use a another test
case.

[Bug 16684] cnsconf.exe fails to start

http://bugs.winehq.org/show_bug.cgi?id=16684

--- Comment #13 from Nikolay Sivov   2010-01-30 16:47:10 ---
Louis, don't you mind to update and resend a patch? I you don't have time for
it please let me know, I'll do it.

[Bug 16684] cnsconf.exe fails to start

http://bugs.winehq.org/show_bug.cgi?id=16684

--- Comment #14 from Louis Lenders   2010-01-31 08:50:15 ---
(In reply to comment #13)
> Louis, don't you mind to update and resend a patch? I you don't have time for
> it please let me know, I'll do it.

Hi Nicolai, go ahead. Last month and for the next month i'm rather busy and
don't have time to do wine-stuff :(

[Bug 16684] cnsconf.exe fails to start

http://bugs.winehq.org/show_bug.cgi?id=16684

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #15 from Nikolay Sivov   2010-03-18 11:36:10 ---
shlwapi bug is fixed by 93b3ba76f6874cef44fbf4a8aa62afbe0b86b97f.
Use Wine from git repo (or 1.1.41 when it's ready) to report next problems.

[Bug 16684] cnsconf.exe fails to start

http://bugs.winehq.org/show_bug.cgi?id=16684

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard   2010-03-19 14:10:19 ---
Closing bugs fixed in 1.1.41.