[Bug 17166] New: Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

Summary: Implement BiDi mirroring
           Product: Wine
           Version: unspecified
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The current BiDi implementation doesn't implement mirroing of bidi_mirrored
chars. The attached patch implements it.

[Bug 17166] Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

Khaled Hosny  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |609

[Bug 17166] Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

Shachar Shemesh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #1 from Shachar Shemesh   2009-01-28 07:04:17 ---
You did not attach a patch

[Bug 17166] Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

Yoav HaCohen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 17166] Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

--- Comment #2 from Khaled Hosny   2009-01-28 08:08:49 ---
Created an attachment (id=19048)
 --> (http://bugs.winehq.org/attachment.cgi?id=19048)
Implement BiDi mirroring

[Bug 17166] Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

--- Comment #3 from Khaled Hosny   2009-01-28 08:10:16 ---
I attached it while submitting the bug (or so I thought), re-attached it.

[Bug 17166] Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #4 from Austin English   2009-01-28 09:37:09 ---
Please send patches to [e-mail]

[Bug 17166] Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

--- Comment #5 from Khaled Hosny   2009-01-28 12:51:20 ---
(In reply to comment #4)
> Please send patches to [e-mail]

I did already.

[Bug 17166] Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 17166] Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

Ebrahim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Ebrahim   2009-09-09 19:06:45 ---
A question/suggestion about the provided patch: isn't a switch/case faster than
iterating through a list for each character?

[Bug 17166] Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

haytham-med  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 17166] Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

Aric Stewart  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Aric Stewart   2010-05-07 10:35:44 ---
Thanks to Alexandre, BiDi mirroring is now implemented in usp10.  It is not yet
migrated over to base gdi yet.  but it means that apps that use uniscribe (such
as Internet Explorer 7) should properly mirror glyphs.

[Bug 17166] Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

Aric Stewart  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Aric Stewart   2010-05-13 13:28:02 ---
GDI should now use the usp10 functions to generate glyphs.

This means that mirroring should be properly reflected in gdi strings as well.

[Bug 17166] Implement BiDi mirroring

http://bugs.winehq.org/show_bug.cgi?id=17166

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard   2010-05-21 14:39:11 ---
Closing bugs fixed in 1.2-rc1.