[Bug 16750] New: ntdll/tests/rtlbitmap.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16750

Summary: ntdll/tests/rtlbitmap.c: comparison is always false due
                    to limited range of data type
           Product: Wine
           Version: 1.1.12
          Platform: Macintosh
        OS/Version: Linux
            Status: NEW
          Keywords: source
          Severity: minor
          Priority: P2
         Component: build-env
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

gcc -c -I. -I. -I../../../include -I../../../include   -D_REENTRANT -fPIC -Wall
-pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings
-Wtype-limits -Wpointer-arith  -g -O2  -o rtlbitmap.o rtlbitmap.c
rtlbitmap.c: In function ‘test_RtlFindMostSignificantBit’:
rtlbitmap.c:439: warning: comparison is always false due to limited range of
data type
rtlbitmap.c: In function ‘test_RtlFindLeastSignificantBit’:
rtlbitmap.c:466: warning: comparison is always false due to limited range of
data type

[Bug 16750] ntdll/tests/rtlbitmap.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16750

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #1 from Austin English   2009-01-10 01:54:44 ---
This patch fixes it. Haven't tested windows yet, so holding off on sending in.
Comments welcome.

diff --git a/dlls/ntdll/tests/rtlbitmap.c b/dlls/ntdll/tests/rtlbitmap.c
index fc7f6c5..d24f0af 100644
--- a/dlls/ntdll/tests/rtlbitmap.c
+++ b/dlls/ntdll/tests/rtlbitmap.c
@@ -413,7 +413,7 @@ static void test_RtlFindClearBitsAndSet(void)
 static void test_RtlFindMostSignificantBit(void)
 {
   int i;
-  CCHAR cPos;
+  signed char cPos;
   ULONGLONG ulLong;

if (!pRtlFindMostSignificantBit)
@@ -442,7 +442,7 @@ static void test_RtlFindMostSignificantBit(void)
 static void test_RtlFindLeastSignificantBit(void)
 {
   int i;
-  CCHAR cPos;
+  signed char cPos;
   ULONGLONG ulLong;

if (!pRtlFindLeastSignificantBit)

[Bug 16750] ntdll/tests/rtlbitmap.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16750

--- Comment #2 from Austin English   2009-08-30 15:07:56 ---
Patch sent:
http://www.winehq.org/pipermail/wine-patches/2009-August/077923.html

[Bug 16750] ntdll/tests/rtlbitmap.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16750

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|Macintosh                   |ppc32

[Bug 16750] ntdll/tests/rtlbitmap.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16750

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Nikolay Sivov   2010-01-09 08:52:33 ---
This is fixed by e88e2239aac0f7e389f805d7dd4be6bb17b0fc1f about 4 months ago.

[Bug 16750] ntdll/tests/rtlbitmap.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16750

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard   2010-01-22 11:01:58 ---
Closing bugs fixed in 1.1.37.