[Bug 21144] New: cmd missing newline in output?

http://bugs.winehq.org/show_bug.cgi?id=21144

Summary: cmd missing newline in output?
           Product: Wine
           Version: 1.1.35
          Platform: x86
               URL: http://kegel.com/wine/cmdtest.tar.gz
        OS/Version: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Even with Austin's recent patch
http://www.winehq.org/pipermail/wine-patches/2009-December/083144.html
applied, doing
  wget http://kegel.com/wine/cmdtest.tar.gz
  tar -xzvf cmdtest.tar.gz
  cd cmdtest
  sh cmdtest.sh
shows that our cmd is missing a newline in its output:
@@ -1,35 +1,22 @@
-
-C:\fake>rem Easy cmd tests 
-
...
+C:\fake>rem Easy cmd tests

Looks like it needs to output another CRLF after the end of output of any
command?

[Bug 21144] cmd missing newline in output?

http://bugs.winehq.org/show_bug.cgi?id=21144

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Austin English   2009-12-23 19:53:13 ---
Not all commands get newlines. See
http://winezeug.googlecode.com/svn/trunk/appinstall/scripts/cmd.ahk. For
example, 'echo on/off' should give no output at all. 'echo |' gives similar
behavior. I'm sure there are others...

[Bug 21144] cmd missing newline in output?

http://bugs.winehq.org/show_bug.cgi?id=21144

--- Comment #2 from Dan Kegel   2009-12-25 09:35:05 ---
Running with @echo off gets rid of the problem.
I guess the command echoing code prints an extra 
newline before each command being echoed.  Maybe
changing WCMD_show_prompt like this would do the trick?
(I'd try it but I'm on a netbook...)

327   q = out_string;
+ *q++ = '\r';
+ *q++ = '\n';
 328   *q = '\0';

[Bug 21144] cmd missing newline in output?

http://bugs.winehq.org/show_bug.cgi?id=21144

--- Comment #3 from Austin English   2009-12-29 04:09:19 ---
(In reply to comment #2)
> Running with @echo off gets rid of the problem.
> I guess the command echoing code prints an extra 
> newline before each command being echoed.  Maybe
> changing WCMD_show_prompt like this would do the trick?
> (I'd try it but I'm on a netbook...)
>
> 327   q = out_string;
> - *q++ = '\r';
> - *q++ = '\n';
>
> 328   *q = '\0';

Still fails 2 tests.

[Bug 21144] cmd missing newline in output?

http://bugs.winehq.org/show_bug.cgi?id=21144

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|programs                    |cmd

[Bug 21144] cmd missing newline in output?

http://bugs.winehq.org/show_bug.cgi?id=21144

Jason Edmeades  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Jason Edmeades   2010-01-06 18:26:41 ---
Adding myself to the cmd bugs

[Bug 21144] cmd missing newline in output?

http://bugs.winehq.org/show_bug.cgi?id=21144

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Frédéric Delanoy  2011-07-20 14:16:48 CDT ---
(In reply to comment #2)
> Running with @echo off gets rid of the problem.
> I guess the command echoing code prints an extra 
> newline before each command being echoed.  Maybe
> changing WCMD_show_prompt like this would do the trick?
> (I'd try it but I'm on a netbook...)
>
> 327   q = out_string;
> - *q++ = '\r';
> - *q++ = '\n';
>
> 328   *q = '\0';

Can you please retry in current wine? I've added some changes regarded newlines
recently.

[Bug 21144] cmd missing newline in output?

http://bugs.winehq.org/show_bug.cgi?id=21144

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Dan Kegel  2011-10-03 09:16:06 CDT ---
Probably fixed, thanks.

[Bug 21144] cmd missing newline in output?

http://bugs.winehq.org/show_bug.cgi?id=21144

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2011-10-10 13:14:17 CDT ---
Closing bugs fixed in 1.3.30.