[Bug 56785] New: Spider-Man: Shattered Dimensions crashes in the title screen after a few seconds

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56785

Bug ID: 56785
           Summary: Spider-Man: Shattered Dimensions crashes in the title
                    screen after a few seconds
           Product: vkd3d
           Version: 1.12
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: hlsl
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 76590
  --> https://bugs.winehq.org/attachment.cgi?id=76590
Shader dumped by VKD3D_SHADER_DUMP_PATH

Like the title says, after spending a few seconds in the title screen,
Spider-Man: Shattered Dimensions crashes, with the following logs:
```
017c:err:d3dcompiler:D3DCompile2 Failed to compile shader, vkd3d result -4.
017c:err:d3dcompiler:D3DCompile2 Shader log:
017c:err:d3dcompiler:D3DCompile2     <anonymous>:146:1: W5302: Ignoring unknown
attribute "optimizeAutoZ".
017c:err:d3dcompiler:D3DCompile2     <anonymous>:121:14: E5016: Overlapping
register() reservations on 'c27'.
017c:err:d3dcompiler:D3DCompile2 
```

This is a regression: it didn't happen on vkd3d 1.11 (Wine 9.9).

[Bug 56785] Spider-Man: Shattered Dimensions crashes in the title screen after a few seconds

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56785

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Nikolay Sivov  ---
Thank you for the report. According to my testing it happened between 1.10 and
1.11, and the problem is this:

13f713f74bdd3ab3650cbe72a7db2e872ab41cdf is the first bad commit
commit 13f713f74bdd3ab3650cbe72a7db2e872ab41cdf
Author: Francisco Casas 
Date:   Wed Nov 8 18:45:26 2023 -0300

vkd3d-shader/hlsl: Turn register(cX) reservations into buffer offset for
SM4.

libs/vkd3d-shader/hlsl_codegen.c                   | 96 ++++++++++++++--------
 .../hlsl/register-reservations-numeric.shader_test | 10 +--
 2 files changed, 67 insertions(+), 39 deletions(-)

[Bug 56785] Spider-Man: Shattered Dimensions crashes in the title screen after a few seconds

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56785

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |13f713f74bdd3ab3650cbe72a7d
                   |                            |b2e872ab41cdf
           Keywords|                            |regression

[Bug 56785] Spider-Man: Shattered Dimensions crashes in the title screen after a few seconds

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56785

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|13f713f74bdd3ab3650cbe72a7d |657e460d11a08fabce2b412de0f
                   |b2e872ab41cdf               |88a4c34a201f8

--- Comment #2 from Nikolay Sivov  ---
Sorry, I used ps_4_0 for testing, while I should have used ps_3_0. The
regression is indeed between 1.11 and 1.12. Correct bad commit is:

657e460d11a08fabce2b412de0f88a4c34a201f8 is the first bad commit
commit 657e460d11a08fabce2b412de0f88a4c34a201f8
Author: Francisco Casas 
Date:   Fri May 3 19:32:52 2024 -0400

vkd3d-shader/hlsl: Allocate unused variables with register reservations on
SM1.

libs/vkd3d-shader/d3dbc.c                   | 6 +++---
 libs/vkd3d-shader/hlsl_codegen.c            | 2 +-
 tests/hlsl/sm1-const-allocation.shader_test | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

[Bug 56785] Spider-Man: Shattered Dimensions crashes in the title screen after a few seconds

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56785

Francisco Casas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Francisco Casas  ---
This should be fixed by:

https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/912

[Bug 56785] Spider-Man: Shattered Dimensions crashes in the title screen after a few seconds

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56785

--- Comment #4 from [e-mail] ---
Tested the patch, it fixes the issue. The game doesn't crash anymore on the
title screen.

The game will still crash after starting a level (unimplemented SM1 non-float
expression and Dereference with non-constant offset of type HLSL_IR_EXPR), but
that's another issue, and isn't a regression.

[Bug 56785] Spider-Man: Shattered Dimensions crashes in the title screen after a few seconds

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56785

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |597e55691a818a02353b59015e2
                   |                            |0d382049befc1
         Resolution|---                         |FIXED

--- Comment #5 from Henri Verbeet  ---
Reported fixed by commit 597e55691a818a02353b59015e20d382049befc1.

[Bug 56785] Spider-Man: Shattered Dimensions crashes in the title screen after a few seconds

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56785

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Nikolay Sivov  ---
Closing bugs fixed in 1.14.