http://bugs.winehq.org/show_bug.cgi?id=21426
Summary: Regression in Fallout Tactics Product: Wine Version: 1.1.36 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: techtonik@gmail.com
Fallout Tactics was working in 1.1.35 in full screen mode. It is not longer true for 1.1.36.
Ubuntu 9.10
Unfortunately, I am unable to provide regression tests as git misbehaves with my externally attached storage, and can't switch between branches as git constantly complains about lots of local modifications no matter which revert way I use.
http://bugs.winehq.org/show_bug.cgi?id=21426
--- Comment #1 from Austin English austinenglish@gmail.com 2010-01-20 03:22:21 --- So put a copy of git on a local mount point...
Have you filed a bug with git?
http://bugs.winehq.org/show_bug.cgi?id=21426
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Summary|Regression in Fallout |Fallout Tactics doesn't |Tactics |work anymore
--- Comment #2 from Dmitry Timoshkov dmitry@codeweavers.com 2010-01-20 03:22:58 --- The regression test is still required, otherwise you need find someone who will do it for you.
http://bugs.winehq.org/show_bug.cgi?id=21426
techtonik@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|regression | Summary|Fallout Tactics doesn't |Regression in Fallout |work anymore |Tactics
--- Comment #3 from techtonik@gmail.com 2010-01-20 03:23:35 --- The error message is classic from #15000
C:\dev\phoenix\display\win32\win32_window.cpp(873): **fatal error**: Could not create display buffers
http://bugs.winehq.org/show_bug.cgi?id=21426
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Summary|Regression in Fallout |Fallout Tactics no longer |Tactics |works
http://bugs.winehq.org/show_bug.cgi?id=21426
techtonik@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|regression | Summary|Fallout Tactics no longer |Regression in Fallout |works |Tactics
--- Comment #4 from techtonik@gmail.com 2010-01-20 03:47:13 --- (In reply to comment #1)
So put a copy of git on a local mount point...
It is local mount point, but with different file structure (FAT32 or NTFS, but not ext3 definitely). I can't put it somewhere else, to ext3 or something.
Have you filed a bug with git?
No. I've browsed git site a bit, but couldn't find a link to its bug tracker. In addition I am not sure I use the right "revert" command. I've tried "git checkout", "git checkout master", "git reset --hard HEAD" and a couple of others. I didn't dare to ask mailing list to get the answer from http://importantshock.wordpress.com/2008/08/07/git-vs-mercurial/ =)
In any case I did't have any more time to play with Linux, so I just reported this fact, so it won't be lost. It would be nice if somebody can do regression testing, because I will unlikely to have more time for next try to recompile wines until next release.
http://bugs.winehq.org/show_bug.cgi?id=21426
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Summary|Regression in Fallout |Fallout Tactics no longer |Tactics |works
--- Comment #5 from Dmitry Timoshkov dmitry@codeweavers.com 2010-01-20 04:20:31 --- Please stop changing summary and keywords fields.
http://bugs.winehq.org/show_bug.cgi?id=21426
--- Comment #6 from techtonik@gmail.com 2010-01-20 05:28:04 --- I am sorry. Bugzilla changed back all form fields automatically, because the form was opened before your edits. It displayed a warning that some comments were added in the meanwhile, but I failed to notice what else was wrong in a hurry.
http://bugs.winehq.org/show_bug.cgi?id=21426
Bartosz Brachaczek b.brachaczek@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |b.brachaczek@gmail.com, | |hverbeet@gmail.com
--- Comment #7 from Bartosz Brachaczek b.brachaczek@gmail.com 2010-01-25 19:02:08 --- AFAIK, it's the third time a regression causes Fallout Tactics not to start in fullscreen. Really strange bug.
First commit that caused a regression between 0.9.30 and 0.9.31 was (according to http://www.winehq.org/pipermail/wine-devel/2007-February/054251.html):
commit 388499ff28616ef03bf8949a78e658e1bdb4e4fc Author: Stefan Dösinger stefan@codeweavers.com Date: Wed Feb 14 17:59:08 2007 +0100
wined3d: More fullscreen window fixes.
Then, it's been silently fixed in some unknown commit (some time ago I did a regression test to find it out but now I can't find those results - if it'd be helpful, I can redo this).
Second time regression between 1.1.2 and 1.1.3 affects Fallout Tactics (bug #15000):
commit 34b37fe2411d83f1a6f3e11a7a1e4d28bd9b36ba Author: Stefan Dösinger stefan@codeweavers.com Date: Tue Aug 5 14:24:10 2008 -0500
d3d: Remove IWineD3DDevice::SetHwnd.
It's been fixed between 1.1.34 and 1.1.35 in the following commit:
commit c24e48d937cfd0000a22af555a920ea7fab71d7b Author: Henri Verbeet hverbeet@codeweavers.com Date: Mon Dec 14 20:49:53 2009 +0100
wined3d: Filter window messages generated by switching to fullscreen and back.
But hit again between 1.1.35 and 1.1.36 in this commit:
commit b49e684f5d2447171589acccb37ffee81ffffbe2 Author: Henri Verbeet hverbeet@codeweavers.com Date: Tue Dec 22 18:32:14 2009 +0100
wined3d: Focus the focus window.
Adding Henri Verbeet to CC.
http://bugs.winehq.org/show_bug.cgi?id=21426
--- Comment #8 from Bartosz Brachaczek b.brachaczek@gmail.com 2010-01-25 19:16:46 --- (In reply to comment #7)
But hit again between 1.1.35 and 1.1.36 in this commit:
commit b49e684f5d2447171589acccb37ffee81ffffbe2 Author: Henri Verbeet hverbeet@codeweavers.com Date: Tue Dec 22 18:32:14 2009 +0100
wined3d: Focus the focus window.
Oh, don't know if it's an useful information, but forgot to say that the line that actually causes the game not to start is the one from the first chunk (i.e., SetFocus() call). Removing the SetFocus() call make the game start, but it crashes immediately when I click a mouse button (it worked just fine when I reverted the whole commit).
The bug is still present in current git (f27b032d50b720abae8a971e3eeac382f132d38b).
http://bugs.winehq.org/show_bug.cgi?id=21426
--- Comment #9 from Henri Verbeet hverbeet@gmail.com 2010-01-26 07:37:31 --- (In reply to comment #7)
AFAIK, it's the third time a regression causes Fallout Tactics not to start in fullscreen. Really strange bug.
That probably just means it's one of those applications that's sensitive to the exact sequence of window messages sent during Direct3D setup. Do you happen to know if this game uses ddraw or d3d8/d3d9? Running with WINEDEBUG="+ddraw,+d3d8,+d3d9" might help if you don't know. Does this game have a demo with the same issue?
http://bugs.winehq.org/show_bug.cgi?id=21426
--- Comment #10 from Bartosz Brachaczek b.brachaczek@gmail.com 2010-01-26 11:59:45 --- Thanks for reply. This game uses ddraw. Demo version is also affected. You can download it here: http://download.cnet.com/Fallout-Tactics-Brotherhood-of-Steel-demo/3000-7564... (could someone add 'download' keyword to this bug?).
http://bugs.winehq.org/show_bug.cgi?id=21426
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://download.cnet.com/Fa | |llout-Tactics-Brotherhood-o | |f-Steel-demo/3000-7564_4-43 | |88146.html
http://bugs.winehq.org/show_bug.cgi?id=21426
hadack@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hadack@gmx.de
--- Comment #11 from hadack@gmx.de 2010-02-06 09:58:10 --- Changing DirectDrawRenderer to gdi in the registry makes the game work again.
http://bugs.winehq.org/show_bug.cgi?id=21426
hadack@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #12 from hadack@gmx.de 2010-02-06 09:58:30 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=21426
--- Comment #13 from Henri Verbeet hverbeet@gmail.com 2010-03-16 13:23:22 --- Created an attachment (id=26843) --> (http://bugs.winehq.org/attachment.cgi?id=26843) patch
Does this patch help?
http://bugs.winehq.org/show_bug.cgi?id=21426
--- Comment #14 from Bartosz Brachaczek b.brachaczek@gmail.com 2010-03-16 17:05:12 --- (In reply to comment #13)
Created an attachment (id=26843)
--> (http://bugs.winehq.org/attachment.cgi?id=26843) [details]
patch
Does this patch help?
Yes, it works like a charm. Thanks a lot!
http://bugs.winehq.org/show_bug.cgi?id=21426
--- Comment #15 from Henri Verbeet hverbeet@gmail.com 2010-03-18 12:00:47 --- Should be fixed by 914c8cb8ea1e5cbcfa18558961185dd94313b26d.
http://bugs.winehq.org/show_bug.cgi?id=21426
--- Comment #16 from Bartosz Brachaczek b.brachaczek@gmail.com 2010-03-19 07:47:45 --- Confirming, this is fixed in current git. Thanks.
http://bugs.winehq.org/show_bug.cgi?id=21426
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #17 from Dmitry Timoshkov dmitry@codeweavers.com 2010-03-19 09:24:42 --- Reported fixed.
http://bugs.winehq.org/show_bug.cgi?id=21426
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #18 from Alexandre Julliard julliard@winehq.org 2010-03-19 14:10:50 --- Closing bugs fixed in 1.1.41.
-
wine-bugs＠winehq.org