[Bug 13137] New: IE6 crashes due to unimplemented function wininet.dll. GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

Summary: IE6 crashes due to unimplemented function
                    wininet.dll.GetDiskInfoA
           Product: Wine
           Version: 1.0-rc1
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: wininet
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=12940)
 --> (http://bugs.winehq.org/attachment.cgi?id=12940)
Crash-when-trying-to-set-Temporary-Internet-Files-settings-in-ie6_related_to_wininet_wine-1.0-rc1

When trying to change the settings for the "Temporary Internet Files", IE6
crashes. See the attachment for more information.

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll. GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

--- Comment #1 from Jon Griffiths   2008-06-01 20:53:22 ---
Created an attachment (id=13569)
 --> (http://bugs.winehq.org/attachment.cgi?id=13569)
Implement GetDiskInfoA, with tests

Can you apply the attached patch and try again?

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

--- Comment #2 from Eddie Lania   2008-06-02 09:57:40 ---
(In reply to comment #1)
> Created an attachment (id=13569)

--> (http://bugs.winehq.org/attachment.cgi?id=13569) [details]
> Implement GetDiskInfoA, with tests
>
> Can you apply the attached patch and try again?

For which version of wine is this patch created?

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, testcase

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

Jon Griffiths  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Jon Griffiths   2008-06-02 12:17:38 ---

Its against 1.0-rc3, but it should apply to any recent-ish Wine (try patch
--dry-run if you need to test it). This assumes you're building from source of
course...

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

--- Comment #4 from Eddie Lania   2008-06-02 13:56:10 ---
Test result:

When opening de "Temporary Internet Files" settings there is no crash anymore
in Iexplore. This part seems to be solved now. But the amount of disk space to
be used cannot be set: "Please select a value between 1 and 0 for how much disk
space    temporary internet files may use" is being displayed, no matter what
amount is being filled in.

Also, when hitting the "Delete Files" button and trying to delete the temporary
internet files iexplore crashes with another unimplemeted function:

wine: Unimplemented function wininet.dll.FreeUrlCacheSpaceA called at address
0x7b842180 (thread 0009), starting debugger...

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

--- Comment #5 from Eddie Lania   2008-06-02 13:59:49 ---
Created an attachment (id=13579)
 --> (http://bugs.winehq.org/attachment.cgi?id=13579)
Crash log when deleteing temporary internet files in ie6

Crash log when deleteing temporary internet files in ie6 on wine-1.0 rc3.

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

--- Comment #6 from Jon Griffiths   2008-06-02 16:17:58 ---
> When opening de "Temporary Internet Files" settings there is no crash anymore
> in Iexplore. This part seems to be solved now. But the amount of disk space to
> be used cannot be set: "Please select a value between 1 and 0 for how much disk
> space    temporary internet files may use" is being displayed, no matter what
> amount is being filled in.

Hmm, can you run with WINEDEBUG="+wininet", open the dialog, then shut down and
attach the log here?
> Also, when hitting the "Delete Files" button and trying to delete the temporary
> internet files iexplore crashes with another unimplemeted function:
>
> wine: Unimplemented function wininet.dll.FreeUrlCacheSpaceA called at address
> 0x7b842180 (thread 0009), starting debugger...

Ok, please raise another bug for this, CC: me on it, and and I'll have a go at
implementing it.

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

Jaime Rave  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Jaime Rave   2008-06-02 18:09:19 ---
Hi Jon, could you please take a look on bug 12447, is also related to wininet.
I would apreciate your help. Thanks.

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

--- Comment #8 from Jon Griffiths   2008-06-02 18:47:13 ---
(In reply to comment #7)
> Hi Jon, could you please take a look on bug 12447, is also related to wininet.
> I would apreciate your help. Thanks.

Jaime,

It looks like there's already people looking at that bug for you.
> From the log, it seems URLCache_CopyEntry is crashing on an invalid string. If

you re-run the program under winedbg, then once it crashes, type:

frame 3 <ENTER>
list <ENTER>

it should show the line of code in urlcache.c thats failing. If you
attach/paste that into the bug, one of the guys looking at it will be a bit
closer to figuring out the problem. The two issues aren't related though, so
please keep this bug separate.

Cheers
Jon

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

--- Comment #9 from Jon Griffiths   2008-06-03 05:47:50 ---
(In reply to comment #6)
> Ok, please raise another bug for this, CC: me on it, and and I'll have a go at
> implementing it.

I've raised http://bugs.winehq.org/show_bug.cgi?id=13630 for this.

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

--- Comment #10 from Eddie Lania   2008-06-03 10:05:51 ---
Created an attachment (id=13623)
 --> (http://bugs.winehq.org/attachment.cgi?id=13623)
Debug log per as requested.

ran with WINEDEBUG="+wininet", opened the dialog, then shutted down and
attached the log here.

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

Eddie Lania  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |ABANDONED

--- Comment #11 from Eddie Lania   2008-06-04 10:12:59 ---
I'd like to file no more bugs to wine anymore because I don't like the way
Vitaliy Margolen is treating me.

Can I unregister my e-mail address from wine somewhere?

Eddie.

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

--- Comment #12 from Jon Griffiths   2008-06-05 07:35:22 ---
Eddie,

I don't think Vitaliy is deliberately being rude (at least, I hope not!). Its
more than likely that English isn't his first language and he doesn't realise
quite how aggressive he comes across.

I suspect that its a little frustrating administrating bugzilla - and in this
case its a volunteer effort, which I appreciate. Since it seems to be the
policy that bugs should only be reported when not using native libraries, I can
imagine that it would get on your nerves when bugs keep getting created for
people using them. I guess that most of these reports come from ies4linux
users, hence his original, admittedly wrong, comments about that. We're all
human.

If you encounter bugs I would encourage you retest the application(s) using
builtin dll's only, and continue to file bug reports. If nothing else, you
stand a much better chance of getting the applications you care about working
that way!

:-)

Regarding this bug, I realise that I didn't trace the outputs of the function,
so I'll submit the patch for this fix next week once 1.0 is out and get you to
re-test if you're still here.

[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

Detlef Riekenberg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|ABANDONED                   |

--- Comment #13 from Detlef Riekenberg   2008-09-29 00:04:53 ---
This is still an issue on Wine-1.1.5.

1. Download ie5.5 from browsers.evolt.org
   ( I used
http://www.mirrorservice.org/sites/browsers.evolt.org/browsers/ie/32bit/stan...)

2. unzip

3. Apply this Patch for "URLRegSubQueryA" to avoid a crash:
   http://www.winehq.org/pipermail/wine-patches/2008-September/061943.html

4. wine control INETCPL.CPL

5. Press "Settings" or "Delete Files"

Hi John. The Patch works, but I have some suggestions:
- When the function succeeded, then do not test GetLastError()
- You test with NULL for free_bytes  and NULL for total_bytes and
  your code return FALSE, but you did not call SetLastError()
- Your test set the results to 0, but you should set it to an unusal value
  (we use 0xdeadbeef in the tests, but this is a valid result, so use -1)
  and check, if the result is cleared on Windows or not
  (Do that also in your implementation, when needed)
- You can test more things, to learn, when the Functon should succeed and
  which error-code should be returned on failure
  (a drive without a pathname, but with a backslash / drive without backslash /
  a different case for he drive letter / a drive, that does not exist /
  an Empty string)
- you test with NULL for the Path. Make sure, that older Windows versions
  do not crash, when running the test:
- Run the test on windows, and when you send the Patch, write in the message,
  on which Windows-Version the test was tested
  (Asking on wine-devel for help for testing on various versions is a good
Idea)

(I'm offline for a while, so when you need more help,
please ask on wine-devel or on #winehackers)

Thanks for helping Wine

[Bug 13137] inetcpl crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

Detlef Riekenberg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
            Summary|IE6 crashes due to          |inetcpl crashes due to
                   |unimplemented function      |unimplemented function
                   |wininet.dll.GetDiskInfoA    |wininet.dll.GetDiskInfoA

--- Comment #14 from Detlef Riekenberg   2008-09-29 00:07:12 ---
I did my tests with a clean Wine.

[Bug 13137] inetcpl crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

--- Comment #15 from Juan Lang   2009-01-29 14:28:09 ---
This should be fixed.  Nonetheless, I like the patch attached to this bug
rather better than the current stub.  Jon, any chance you'll try again to get
this merged?

[Bug 13137] inetcpl crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

--- Comment #16 from Jon Griffiths   2009-01-29 15:44:48 ---
(In reply to comment #15)
> Jon, any chance you'll try again to get this merged?

Its going to be a while, I'm flat out at work ATM. I have no problem with
anyone else picking it up though...

[Bug 13137] inetcpl crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 13137] inetcpl crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #17 from Juan Lang   2009-05-13 14:42:45 ---
Fixed with today's git, commit 7ddec087f04a6d5b285d36dbe2a81b8fc73eaa0b:
http://source.winehq.org/git/wine.git/?a=commit;h=7ddec087f04a6d5b285d36dbe2...

[Bug 13137] inetcpl crashes due to unimplemented function wininet.dll.GetDiskInfoA

http://bugs.winehq.org/show_bug.cgi?id=13137

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Alexandre Julliard   2009-05-22 11:09:48 ---
Closing bugs fixed in 1.1.22.

[Bug 13137] inetcpl crashes due to unimplemented function wininet.dll.GetDiskInfoA

https://bugs.winehq.org/show_bug.cgi?id=13137

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |7ddec087f04a6d5b285d36dbe2a
                   |                            |81b8fc73eaa0b
                 CC|                            |[e-mail]