[Bug 52332] New: Incoming data on socket only satisfies the first async I/O request in the queue

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52332

Bug ID: 52332
           Summary: Incoming data on socket only satisfies the first async
                    I/O request in the queue
           Product: Wine
           Version: 7.0-rc3
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wineserver
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
      Distribution: ---

async_set_result() calls async_reselect() *before* de-queueing the async
request, which means that async_waiting() will return 0 since it *still* sees a
pending I/O request in the queue.

The problem manifests when the target file object is a socket. Sockets use
async_waiting() to determine whether the next poll event mask shall include the
POLLIN flag.  Since async_waiting() returns zero, sock_reselect() skips the
flag. This hangs any subsequent I/O read requests.

Known impacted applications include KakaoTalk (an instant messaging
application): this bug causes the log-in to timeout, preventing normal use of
the app.

I have the fix, but I am yet to bisect the regression commit.

[Bug 52332] Incoming data on socket only satisfies the first async I/O request in the queue

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52332

Jinoh Kang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, regression, testcase
            Version|7.0-rc3                     |7.0-rc4

--- Comment #1 from Jinoh Kang  ---
Patch submitted: https://source.winehq.org/patches/data/222873

Complete test job: https://testbot.winehq.org/JobDetails.pl?Key=104813

[Bug 52332] Incoming data on socket only satisfies the first async I/O request in the queue

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52332

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9ef5c9c0090f17df5bfd7944850
                   |                            |19fb8bf9a7e25
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Matteo Bruni  ---
As far as I understand commit 9ef5c9c0090f17df5bfd794485019fb8bf9a7e25 should
have fixed it. Reopen if that's not the case.

[Bug 52332] Incoming data on socket only satisfies the first async I/O request in the queue

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52332

Jinoh Kang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |e4a2bca47b0b248f820354b154e
                   |                            |43d200d03d15d

[Bug 52332] Incoming data on socket only satisfies the first async I/O request in the queue

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52332

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 7.0-rc5.