[Bug 41378] New: wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

Bug ID: 41378
           Summary: wineboot silently ignores unknown WINEARCH
           Product: Wine
           Version: 1.9.19
          Hardware: x86
               URL: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=8384
                    74
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: programs
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hi,

I'd suggest that wineboot checks the value of WINEARCH when creating a new
prefix Wine, and errors out with a nice error message if WINEARCH is unknown
(neither empty, nor win32 or win64).

Currently I think there's only a test if #arch in system.reg is valid.

This check especially helps new users who confuse win32 and wine32, e.g.:

$ rm -rf .wine
$ export WINEARCH=wine32
$ wineboot
wine: created the configuration directory '/home/jens/.wine'
[...]
wine: configuration in '/home/jens/.wine' has been updated.
$ grep #arch .wine/system.reg 
#arch=win64

Greets
jre

[Bug 41378] wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |download, source

[Bug 41378] wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

Jens Reyer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                URL|https://bugs.debian.org/cgi |https://bugs.debian.org/838
                   |-bin/bugreport.cgi?bug=8384 |474
                   |74                          |

[Bug 41378] wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 41378] wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
           Keywords|                            |patch
     Ever confirmed|0                           |1

--- Comment #1 from Austin English  ---
I sent a patch https://source.winehq.org/patches/data/126989

[Bug 41378] wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

--- Comment #2 from [e-mail] ---
Maybe it should also print if the current created prefix is for 32 or 64bit.

[Bug 41378] wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from [e-mail] ---
(In reply to Austin English from comment #1)
> I sent a patch https://source.winehq.org/patches/data/126989

Question:

This patch won't interfere with the creation of WoW64 prefixes, will it?

[Bug 41378] wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

--- Comment #4 from Jens Reyer  ---
(In reply to fjfrackiewicz from comment #3)
> This patch won't interfere with the creation of WoW64 prefixes, will it?

AFAIK WoW64 has arch win64, there's nothing like e.g. WINEARCH=wow64. So I'd
say no, it won't interfere.

Thanks Austin!

[Bug 41378] wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

--- Comment #5 from [e-mail] ---
(In reply to Jens Reyer from comment #4)
> (In reply to fjfrackiewicz from comment #3)
> > This patch won't interfere with the creation of WoW64 prefixes, will it?
>
> AFAIK WoW64 has arch win64, there's nothing like e.g. WINEARCH=wow64. So I'd
> say no, it won't interfere.
>
> Thanks Austin!

Aha, so if I create a prefix with the following command:

WINEPREFIX=$HOME/.wine winecfg wineboot (I assume this is what creates a WoW64
prefix where I can run 32-bit applications alongside 64-bit ones)

I will simply get an "unknown arch" error?

Apologies for the slight offtopic/derailment and all...

[Bug 41378] wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

--- Comment #6 from Austin English  ---
(In reply to fjfrackiewicz from comment #5)
> (In reply to Jens Reyer from comment #4)
> > (In reply to fjfrackiewicz from comment #3)
> > > This patch won't interfere with the creation of WoW64 prefixes, will it?
> >
> > AFAIK WoW64 has arch win64, there's nothing like e.g. WINEARCH=wow64. So I'd
> > say no, it won't interfere.
> >
> > Thanks Austin!
>
> Aha, so if I create a prefix with the following command:
>
> WINEPREFIX=$HOME/.wine winecfg wineboot (I assume this is what creates a
> WoW64 prefix where I can run 32-bit applications alongside 64-bit ones)

A WoW64 (win64) prefix will be made if you have wine64, otherwise it would be
win32. Also note that that command runs winecfg (which would invoke wineboot if
the prefix wasn't updated or didn't exist).
> I will simply get an "unknown arch" error?

No. You're not specifying a WINEARCH, so the default will be used (depending on
your wine setup).

You'd want:
WINEARCH=win32 wine wineboot

or:
WINEARCH=win64 wine wineboot

See
https://wiki.winehq.org/FAQ#How_do_I_create_a_32_bit_wineprefix_on_a_64_bit_...
for more info.

You'll only get an error if the WINEARCH is invalid, e.g.,:
WINEARCH=foobar wine wineboot

which currently is allowed.

[Bug 41378] wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from [e-mail] ---
I think this got fixed.

http://source.winehq.org/git/wine.git/commit/df3b7958a731378d2a156d363bd9af3...

[Bug 41378] wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

--- Comment #8 from Jens Reyer  ---
(In reply to winetest from comment #7)
> I think this got fixed.

Yes, confirmed. Thanks everyone who worked on this!

[Bug 41378] wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |df3b7958a731378d2a156d363bd
                   |                            |9af36b34a9ac1
         Resolution|---                         |FIXED

--- Comment #9 from Rosanne DiMesio  ---
Marking fixed.

[Bug 41378] wineboot silently ignores unknown WINEARCH

https://bugs.winehq.org/show_bug.cgi?id=41378

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  ---
Closing bugs fixed in 2.0-rc3.