[Bug 15364] New: Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

Summary: Build broken when CFLAGS="-Wall -Werror" is used
           Product: Wine
           Version: 1.1.5
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Keywords: source
          Severity: enhancement
          Priority: P2
         Component: build-env
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=16209)
 --> (http://bugs.winehq.org/attachment.cgi?id=16209)
config.status/config.log, with CFLAGS set

Compiling with those flags set gives:
-----
configure: libxrandr development files not found, XRandr won't be supported.
configure: libxinerama development files not found, multi-monitor setups won't
be supported.

configure: WARNING: Old Mesa headers detected. Consider upgrading your Mesa
libraries.
OpenGL and Direct3D won't be supported.

configure: Finished.  Do 'make depend && make' to compile Wine.
-----

Which doesn't occur when the standard options are used. I'll attach
config.status/config.log.

[Bug 15364] Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

--- Comment #1 from Austin English   2008-09-21 19:01:02 ---
Created an attachment (id=16210)
 --> (http://bugs.winehq.org/attachment.cgi?id=16210)
config.status/config.log, without CFLAGS overriden

[Bug 15364] Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

Maarten Lankhorst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Maarten Lankhorst   2008-09-21 19:07:34 ---
If you actually took a look at config.log you would see this:

Program is:

#include <X11/Xlib.h>
 #include <X11/extensions/Xrandr.h>
 int
 main ()
 {
 static typeof(XRRSetScreenConfigAndRate) * func;
   ;
   return 0;
 }

conftest.c: In function 'main':
conftest.c:136: warning: unused variable 'func'
configure:10683: $? = 1

This is not evadable, unless you add -Wno-unused

As an alternative you can invoke make as "make CFLAGS='-Wall -Werror -O2'".

Perhaps it would work if the program was this?

#include <X11/Xlib.h>
 #include <X11/extensions/Xrandr.h>
 int
 main ()
 {
void *foo;
foo = &XRRSetScreenConfigAndRate;
   return 0;
 }

[Bug 15364] Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

--- Comment #3 from Maarten Lankhorst   2008-09-21 19:12:43 ---
Created an attachment (id=16211)
 --> (http://bugs.winehq.org/attachment.cgi?id=16211)
Simple patch that fixes those issues.

Makes -Wall -Werror work by suppressing errors.

[Bug 15364] Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

--- Comment #4 from Austin English   2008-09-21 23:24:44 ---
(In reply to comment #2)
> Perhaps it would work if the program was this?
>
> #include <X11/Xlib.h>
>  #include <X11/extensions/Xrandr.h>
>  int
>  main ()
>  {
> void *foo;
> foo = &XRRSetScreenConfigAndRate;
>    return 0;
>  }

That fixes xrandr, yes. The other patch is not required.

I don't think suppressing errors in the proper solution...Getting to the root
of the problem is the way to go.

[Bug 15364] Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

--- Comment #5 from Austin English   2008-09-21 23:47:41 ---
(In reply to comment #4)
> I don't think suppressing errors in the proper solution...Getting to the root
> of the problem is the way to go.

Err, ignore that comment. Just reread the patch :-P. Sorry for sounding
pompous...I'm uploading one for xinerama now.

[Bug 15364] Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

--- Comment #6 from Austin English   2008-09-21 23:57:32 ---
(In reply to comment #5)
> (In reply to comment #4)
> > I don't think suppressing errors in the proper solution...Getting to the root
> > of the problem is the way to go.
>
> Err, ignore that comment. Just reread the patch :-P. Sorry for sounding
> pompous...I'm uploading one for xinerama now.

I'm going to go to bed before saying anything else silly. Patch works fine for:

$ ./configure
as well as
$ CFLAGS="-Wall -Werror" ./configure

I've got make clean && make depend && make running now, we'll see how that
goes.

Mind submitting that patch to wine-patches?

[Bug 15364] Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 15364] Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 15364] Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

--- Comment #7 from Austin English  2010-09-06 02:12:21 CDT ---
configure: libxrandr development files not found, XRandr won't be supported.
configure: libxinerama development files not found, multi-monitor setups won't
be supported.
configure: libgnutls development files not found, no schannel support.

configure: WARNING: Old Mesa headers detected. Consider upgrading your Mesa
libraries.
OpenGL and Direct3D won't be supported.

configure: Finished.  Do 'make' to compile Wine.

Still in 1.3.2.

[Bug 15364] Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

--- Comment #8 from Austin English  2011-09-01 14:01:54 CDT ---
(In reply to comment #7)
> configure: libxrandr development files not found, XRandr won't be supported.
> configure: libxinerama development files not found, multi-monitor setups won't
> be supported.
> configure: libgnutls development files not found, no schannel support.
>
> configure: WARNING: Old Mesa headers detected. Consider upgrading your Mesa
> libraries.
> OpenGL and Direct3D won't be supported.
>
> configure: Finished.  Do 'make' to compile Wine.
>
> Still in 1.3.2.

Fixed by
http://source.winehq.org/git/wine.git/commitdiff/45725be9d5c721710f69a576dbc...

[Bug 15364] Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #9 from Dan Kegel  2011-09-13 14:17:43 CDT ---
Marking fixed.
(64 bits is another question, this bug was just for 32 bits, I think.)

[Bug 15364] Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  2011-09-23 12:59:49 CDT ---
Closing bugs fixed in 1.3.29.

[Bug 15364] Build broken when CFLAGS="-Wall -Werror" is used

http://bugs.winehq.org/show_bug.cgi?id=15364

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |45725be9d5c721710f69a576dbc
                   |                            |80cea6738ed13