[Bug 23788] New: Samsung Kies installer stops early

http://bugs.winehq.org/show_bug.cgi?id=23788

Summary: Samsung Kies installer stops early
           Product: Wine
           Version: 1.2
          Platform: x86-64
               URL: http://www.samsung.com
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msxml3
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=29829)
 --> (http://bugs.winehq.org/attachment.cgi?id=29829)
Simple patch to get the installer a bit further

Didn't find a direct link (yet) for the executable. You can however look for
the Samsung Galaxy S and under support you will find the Kies installer
(Kies_1.5.1.10071_32.exe).

Starting the installer gives a few screens and than stops right after I get in
the console:

fixme:msxml:domdoc_setProperty Unknown property L"ProhibitDTD"

Running current Git and on a clean .wine

'winetricks msxml3' gets passed this but then the installer crashes while
trying to install WMFDist11-WindowsXP-ENU.cab (some Windows Media stuff
apparantly) but that should be for another bug.

The attached (obviously not correct) patch also gets me further and of course
crashes at the same point.

[Bug 23788] Samsung Kies installer stops early

http://bugs.winehq.org/show_bug.cgi?id=23788

--- Comment #1 from Nikolay Sivov   2010-07-27 07:14:36 ---
Libxml2 doesn't provide an option to skip DTD, but if a stream could be parsed
without DTD its absence won't hurt. So a patch is probably fine, attach a crash
log that occurs after that.

[Bug 23788] Samsung Kies installer stops early

http://bugs.winehq.org/show_bug.cgi?id=23788

--- Comment #2 from Paul Vriens   2010-07-27 07:44:13 ---
Nikolay, the crash should be handled by a different bug report (not related to
msxml).

So you think, the patch is good to go? Should I get rid off the wine_dbgstr_w
and replace that with a simple "Ignoring property SZ_PROPERTY_PROHIBIT_DTD"?

[Bug 23788] Samsung Kies installer stops early

http://bugs.winehq.org/show_bug.cgi?id=23788

--- Comment #3 from Nikolay Sivov   2010-07-27 07:53:27 ---
Yes, I think it's fine to send it: we can't skip DTD with libxml2
functionality, but if really happens to matter for some app we could pre-parse
a stream and pass modified stream without DTD to libxml2.

For this case I think it's more like a precaution to skip DTDs, so S_OK is
enough for a start.

About a FIXME I don't care too much will you put it inline or debugstr_w(),
something like that (with value output) is enough:

"Ignoring property ProhibitDTD, value %d".

[Bug 23788] Samsung Kies installer stops early

http://bugs.winehq.org/show_bug.cgi?id=23788

--- Comment #4 from Paul Vriens   2010-07-28 11:28:49 ---
Patch is in:

http://source.winehq.org/git/wine.git/?a=commitdiff;h=fa8f79feb82c5823d11152...

[Bug 23788] Samsung Kies installer stops early

http://bugs.winehq.org/show_bug.cgi?id=23788

Paul Vriens  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Paul Vriens   2010-07-29 15:18:58 ---
Forgot to mark it resolved/fixed.

[Bug 23788] Samsung Kies installer stops early

http://bugs.winehq.org/show_bug.cgi?id=23788

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard   2010-07-30 12:59:50 ---
Closing bugs fixed in 1.3.0.