[Bug 56699] New: Cultures 2-3-4 crashes when directmusic enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56699

Bug ID: 56699
           Summary: Cultures 2-3-4 crashes when directmusic enabled
           Product: Wine
           Version: 9.1
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: dmusic
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 8daf207bf76ac02894db92abcf6873ccacbdc0f4
      Distribution: ArchLinux

Created attachment 76485
  --> https://bugs.winehq.org/attachment.cgi?id=76485
terminal output including backtrace

When directmusic is selected as the source of the background music the
following games from the Cultures series crash upon launching a mission:

Cultures 2: The Gates of Asgard
Cultures - Northland
Cultures - 8th Wonder of the World

Reverting commit 8daf207bf76ac02894db92abcf6873ccacbdc0f4
fixes the crash for me.

commit 8daf207bf76ac02894db92abcf6873ccacbdc0f4
Author: Yuxuan Shui 
Date:   Thu Jan 18 12:59:49 2024 +0000

dmime: Semi-support creating an audio path from config.

Note: background music previously didn't work with built-in directmusic
libraries.

Demo version of Northland doesn't contain music files.

Still present in wine-9.9-17-ged9ec141d52

[Bug 56699] Cultures 2-3-4 crashes when directmusic enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56699

--- Comment #1 from Béla Gyebrószki  ---
Created attachment 76486
  --> https://bugs.winehq.org/attachment.cgi?id=76486
Dmusic debug log (uncompressed 56 M)

WINEDEBUG=+seh,+dsound,+dsound3d,+dswave,+dmband,+dmcompos,+dmdump,+dmfile,+dmfileraw,+dmime,+dmloader,+dmobj,+dmscript,+dmstyle,+dmsynth,+dmusic

[Bug 56699] Cultures 2-3-4 crashes when directmusic enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56699

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Michael Stefaniuc  ---
Created attachment 76529
  --> https://bugs.winehq.org/attachment.cgi?id=76529
Crash fix

Can you please try the attached patch?
It should fix that specific crash but performance_CreateAudioPath() will fail
and the games might still crash later on.

[Bug 56699] Cultures 2-3-4 crashes when directmusic enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56699

--- Comment #3 from Béla Gyebrószki  ---
Created attachment 76531
  --> https://bugs.winehq.org/attachment.cgi?id=76531
Dmusic debug log after patch applied

(In reply to Michael Stefaniuc from comment #2)
> Created attachment 76529 [details]
> Crash fix
>
> Can you please try the attached patch?
> It should fix that specific crash but performance_CreateAudioPath() will
> fail and the games might still crash later on.

With the patch applied the games crash at the exact same moment as before
(right after starting a scenario) but judging by the backtrace this is a
different kind of crash.

[Bug 56699] Cultures 2-3-4 crashes when directmusic enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56699

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |STAGED
    Staged patchset|                            |https://github.com/wine-sta
                   |                            |ging/wine-staging/tree/mast
                   |                            |er/patches/dmime_segment_ge
                   |                            |taudiopath

--- Comment #4 from Béla Gyebrószki  ---
The crash is fixed by Staging commit
https://github.com/wine-staging/wine-staging/commit/6ae3756a4f5023a07870bfcd...