[Bug 44815] New: Some Cygwin/ MSYS2 applications need a better invalid parameter handling in ntdll.NtAccessCheck

https://bugs.winehq.org/show_bug.cgi?id=44815

Bug ID: 44815
           Summary: Some Cygwin/MSYS2 applications need a better invalid
                    parameter handling in ntdll.NtAccessCheck
           Product: Wine
           Version: 3.4
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ntdll
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hello folks,

to track
https://github.com/wine-staging/wine-staging/tree/master/patches/ntdll-NtAcc...

Unfortunately there is little information/details, I just found this:

https://wine-staging.com/news/2016-02-23-release-1.9.4.html

--- quote ---
Improve invalid parameter handling in NtAccessCheck (MSYS)
--- quote ---

https://github.com/openunix/cygwin/blob/master/winsup/cygwin/security.cc

https://github.com/openunix/cygwin/search?utf8=%E2%9C%93&q=NtAccessCheck

$ wine --version
wine-3.4

Regards

[Bug 44815] Some Cygwin/ MSYS2 applications need a better invalid parameter handling in ntdll.NtAccessCheck

https://bugs.winehq.org/show_bug.cgi?id=44815

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch, source
    Staged patchset|                            |https://github.com/wine-sta
                   |                            |ging/wine-staging/tree/mast
                   |                            |er/patches/ntdll-NtAccessCh
                   |                            |eck
             Status|NEW                         |STAGED
                URL|                            |https://cygwin.com/install.
                   |                            |html

[Bug 44815] Some Cygwin/ MSYS2 applications need a better invalid parameter handling in ntdll.NtAccessCheck

https://bugs.winehq.org/show_bug.cgi?id=44815

tokktokk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 44815] Some Cygwin/ MSYS2 applications need a better invalid parameter handling in ntdll.NtAccessCheck

https://bugs.winehq.org/show_bug.cgi?id=44815

Andrey  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 44815] Some Cygwin/MSYS2 applications need a better invalid parameter handling in ntdll.NtAccessCheck

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=44815

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from André H.  ---
patchset is gone

[Bug 44815] Some Cygwin/MSYS2 applications need a better invalid parameter handling in ntdll.NtAccessCheck

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=44815

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Bernhard Übelacker  ---
Wine-staging removed this patch here:

https://gitlab.winehq.org/wine/wine-staging/-/commit/6347bdd1fcb600dd41779ba...

As the staging patch got removed and it seems not known how the issue
behind can be reproduced, should this bug be closed?

[Bug 44815] Some Cygwin/MSYS2 applications need a better invalid parameter handling in ntdll.NtAccessCheck

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=44815

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Staged patchset|https://github.com/wine-sta |
                   |ging/wine-staging/tree/mast |
                   |er/patches/ntdll-NtAccessCh |
                   |eck                         |
         Resolution|---                         |ABANDONED
             Status|STAGED                      |RESOLVED

--- Comment #3 from Zeb Figura  ---
(In reply to Bernhard Übelacker from comment #2)
> Wine-staging removed this patch here:
>
> https://gitlab.winehq.org/wine/wine-staging/-/commit/
> 6347bdd1fcb600dd41779baf23176d920d4f1632
>
> As the staging patch got removed and it seems not known how the issue
> behind can be reproduced, should this bug be closed?

The wine-staging patch was upstreamed as
https://source.winehq.org/git/wine.git/commitdiff/be98f67f10c26b46acbf2fe98ea764c27efd3612.

That said, since we don't know what application needed it or if that
application is fixed, I'm resolving as ABANDONED.

Looking at cygwin source for use of NtAccessCheck turns up some, but it's not
immediately clear how to invoke cygwin in the right way. If current cygwin
source is even the relevant version.

[Bug 44815] Some Cygwin/MSYS2 applications need a better invalid parameter handling in ntdll.NtAccessCheck

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=44815

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Gijs Vermeulen  ---
Closing.