[Bug 17308] New: ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

Summary: ArtRage needs native gdiplus
           Product: Wine
           Version: 1.1.14
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdiplus
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=19320)
 --> (http://bugs.winehq.org/attachment.cgi?id=19320)
+gdiplus log

ArtRage 2.5 does not start with wine gdiplus, but fails with a succession of
error message boxes and exits.

Native gdiplus works around the issue.

"An error occurred reading data from a binary resource file. Image failed to
load from resources."

(Note: the app installer forgets to install visual c runtime, winetricks
vcrun2005 and vcrun2005sp1 is needed)

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #1 from Nikolay Sivov   2009-02-07 19:43:42 ---
Is a Starter edition affected too?

http://www2.ambientdesign.com/files/artrage2.5starteredition_win.msi

If so please add it at URL field.

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www2.ambientdesign.co
                   |                            |m/files/artrage2.5starteredi
                   |                            |tion_win.msi
           Keywords|                            |download

--- Comment #2 from [e-mail]  2009-02-07 19:57:56 ---
Starter edition is also affected.

It even installs vcrun2005* properly, unlike the wacom edition, so no extra
steps needed to reproduce. msiexec /i artrage2.5starteredition_win.msi, then
try to run the installed app.

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #3 from Juan Lang   2009-09-04 13:13:00 ---
Is this still an issue with 1.1.29?

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #4 from [e-mail]  2009-09-05 08:01:20 ---
Improvement! Yay! :) With 1.1.29, it starts, but is pretty broken. Lots of
multicomponent widgets are barely visible, missing backgrounds, etc. Painting
works, but as the tools for changing colour, strokes, etc. are invisible, you
can't do much useful.

Native gdiplus lets it work properly, at a quick try.

I'll attach screenshots illustrating the trouble. Just yell if I should open a
new bug instead.

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #5 from [e-mail]  2009-09-05 08:04:49 ---
Created an attachment (id=23448)
 --> (http://bugs.winehq.org/attachment.cgi?id=23448)
screenshot, 1.1.29, builtin gdiplus

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #6 from [e-mail]  2009-09-05 08:05:51 ---
Created an attachment (id=23449)
 --> (http://bugs.winehq.org/attachment.cgi?id=23449)
screenshot, 1.1.29, native gdiplus

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #7 from Vincent Povirk   2009-09-05 08:29:16 ---
Well, the description still makes sense and there's still only one issue in the
bug (lots of things not drawing that should be), so I think it's ok to not file
a new one.

A log would be nice.

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19320|0                           |1
        is obsolete|                            |

--- Comment #8 from [e-mail]  2009-09-05 11:48:12 ---
Created an attachment (id=23452)
 --> (http://bugs.winehq.org/attachment.cgi?id=23452)
plain log, 1.1.29

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #9 from [e-mail]  2009-09-05 11:49:32 ---
Created an attachment (id=23453)
 --> (http://bugs.winehq.org/attachment.cgi?id=23453)
+gdiplus log, 1.1.29

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #10 from [e-mail]  2009-09-05 11:50:53 ---
These are logs from startup, click close on the advertisment, a tiny bit of
doodling, then file->quit.

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #11 from Vincent Povirk   2009-09-05 12:32:07 ---
It's not using gdiplus to draw, just to load images in RGBA format.
http://www.winehq.org/pipermail/wine-patches/2009-September/078124.html may
help.

GdipGetImageRawFormat would also be nice to implement (and should be possible
now that decoders are in place), but I don't think it'll help.

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #12 from [e-mail]  2009-09-05 12:46:27 ---
Created an attachment (id=23457)
 --> (http://bugs.winehq.org/attachment.cgi?id=23457)
screenshot, builtin with Vincent's png patch

Tested. I sense an off-by-one somewhere in the new code :)

Just added patch 1 and 2 of the series to plain 1.1.29.

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #13 from Vincent Povirk   2009-09-05 12:51:05 ---
OK, I'll have to download the program to debug that properly. Which I probably
won't get to soon. (Unless the original files aren't actually in an RGBA format
in which case it just needs proper format conversion.)

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #14 from [e-mail]  2009-09-05 12:58:26 ---
The PNGs I can find in the program dir are 8bit grayscale without alpha, or
8/8/8 RGB without alpha. According to file(1).

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #15 from Vincent Povirk   2009-11-11 17:44:49 ---
It looks like it's a bitmap locking problem. The application tries to lock the
bitmap multiple times, and after the first time it fails with a WrongState
error.

I just tried a hack removing all locking checks, and it looks better (but still
not perfect).

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

Ville Takanen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #16 from Ville Takanen   2009-12-03 01:09:07 ---
*** This bug has been confirmed by popular vote. ***

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

V.platanias  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from V.platanias   2009-12-25 06:06:34 ---
Same behavior in artrage 3 studio pro. 
Attaching a +gdiplus log and a screenshot.

Works fine with native gdiplus , as well.

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #18 from V.platanias   2009-12-25 06:07:57 ---
Created an attachment (id=25397)
 --> (http://bugs.winehq.org/attachment.cgi?id=25397)
+gdiplus log from artrage3

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #19 from V.platanias   2009-12-25 06:08:42 ---
Created an attachment (id=25398)
 --> (http://bugs.winehq.org/attachment.cgi?id=25398)
Artrage3 screenshot with builtin gdiplus

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #20 from V.platanias   2010-01-09 08:15:09 ---
I think newest wine (.36) fixed this issue.

Artrage 2 looks perfect, exactly as with native gdiplus.
Artrage 3 has black scrollbars, but that's the only glitch I can see.

Can anyone confirm ?

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

--- Comment #21 from Nikolay Sivov   2010-01-09 08:19:38 ---
Probably commit 7afd9603b5c2cb452484f2d07ef3839d60dbd94e changed things.

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #22 from Nikolay Sivov   2010-01-09 08:35:24 ---
(In reply to comment #21)
> Probably commit 7afd9603b5c2cb452484f2d07ef3839d60dbd94e changed things.

Yes, this is it. Reverting makes it looks like before. Open next bug for
version 3 if not already done, this one is fixed.

[Bug 17308] ArtRage needs native gdiplus

http://bugs.winehq.org/show_bug.cgi?id=17308

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #23 from Alexandre Julliard   2010-01-22 11:02:12 ---
Closing bugs fixed in 1.1.37.