[Bug 36743] New: rpcrt4 tests fail when using widl "-Oif" option

http://bugs.winehq.org/show_bug.cgi?id=36743

Bug ID: 36743
           Summary: rpcrt4 tests fail when using widl "-Oif" option
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: rpc
          Assignee: [e-mail]
          Reporter: [e-mail]

Hello,

in order to squash https://jira.reactos.org/browse/CORE-8200 out, I tried to
run rpcrt4 tests with the "modern" type stubs instead of the ones currently
used in wine tree.

As expected, this led to memory corruption and wrong test results. Attached is
a valgrind report of "rpcrt4_test server" with +ole,+rpc debug channel, with
quite a lot of invalid read and invalid free.

For instance, the call to get_names function triggers invalid read such as this
one:

==30367== Invalid read of size 4
==30367==    at 0x5672AEB: ComputeConformanceOrVariance (ndr_marshall.c:634)
==30367==    by 0x5674D9F: NdrConformantArrayFree (ndr_misc.h:39)
==30367==    by 0x567EF19: NdrStubCall2 (ndr_stubless.c:144)
==30367==    by 0x567F1DD: NdrServerCall2 (ndr_stubless.c:1450)
==30367==    by 0x568EA29: process_request_packet (rpc_server.c:441)
==30367==    by 0x568EFB9: RPCRT4_worker_thread (rpc_server.c:519)
==30367==    by 0x7BC8BC9F: worker_thread_proc (threadpool.c:110)
==30367==    by 0x7BC7FBDF: ??? (in
/home/jerome/wine-fun/wine-build/dlls/ntdll/ntdll.dll.so)
==30367==    by 0x7BC82B6C: call_thread_func (signal_i386.c:2630)
==30367==    by 0x7BC7FBBD: ??? (in
/home/jerome/wine-fun/wine-build/dlls/ntdll/ntdll.dll.so)
==30367==    by 0x7BC89367: start_thread (thread.c:428)
==30367==    by 0x4223D77: start_thread (pthread_create.c:311)
==30367==  Address 0x4cdea40 is 16 bytes after a recently re-allocated block of
size 32 alloc'd

To reproduce, change dlls/rpcrt4/tests.Makefile.in:
"EXTRAIDLFLAGS = --prefix-server=s_" --> "EXTRAIDLFLAGS = --prefix-server=s_
-Oif"

[Bug 36743] rpcrt4 tests fail when using widl "-Oif" option

http://bugs.winehq.org/show_bug.cgi?id=36743

--- Comment #1 from jgardou  ---
Created attachment 48796
  --> http://bugs.winehq.org/attachment.cgi?id=48796
rpcrt4_test server +rpc,+ole valgrind report

[Bug 36743] rpcrt4 tests fail when using widl "-Oif" option

http://bugs.winehq.org/show_bug.cgi?id=36743

Sylvain Petreolle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 36743] rpcrt4 tests fail when using widl "-Oif" option

https://bugs.winehq.org/show_bug.cgi?id=36743

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source, testcase,
                   |                            |valgrind

[Bug 36743] rpcrt4 tests fail when using widl "-Oif" option

http://bugs.winehq.org/show_bug.cgi?id=36743

--- Comment #2 from jgardou  ---
Please see http://source.winehq.org/patches/data/105133 for a possible fix.

[Bug 36743] rpcrt4 tests fail when using widl "-Oif" option

https://bugs.winehq.org/show_bug.cgi?id=36743

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from [e-mail] ---
Was this fixed?

[Bug 36743] rpcrt4 tests fail when using widl "-Oif" option

https://bugs.winehq.org/show_bug.cgi?id=36743

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 36743] rpcrt4 tests fail when using widl "-Oif" option

https://bugs.winehq.org/show_bug.cgi?id=36743

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |614afcefa33c727f31d566c3d7e
                   |                            |e05d74afc363f
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
         Resolution|---                         |FIXED

--- Comment #4 from Sebastian Lackner  ---
(In reply to super_man from comment #3)
> Was this fixed?

Yes, a basically identical patch was committed with
http://source.winehq.org/git/wine.git/patch/614afcefa33c727f31d566c3d7ee05d7....

[Bug 36743] rpcrt4 tests fail when using widl "-Oif" option

https://bugs.winehq.org/show_bug.cgi?id=36743

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.52.

[Bug 36743] rpcrt4 tests fail when using widl "-Oif" option

https://bugs.winehq.org/show_bug.cgi?id=36743

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Version|unspecified                 |1.7.20