[Bug 40032] New: Starcraft 2 crashes

https://bugs.winehq.org/show_bug.cgi?id=40032

Bug ID: 40032
           Summary: Starcraft 2 crashes
           Product: Wine-staging
           Version: 1.9.2
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail]
      Distribution: ---

StarCraft 2 now crashes with the error message

"An error occurred starting StarCraft II. Please try again. (Error 2:
-2147483392)"

This happens for both the 32 bit and 64 bit versions of StartCraft 2 and
happens with and without CSMT. Here is a pastebin from launching the 64bit
version with CSMT: http://pastebin.com/ntk9kM4u

StarCraft 2 works just fine with plain 1.9.2

[Bug 40032] Starcraft 2 crashes on wine 1.9.2 staging

https://bugs.winehq.org/show_bug.cgi?id=40032

Matthew Krafczyk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Starcraft 2 crashes         |Starcraft 2 crashes on wine
                   |                            |1.9.2 staging

[Bug 40032] Starcraft 2 crashes on wine 1.9.2 staging

https://bugs.winehq.org/show_bug.cgi?id=40032

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] ---
This seems to be the problem.

wine: Call from 0x7b83cf9c to unimplemented function
shcore.dll.SetProcessDpiAwareness, aborting

[Bug 40032] Starcraft 2 crashes on wine 1.9.2 staging

https://bugs.winehq.org/show_bug.cgi?id=40032

--- Comment #2 from Sebastian Lackner  ---
It seems the application now tries to use shcore, a stub dll which was newly
added in the last release. Please try to disable shcore in winecfg (go the
libraries tab, add "shcore", and then set it to disabled). Does that workaround
the issue?

[Bug 40032] Starcraft 2 crashes on wine 1.9.2 staging

https://bugs.winehq.org/show_bug.cgi?id=40032

--- Comment #3 from [e-mail] ---
The function itself doesnt seem to be very complicated at all.

https://msdn.microsoft.com/en-us/library/windows/desktop/dn302122%28v=vs.85%...

HRESULT WINAPI SetProcessDpiAwareness(
  _In_ PROCESS_DPI_AWARENESS value
);

Parameters

value [in]

The DPI awareness value to set. Possible values are from the
PROCESS_DPI_AWARENESSenumeration.

and 3 different return values.

Is very likely that this gets fixed in next release version.

[Bug 40032] Starcraft 2 crashes on wine 1.9.2 staging

https://bugs.winehq.org/show_bug.cgi?id=40032

--- Comment #4 from Matthew Krafczyk  ---
Searching for the function 'SetProcessDpiAwareness', I localized the issue to
be in the 'api-ms-win-Stub_DLLs' patchset.

Setting shcore to 'disabled' in winecfg allows StarCraft 2 to start normally.

[Bug 40032] Starcraft 2 crashes on wine 1.9.2 staging

https://bugs.winehq.org/show_bug.cgi?id=40032

--- Comment #5 from Sebastian Lackner  ---
I've committed a stub for the function as additional last patch of the
api-ms-win-Stub_DLLs series. Could you please verify if this fixes the issue?

For reference, the commit is here:
https://github.com/wine-compholio/wine-staging/commit/f2d347b8977b371f2568f4...

Before testing make sure to reenable shcore.dll in winecfg.

[Bug 40032] Starcraft 2 crashes on wine 1.9.2 staging

https://bugs.winehq.org/show_bug.cgi?id=40032

--- Comment #6 from Matthew Krafczyk  ---
StarCraft 2 now launches normally after applying the new patch and re-enabling
shcore.

Thanks a lot for your help!

[Bug 40032] Starcraft 2 crashes on wine 1.9.2 staging (needs shcore.dll.SetProcessDpiAwareness stub implementation or shcore disabled in winecfg)

https://bugs.winehq.org/show_bug.cgi?id=40032

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
            Summary|Starcraft 2 crashes on wine |Starcraft 2 crashes on wine
                   |1.9.2 staging               |1.9.2 staging (needs
                   |                            |shcore.dll.SetProcessDpiAwa
                   |                            |reness stub implementation
                   |                            |or shcore disabled in
                   |                            |winecfg)

--- Comment #7 from Sebastian Lackner  ---
(In reply to Matthew Krafczyk from comment #6)
> StarCraft 2 now launches normally after applying the new patch and
> re-enabling shcore.
>
> Thanks a lot for your help!

Thanks a lot for testing! Marking as fixed.

[Bug 40032] Starcraft 2 crashes on wine 1.9.2 staging ( needs shcore.dll.SetProcessDpiAwareness stub implementation or shcore disabled in winecfg )

https://bugs.winehq.org/show_bug.cgi?id=40032

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alistair Leslie-Hughes  ---
Closing Fixed Staging 3.14