[Bug 17665] New: Studio Tax fails to install

http://bugs.winehq.org/show_bug.cgi?id=17665

Summary: Studio Tax fails to install
           Product: Wine
           Version: 1.1.16
          Platform: PC
               URL: http://www.studiotax.com
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=19853)
 --> (http://bugs.winehq.org/attachment.cgi?id=19853)
Studio Tax error log

I just tried installing Studio Tax so that I could do my taxes, but half way
through the installation Studio Tax crashed. The only dependency that it needed
was DotNet 2.0, which I installed.

[Bug 17665] Studio Tax fails to install

http://bugs.winehq.org/show_bug.cgi?id=17665

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |download, Installer

--- Comment #1 from Austin English   2009-03-09 22:53:51 ---
Confirming.

[Bug 17665] Studio Tax fails to install

http://bugs.winehq.org/show_bug.cgi?id=17665

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19853|0                           |1
        is obsolete|                            |

--- Comment #2 from Austin English   2009-03-09 22:54:05 ---
Created an attachment (id=19854)
 --> (http://bugs.winehq.org/attachment.cgi?id=19854)
terminal output

[Bug 17665] Studio Tax fails to install

http://bugs.winehq.org/show_bug.cgi?id=17665

--- Comment #3 from Austin English   2009-03-09 22:55:37 ---
Created an attachment (id=19855)
 --> (http://bugs.winehq.org/attachment.cgi?id=19855)
+msi,+msidb,+seh bzip2 -9'ed (12Mb uncompressed)

[Bug 17665] Studio Tax fails to install

http://bugs.winehq.org/show_bug.cgi?id=17665

--- Comment #4 from Louis Lenders   2009-11-15 15:57:41 ---
Created an attachment (id=24771)
 --> (http://bugs.winehq.org/attachment.cgi?id=24771)
patch/hack(?)

The attached patch fixes the bug. I don't know anything about msi, but my
educated guess would be that code snippet:

if ( *pvalue & 0xffff0000 )

tries to check if *pvalue > 65536. That fails somehow, if *pvalue is 65535 the
condition is true and an out of range value is thrown by msi.

A msi-guru might shed a light on this i guess

[Bug 17665] Studio Tax fails to install

http://bugs.winehq.org/show_bug.cgi?id=17665

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |msi

[Bug 17665] Studio Tax fails to install

http://bugs.winehq.org/show_bug.cgi?id=17665

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24771|0                           |1
        is obsolete|                            |

--- Comment #5 from Hans Leidekker   2009-11-18 04:27:11 ---
Created an attachment (id=24816)
 --> (http://bugs.winehq.org/attachment.cgi?id=24816)
msi: Sign extend the value in conversion from small integer.

Try this one.

[Bug 17665] Studio Tax fails to install

http://bugs.winehq.org/show_bug.cgi?id=17665

--- Comment #6 from Louis Lenders   2009-11-18 09:44:44 ---
(In reply to comment #5)
> Created an attachment (id=24816)

--> (http://bugs.winehq.org/attachment.cgi?id=24816) [details]
> msi: Sign extend the value in conversion from small integer.
>
> Try this one.

Yip, that fixes the bug. Great work!

[Bug 17665] Studio Tax fails to install

http://bugs.winehq.org/show_bug.cgi?id=17665

--- Comment #7 from Louis Lenders   2009-11-18 09:49:30 ---
*** Bug 16498 has been marked as a duplicate of this bug. ***

[Bug 17665] Studio Tax fails to install

http://bugs.winehq.org/show_bug.cgi?id=17665

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #8 from Hans Leidekker   2009-11-19 13:24:09 ---
Fixed by commit 83e7a1214a009b133a031898a884ee72f74880ab.

[Bug 17665] Studio Tax fails to install

http://bugs.winehq.org/show_bug.cgi?id=17665

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard   2009-12-04 12:15:58 ---
Closing bugs fixed in 1.1.34.

[Bug 17665] Studio Tax fails to install

http://bugs.winehq.org/show_bug.cgi?id=17665

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |83e7a1214a009b133a031898a88
                   |                            |4ee72f74880ab