[Bug 22523] New: Unreal Engine 1 Games fail at Startup due to wined3d regression in 1.1.41-1.1.42

http://bugs.winehq.org/show_bug.cgi?id=22523

Summary: Unreal Engine 1 Games fail at Startup due to wined3d
                    regression in 1.1.41-1.1.42
           Product: Wine
           Version: 1.1.42
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=27604)
 --> (http://bugs.winehq.org/attachment.cgi?id=27604)
wine-1.1.42 output, and d3d trace

Unreal Engine 1 Games fail at Startup due to wined3d regression in
1.1.41-1.1.42

Due to a regression in wine during the 1.1.41 to 1.1.42 timeframe, Unreal
Engine 1 based games (tested with Unreal Gold, Unreal Tournament, and Deus Ex)
fail to startup due to a d3d error. The error dialog box produced by the
application says:

----
General protection fault!

History: UD3DRenderDevice::SetRes <- UD3DRenderDevice::Init <-
UWindowsViewport::TryRenderDevice <-
UWindowsViewport::OpenWindow <- UGameEngine::Init <- InitEngine
----

A regression test in dlls/wined3d shows the following to be the regression:

19b6f5ca75b43f61a366aa521eab9ddbfc4f99dd is first bad commit
commit 19b6f5ca75b43f61a366aa521eab9ddbfc4f99dd
Author: Stefan Dösinger 
Date:   Sun Mar 28 16:25:04 2010 +0200

wined3d: Control the onscreen depth stencil format in the swapchain.

This allows the swapchain to know what depth format its window contexts
have to see if the
    requested depth format is compatible or a FBO fallback is needed, and it
will be needed to
    set the onscreen format to the requested auto depth stencil format instead
of the
    let's-hope-it-fits D24_UNORM_S8_UINT format.

:040000 040000 2f6e9d3017c2e6715b6561d25cca4e947ee95000
44d70c59cce2f82aa3f2d8b6e19679588f81e1b8 M    dlls

http://source.winehq.org/git/wine.git/?a=commit;h=19b6f5ca75b43f61a366aa521e...

This is on a laptop running Slackware 13.0 (linux-2.6.30-5, xorg-server 1.6.3)
using intel-2.8.1 driver, and OffscreenRenderingMode=backbuffer. I'll probably
end up testing this on a similiar (albeit nvidia-195.36.15,
OffscreenRenderingMode=fbo) desktop.

I first noticed this problem while on wine-1.1.43, but attached is the plain
output, followed by a verbose d3d trace (WINEDEBUG="+d3d") of wine-1.1.42.

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]
            Summary|Unreal Engine 1 Games fail  |Unreal Engine 1 Games fail
                   |at Startup due to wined3d   |at Startup
                   |regression in 1.1.41-1.1.42 |

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

--- Comment #1 from A Wine user   2010-04-29 02:47:57 ---
Have you tested this in git? It looks somewhat similar to bug 22347.

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Wylda   2010-04-29 13:23:27 ---

As you also mention Unreal Tournament, i gave it a try and i don't have such
problem. Works perfectly here under:
 * 1.1.41, 1.1.42, 1.1.43, 1.1.43-387-gce3c1df

Under each above mentioned version i won a 10 kill round :) So working
perfectly.

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

--- Comment #3 from byteframe   2010-04-29 15:06:01 ---
I should reiterate that the problems detailed above are on a machine running
intel graphics. On my nvidia machine, Unreal Tournament works.

All of this is using the game's Direct3D renderer.

Using the software renderer, the game also crashes, but seemingly by a
differant cause. Forthcoming is the debug output for this. The program
segfaults almost immediately. I've yet to run a regression test, or to test the
software renderer on earlier wine versions, but since the title for this bug
has been changed, I think it falls within its purview.

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

--- Comment #4 from byteframe   2010-04-29 15:06:58 ---
Created an attachment (id=27620)
 --> (http://bugs.winehq.org/attachment.cgi?id=27620)
UT Software Renderer crashing on wine-1.1.43 and nVidia

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

--- Comment #5 from Wylda   2010-04-29 15:57:56 ---
> ...On my nvidia machine, Unreal Tournament works.

This was not clear to me from comment #0 ;)

Would be good, if someone closer around wine or 3D could clarify this. When
this works on nvidia, shouldn't be the problem rather reported to Intel rather
than Wine??

Also i think, that for software rendering issue should be opened separate
report.

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

--- Comment #6 from Henri Verbeet   2010-04-29 16:38:11 ---
(In reply to comment #5)
> Would be good, if someone closer around wine or 3D could clarify this. When
> this works on nvidia, shouldn't be the problem rather reported to Intel rather
> than Wine??

Not necessarily. There are differences between GL implementations, and wined3d
doesn't necessarily handle all of those well. Nevertheless, chances of a
particular bug being in the driver instead of Wine are currently a bit higher
for Intel/Mesa than for nvidia.

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Stefan Dösinger   2010-04-30 03:41:39 ---
It's quite likely that the intel driver has a valid limitation and we bail out
on it. I suspect it's D24S8 depth-stencil buffers.

I have a few free hours the next days, I'll try to get a bunch of those
regressions fixed.

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

--- Comment #8 from Stefan Dösinger   2010-04-30 07:10:47 ---
Created an attachment (id=27629)
 --> (http://bugs.winehq.org/attachment.cgi?id=27629)
Possible fix

Hi,
Can you try the attached patch? It allows wined3d to fall back to less
demanding depth stencil formats if D24S8 isn't supported.

I haven't tested the patch beyond making sure it compiles. So no guarantees...

It's likely that there's a problem later on when wined3d realizes that the
onscreen format doesn't support what the app requested. If FBOs are used it
will try to fall back offscreen rendering, which may fail in a different way.

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

--- Comment #9 from byteframe   2010-04-30 16:24:23 ---
(In reply to comment #8)
> Created an attachment (id=27629)

--> (http://bugs.winehq.org/attachment.cgi?id=27629) [details]
> Possible fix
>
> Hi,
> Can you try the attached patch? It allows wined3d to fall back to less
> demanding depth stencil formats if D24S8 isn't supported.
>
> I haven't tested the patch beyond making sure it compiles. So no guarantees...
>
> It's likely that there's a problem later on when wined3d realizes that the
> onscreen format doesn't support what the app requested. If FBOs are used it
> will try to fall back offscreen rendering, which may fail in a different way.

Works for me! Such expertise...

On a related subject, I've been running my intel laptop with
OffscreenRenderingMode set to 'backbuffer' for many months now. When set to
FBO, I can't start many/all installed games. This is of course a seperate
issue.

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

--- Comment #10 from byteframe   2010-05-04 23:22:08 ---
I see that the patch was commited to master. Upgraded to latest git, and
confirmed it's fixed.

This bug was opened in regards to the games' d3d renderer. As it stands the
software renderer, (which is an out-of-the box setting for at least one of
these games) segfaults on startup.

I'll have to do a regression test on this issue. Should this bug report not be
closed I'll just post the results here.

Thanks!

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

--- Comment #11 from Wylda   2010-05-04 23:44:49 ---
(In reply to comment #10)
> I see that the patch was commited to master. Upgraded to latest git, and
> confirmed it's fixed.

If this is fixed, than it should be closed as FIXED.

For software rendering fill a new bug report (you want to look for different
commit than the one mentioned in comment #0, right? => different problem and
you should not mix them together).

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Juan Lang   2010-05-05 10:44:17 ---
Reported fixed.

[Bug 22523] Unreal Engine 1 Games fail at Startup

http://bugs.winehq.org/show_bug.cgi?id=22523

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard   2010-05-07 13:30:33 ---
Closing bugs fixed in 1.1.44.