[Bug 35355] New: AppDB codebase needs to be updated to comply with modern php coding standards

http://bugs.winehq.org/show_bug.cgi?id=35355

Bug ID: 35355
           Summary: AppDB codebase needs to be updated to comply with
                    modern php coding standards
           Product: WineHQ Apps Database
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: appdb-unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
    Classification: Unclassified

Filing per http://bugs.winehq.org/show_bug.cgi?id=35350#c2.

[Bug 35355] AppDB codebase needs to be updated to comply with modern php coding standards

http://bugs.winehq.org/show_bug.cgi?id=35355

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 35355] AppDB codebase needs to be updated to comply with modern php coding standards

http://bugs.winehq.org/show_bug.cgi?id=35355

--- Comment #1 from Jeremy Newman  ---
Basically, what needs to be done is the code needs to be audited for PHP 5.3+
compliance.

Here is a short list of what needs to be changed. There are more, but these are
the obvious ones:

* all ereg() and ereg_match() calls need to be replaced with preg() and
preg_match. Same goes for split(), use preg_split()

* you can no longer pass references to functions. func(&$foo) is illegal. The
function needs to be defined with parameters that use a reference. i.e.:
function foo (&$param){}

A complete list is here:
http://www.php.net/manual/en/migration53.deprecated.php

[Bug 35355] AppDB codebase needs to be updated to comply with modern php coding standards

http://bugs.winehq.org/show_bug.cgi?id=35355

--- Comment #2 from Alexander Nicolaysen Sørnes  ---
I have committed changes to fix quite a few static/non-static function
invocations, as well as removing any calls to ereg* and mktime without
arguments.

Notices should probably be disabled for a while longer, but compliance should
now be pretty close.

[Bug 35355] AppDB codebase needs to be updated to comply with modern php coding standards

https://bugs.winehq.org/show_bug.cgi?id=35355

--- Comment #3 from Rosanne DiMesio  ---
This is mostly fixed, but I still see the following:

1. On the form for processing screenshots,

Strict Standards: Non-static method appData::getDefaultReply() should not be
called statically, assuming $this from incompatible context in
/home/winehq/opt/appdb/include/screenshot.php on line 818

appears between submitted screenshot and the reply text box.

2. In the Control Center, running Update Application Maintainer states produces
a page with thousands of lines of

Strict Standards: Non-static method maintainer::versionHasMaintainer() should
not be called statically, assuming $this from incompatible context in
/home/winehq/opt/appdb/include/version.php on line 1554

Running Update Version Maintainer States has a similar result, but with line
254  referenced at the end.

[Bug 35355] AppDB codebase needs to be updated to comply with modern php coding standards

https://bugs.winehq.org/show_bug.cgi?id=35355

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Rosanne DiMesio  ---
Fixed.

[Bug 35355] AppDB codebase needs to be updated to comply with modern php coding standards

https://bugs.winehq.org/show_bug.cgi?id=35355

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Bruno Jesus  ---
Closing appdb fixed bug.