[Bug 45483] New: Installation of the DirectX 8.1 SDK fails due to msi custom action failure

https://bugs.winehq.org/show_bug.cgi?id=45483

Bug ID: 45483
           Summary: Installation of the DirectX 8.1 SDK fails due to msi
                    custom action failure
           Product: Wine
           Version: 3.12
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 61838
  --> https://bugs.winehq.org/attachment.cgi?id=61838
+msi,+msiexec,+pid debug output

The DirectX 8.1 SDK fails to install due msi custom action errors:
006b:006c:err:msiexec:custom_action_server Failed to create custom action
server pipe: 231

setup.exe shows "Error: -1603 Fatal error during installation."

Steps to reproduce:
DX81b_SDK.exe with
SHA1: 221c60334da54e8e670741e7090e51255ad0284c
MD5: 0ef4637b05b77ae8f75d58e17f0e7d6d

DX81b_SDK.exe is a self extracting zip file.
cd to the extracted directory and run:
wine DXF/setup.exe
(Changing to the DXF directory and then wine setup.exe makes no difference).
Go through the steps and during the install at 0% a message box with the above
error pops up.

I'm attaching the +msi,+msiexec,+pid output

[Bug 45483] Installation of the DirectX 8.1 SDK fails due to msi custom action failure

https://bugs.winehq.org/show_bug.cgi?id=45483

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Zebediah Figura  ---
Probably fixed by 6925846988fb78a2dd217d2b837e59ec53234f87; please retest.

[Bug 45483] Installation of the DirectX 8.1 SDK fails due to msi custom action failure

https://bugs.winehq.org/show_bug.cgi?id=45483

--- Comment #2 from Michael Stefaniuc  ---
Same error. I wouldn't have expected that patch to fix it anyway as this is a
32bit app in a 32bit prefix.

[Bug 45483] Installation of the DirectX 8.1 SDK fails due to msi custom action failure

https://bugs.winehq.org/show_bug.cgi?id=45483

--- Comment #3 from Michael Stefaniuc  ---
Created attachment 62081
  --> https://bugs.winehq.org/attachment.cgi?id=62081
new +msi,+msiexec,+pid log

[Bug 45483] Installation of the DirectX 8.1 SDK fails due to msi custom action failure

https://bugs.winehq.org/show_bug.cgi?id=45483

--- Comment #4 from Zebediah Figura  ---
Created attachment 62082
  --> https://bugs.winehq.org/attachment.cgi?id=62082
multiple fixes for async custom actions

[Bug 45483] Installation of the DirectX 8.1 SDK fails due to msi custom action failure

https://bugs.winehq.org/show_bug.cgi?id=45483

--- Comment #5 from Michael Stefaniuc  ---
Created attachment 62084
  --> https://bugs.winehq.org/attachment.cgi?id=62084
log with patches 149696 - 149700

[Bug 45483] Installation of the DirectX 8.1 SDK fails due to msi custom action failure

https://bugs.winehq.org/show_bug.cgi?id=45483

--- Comment #6 from Michael Stefaniuc  ---
Thanks Zeb for the commits:
3a884c2ef7a5828a5b42bf9d2532422afeac0fd8
583edf7f59866cf0a58c978e692f3077e74b4938
b7f06accb05edd70239dbd7b04b956bf10456dee
6387476d99f4f762628cb0d72b2d43c23f76f563

And with my patch https://source.winehq.org/patches/data/149718 on top the DX8
SDK installs now. The 1-2 registry keys that the DirectMusic samples need are
present. 
So from my point of view the issue is fixed even though there is still an
issue:
<zf> the mystery for me isn't so much why it deadlocks as why CreateNamedPipe()
fails

[Bug 45483] Installation of the DirectX 8.1 SDK fails due to msi custom action failure

https://bugs.winehq.org/show_bug.cgi?id=45483

--- Comment #7 from Zebediah Figura  ---
(In reply to Michael Stefaniuc from comment #6)
> So from my point of view the issue is fixed even though there is still an
> issue:
> <zf> the mystery for me isn't so much why it deadlocks as why
> CreateNamedPipe() fails

Right. From the logs, the installer appears to open the package, do some
actions and whatnot with it, close it, and then call MsiInstallProduct().
Somewhere there's a leak, so that the package doesn't get properly freed the
first time, and so the custom action named pipe is never closed, so when
MsiInstallProduct() attempts to run another custom action, CreateNamedPipe()
fails.

Tracking down the leak will be difficult, since we don't trace MSI object
lifecycle.

[Bug 45483] Installation of the DirectX 8.1 SDK fails due to msi custom action failure

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=45483

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from [e-mail] ---
Is this the same problem as https://bugs.winehq.org/show_bug.cgi?id=51706 ?

Could you log trace+msi and trace+process ?

/BR