http://bugs.winehq.org/show_bug.cgi?id=36946
Bug ID: 36946 Summary: FindFirstFileExW() needs FIND_FIRST_EX_CASE_SENSITIVE support Product: Wine Version: 1.7.22 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: kernel32 Assignee: wine-bugs@winehq.org Reporter: anduchs@gmail.com
FindFirstFileExW() has no support for the FIND_FIRST_EX_CASE_SENSITIVE flag. Instead it currently returns INVALID_HANDLE_VALUE.
Games affected: Marvel Heroes 2015
The attached patch does not introduce correct handling, but makes the flag ignored and throws a warning (similar to other places).
http://bugs.winehq.org/show_bug.cgi?id=36946
--- Comment #1 from Andreas anduchs@gmail.com --- Created attachment 49055 --> http://bugs.winehq.org/attachment.cgi?id=49055 FindFirstFileExW(): Ignore FIND_FIRST_EX_CASE_SENSITIVE flag, but post warning
http://bugs.winehq.org/show_bug.cgi?id=36946
Andreas anduchs@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #49055|0 |1 is obsolete| |
--- Comment #2 from Andreas anduchs@gmail.com --- Created attachment 49119 --> http://bugs.winehq.org/attachment.cgi?id=49119 Corrected patch for Ignoring FIND_FIRST_EX_CASE_SENSITIVE
I just noticed I had a temporary patch instead of the real one... This one now also compiles...
http://bugs.winehq.org/show_bug.cgi?id=36946
Andreas anduchs@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.7.22 |1.7.23
http://bugs.winehq.org/show_bug.cgi?id=36946
Andreas anduchs@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, patch
https://bugs.winehq.org/show_bug.cgi?id=36946
--- Comment #3 from Andreas Fuchs anduchs@gmail.com --- The dirty fix is in master and to appear in wine-1.7.28
Still requires an actual implementation I guess...
https://bugs.winehq.org/show_bug.cgi?id=36946
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
--- Comment #4 from Sebastian Lackner sebastian@fds-team.de --- No, the current version is actually good enough for all real-world applications. I've submitted a couple of tests, which show that this flag is ignored even on most Windows versions (basically all except Windows 2000).
http://source.winehq.org/patches/data/106835 http://source.winehq.org/patches/data/106836
https://bugs.winehq.org/show_bug.cgi?id=36946
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com
--- Comment #5 from Anastasius Focht focht@gmx.net --- *** Bug 37354 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=36946
--- Comment #6 from Sebastian Lackner sebastian@fds-team.de --- @Anastasius: technically it isn't really a duplicate, since the bug addressed a different flag of FindFirstFileEx. ;)
https://bugs.winehq.org/show_bug.cgi?id=36946
--- Comment #7 from Sebastian Lackner sebastian@fds-team.de --- The tests are upstream now:
http://source.winehq.org/git/wine.git/commit/20b5c99f1172933e1736601c3937379... http://source.winehq.org/git/wine.git/commit/c9b4344322b29441886d297925b4c2f...
https://bugs.winehq.org/show_bug.cgi?id=36946
--- Comment #8 from Sebastian Lackner sebastian@fds-team.de --- Just for the log - this is what a proper solution would look like: http://ix.io/eBW
Nevertheless, I don't think we should apply that, since my tests show that this doesn't match the behaviour on recent versions of Windows - and I doubt that anyone really wants to enforce always the Windows 2000 behaviour.
https://bugs.winehq.org/show_bug.cgi?id=36946
Johannes Dewender wine@JonnyJD.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wine@JonnyJD.net
https://bugs.winehq.org/show_bug.cgi?id=36946
--- Comment #9 from Andreas Fuchs anduchs@gmail.com --- (In reply to Sebastian Lackner from comment #8)
Just for the log - this is what a proper solution would look like: http://ix.io/eBW
Nevertheless, I don't think we should apply that, since my tests show that this doesn't match the behaviour on recent versions of Windows - and I doubt that anyone really wants to enforce always the Windows 2000 behaviour.
Unfortunately, that's IMHO not the correct solution... :-(
The reason is that if the attribute CASE_INSESITIVE on OpenFile() is not set, then the system's default is used. So in case that the system's default is insensitive the operation would not be case sensitive, even if the flag CASE_SENSITIVE is set.
I think the correct solution would be to call QueryInformationFile() on the opened file for FileNameInformation and do an actual strcmp, if the flag CASE_SENSITIVE is set.
https://bugs.winehq.org/show_bug.cgi?id=36946
Rounak Singh rounaksingh17@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rounaksingh17@gmail.com
--- Comment #10 from Rounak Singh rounaksingh17@gmail.com --- Hi guys, I think this bug also crashed Adobe Reader 11.0.09 with wine-1.7.30-70-ge385df0 in windows 8 mode.
To reproduce: 1) Take new .wine
2) from winecfg change to windows 8. (If run iin windows xp mode, it will give error.)
3) Do winetricks to install and run Adobe Reader.
winetricks mspatcha winetricks wsh57 winetricks atmlib winetricks riched20
4) Download Adobe Reader 11.0.09 (for windows 8) from Adobe reader website. or follow link: http://ardownload.adobe.com/pub/adobe/reader/win/11.x/11.0.09/en_US/AdbeRdr1...
5) Install (If asked for update policy, click on manual update.)and run Adobe Reader. (It will ask for Running with protected mode disabled, do that.)
6) Now, you should be up and running the reader. Click on the standard toolbox, option "Access all your files". Now, the Adobe reader will crash.
I am attaching my terminal output just when i clicked on option "Access all your files".
Please confirm the bug for Adobe Reader 11.0.09.
Thanks.
Regards.
https://bugs.winehq.org/show_bug.cgi?id=36946
--- Comment #11 from Rounak Singh rounaksingh17@gmail.com --- Created attachment 49948 --> https://bugs.winehq.org/attachment.cgi?id=49948 Similar error with Adobe Reader -- Terminal Output.
https://bugs.winehq.org/show_bug.cgi?id=36946
Mike Ellery mellery@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mellery@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=36946
--- Comment #12 from Ken Sharp imwellcushtymelike@gmail.com --- Can this be marked as fixed then?
https://bugs.winehq.org/show_bug.cgi?id=36946
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|FindFirstFileExW() needs |FindFirstFileExW() needs |FIND_FIRST_EX_CASE_SENSITIV |FIND_FIRST_EX_CASE_SENSITIV |E support |E implementation
https://bugs.winehq.org/show_bug.cgi?id=36946
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
--- Comment #13 from Fabian Maurer dark.shadow4@web.de --- What's the current state of this?
https://bugs.winehq.org/show_bug.cgi?id=36946
Mike Ellery mellery@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|mellery@gmail.com |