[Bug 40780] New: dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

Bug ID: 40780
           Summary: dlls/wininet - error building on NetBSD
           Product: Wine
           Version: 1.9.12
          Hardware: x86
                OS: NetBSD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]

Created attachment 54680
  --> https://bugs.winehq.org/attachment.cgi?id=54680
./configure CFLAGS="-I/usr/X11R7/include -I/usr/pkg/include
-I/usr/pkg/include/AL -I/usr/pkg/include/hal" LDFLAGS="-L/usr/X11R7/lib
-L/usr/pkg/lib" --without-xrandr && make

Hello,
I am trying to build Wine on NetBSD 7.0.1 (GENERIC.201605221355Z) i386 but
stops on an error about wininet.

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source
                 CC|                            |[e-mail]

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Jacek Caban  ---
It seems that fd_type is used somewhere, where it should not be due to
conflicts between native headers and winsock ones. Sadly, your compiler is not
really helpful here as error messages are not really informative and don't
include usage locations in error messages.

Does removing fd_set define from winsock.h help?

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

--- Comment #2 from Jacek Caban  ---
Also, could you please attach preprocessed http.c? Something like:

gcc -E -o http.i http.c -I. -I../../include -D__WINESRC__ -D_WINX32_
-D_REENTRANT -fPIC -Wall -pipe  -fno-strict-aliasing
-Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers 
-Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla
-Wwrite-strings -Wpointer-arith  -Wlogical-op -fno-omit-frame-pointer
-I/usr/X11R7/include -I/usr/pkg/include -I/usr/pkg/include/AL
-I/usr/pkg/include/hal

should do the trick. Run that command in your
/home/Adrien2002/Téléchargements/wine-1.9.12/dlls/wininet directory and attach
http.i file.

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

--- Comment #3 from Adrien Fernandes  ---
Created attachment 54709
  --> https://bugs.winehq.org/attachment.cgi?id=54709
As Jacek Caban asked in comment 2

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

--- Comment #4 from Jacek Caban  ---
Created attachment 54710
  --> https://bugs.winehq.org/attachment.cgi?id=54710
fix

Does the attached patch help?

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

--- Comment #5 from Adrien Fernandes  ---
Created attachment 54714
  --> https://bugs.winehq.org/attachment.cgi?id=54714
Build after removing fd_set from winsock.h

After removing fd_set from winsock.h, it builds a lot more but stops on a new
error.

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

--- Comment #6 from Adrien Fernandes  ---
Created attachment 54715
  --> https://bugs.winehq.org/attachment.cgi?id=54715
After applying the patch

It builds much more but it is stopping now on something else.

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

Adrien Fernandes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #7 from Adrien Fernandes  ---
patch -p1 < patch_file
./configure CFLAGS="-I/usr/X11R7/include -I/usr/pkg/include
-I/usr/pkg/include/AL -I/usr/pkg/include/hal" LDFLAGS="-L/usr/X11R7/lib
-L/usr/pkg/lib" --without-xrandr --without-curses
make -j 4

Wine build complete.

Your fix is working for me !

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #8 from Jacek Caban  ---
It's not fixed until the patch is in Wine. Thanks for testing.

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

--- Comment #9 from Nikolay Sivov  ---
This should be fixed with
http://source.winehq.org/git/wine.git/?a=commit;h=a9a6948b7944dccca6831914ea...,
please retest with current wine from git.

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

--- Comment #10 from Adrien Fernandes  ---
I git clone mirror-wine/wine but the problem still remains the same as before
without any patch with the exact same outputs as I attached in the beginning of
this bug report.

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

--- Comment #11 from Nikolay Sivov  ---
I don't know what mirror-wine/wine is, who hosts it and how up-to-date it is,
try to clone from git://source.winehq.org/git/wine.git.

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

--- Comment #12 from Bruno Jesus  ---
(In reply to Nikolay Sivov from comment #11)
> I don't know what mirror-wine/wine is, who hosts it and how up-to-date it
> is, try to clone from git://source.winehq.org/git/wine.git.

I'm trying on git, it still fails in wininet. Will attach a screenshot since I
can't extract the text from the console only VM.

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

--- Comment #13 from Bruno Jesus  ---
Created attachment 55025
  --> https://bugs.winehq.org/attachment.cgi?id=55025
compile error in http.c

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

--- Comment #14 from Adrien Fernandes  ---
Created attachment 58430
  --> https://bugs.winehq.org/attachment.cgi?id=58430
New patch to fit newer Wine version

The issue is still here in 2.9 and the patch, slightly modified, is still
working.
I attach the new patch I have now.

[Bug 40780] dlls/wininet - error building on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=40780

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #15 from Austin English  ---
(In reply to Adrien Fernandes from comment #14)
> Created attachment 58430 [details]
> New patch to fit newer Wine version
>
> The issue is still here in 2.9 and the patch, slightly modified, is still
> working.
> I attach the new patch I have now.

Please send your patch to [e-mail]. See
https://wiki.winehq.org/SubmittingPatches