[Bug 40595] New: gdiplus:metafile test regression (test_frameunit)

https://bugs.winehq.org/show_bug.cgi?id=40595

Bug ID: 40595
           Summary: gdiplus:metafile test regression (test_frameunit)
           Product: Wine
           Version: 1.9.8
          Hardware: x86
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdiplus
          Assignee: [e-mail]
          Reporter: [e-mail]

Since the commit below, Windows XP SP1 machines (e.g. fg-winxp-1sp) have four
new test failures:

metafile.c:1282: Test failed: Expected 1.000000, got 0.000000
metafile.c:1283: Test failed: Expected 1.000000, got 0.000000
metafile.c:1293: Test failed: Expected 1.000000, got 0.000000
metafile.c:1294: Test failed: Expected 1.000000, got 0.000000

See:
https://test.winehq.org/data/tests/gdiplus:metafile.html

commit 18e65a95a7e294af04a62696a8181a72860c561f
Author: Vincent Povirk 
Date:   Wed Apr 6 14:36:55 2016 -0500

gdiplus: Fix bounds of recorded Metafile objects.

Signed-off-by: Vincent Povirk 
    Signed-off-by: Alexandre Julliard

[Bug 40595] gdiplus:metafile test regression (test_frameunit)

https://bugs.winehq.org/show_bug.cgi?id=40595

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |18e65a95a7e294af04a62696a81
                   |                            |81a72860c561f
           Keywords|                            |download, regression,
                   |                            |source, testcase
                URL|                            |https://test.winehq.org/dat
                   |                            |a/tests/gdiplus:metafile.ht
                   |                            |ml

[Bug 40595] gdiplus:metafile test regression (test_frameunit)

https://bugs.winehq.org/show_bug.cgi?id=40595

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Vincent Povirk  ---
Created attachment 54516
  --> https://bugs.winehq.org/attachment.cgi?id=54516
mark xp sp1 behavior as broken

Does this work for you?

[Bug 40595] gdiplus:metafile test regression (test_frameunit)

https://bugs.winehq.org/show_bug.cgi?id=40595

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from François Gouget  ---
Yes, this fixes it.
I confirmed it by reverting f42ff6fe and confirming that the bug is back.

Note: Normally when that patch was applied the XP column on
https://test.winehq.org/data/tests/gdiplus:metafile.html must have gone from 4
failures to 0 which in itself confirmed that the patch fixes the bug.

[Bug 40595] gdiplus:metafile test regression (test_frameunit)

https://bugs.winehq.org/show_bug.cgi?id=40595

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |f42ff6feab01b0019a684e7dd60
                   |                            |7ea90cffaf2c1

[Bug 40595] gdiplus:metafile test regression (test_frameunit)

https://bugs.winehq.org/show_bug.cgi?id=40595

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.24.