[Bug 33935] New: graphics identical sub-expressions '!(types[i + 1] & PathPointTypeBezier)'

http://bugs.winehq.org/show_bug.cgi?id=33935

Bug #: 33935
           Summary: graphics identical sub-expressions '!(types[i + 1] &
                    PathPointTypeBezier)'
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdiplus
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

On HEAD, dlls/gdiplus/graphics.c, line 1750:

http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/gdiplus/graphics.c#l17...

There are identical sub-expressions '!(types[i + 1] & PathPointTypeBezier)' to
the left and to the right of the '||' operator.

Credits to PVS-Studio: 
http://www.viva64.com/en/b/0192/#ID0EYFAG

[Bug 33935] graphics.c: identical sub-expressions '!(types[i + 1] & PathPointTypeBezier)'

http://bugs.winehq.org/show_bug.cgi?id=33935

Elton Chung  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|graphics identical          |graphics.c: identical
                   |sub-expressions '!(types[i  |sub-expressions '!(types[i
                   |+ 1] &                      |+ 1] &
                   |PathPointTypeBezier)'       |PathPointTypeBezier)'

[Bug 33935] graphics.c: identical sub-expressions '!(types[i + 1] & PathPointTypeBezier)'

http://bugs.winehq.org/show_bug.cgi?id=33935

--- Comment #1 from Vincent Povirk  2013-07-02 10:50:48 CDT ---
One of them should probably be types[i + 2]

[Bug 33935] graphics.c: identical sub-expressions '!(types[i + 1] & PathPointTypeBezier)'

http://bugs.winehq.org/show_bug.cgi?id=33935

--- Comment #2 from Elton Chung  2013-07-07 03:36:10 CDT ---
Patch #97201:

http://source.winehq.org/patches/data/97201

[Bug 33935] graphics.c: identical sub-expressions '!(types[i + 1] & PathPointTypeBezier)'

http://bugs.winehq.org/show_bug.cgi?id=33935

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch
                URL|                            |http://www.viva64.com/en/b/
                   |                            |0192/#ID0EYFAG

[Bug 33935] graphics.c: identical sub-expressions '!(types[i + 1] & PathPointTypeBezier)'

https://bugs.winehq.org/show_bug.cgi?id=33935

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from [e-mail] ---
I think this bug is actually fixed in source code.

wine 1.7.51

[Bug 33935] graphics.c: identical sub-expressions '!(types[i + 1] & PathPointTypeBezier)'

https://bugs.winehq.org/show_bug.cgi?id=33935

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |f1ed09fdd961cd3bde36e2cfd96
                   |                            |cadcdd56d1083
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Bruno Jesus  ---
(In reply to super_man from comment #3)
> I think this bug is actually fixed in source code.
>
> wine 1.7.51

Indeed.

[Bug 33935] graphics.c: identical sub-expressions '!(types[i + 1] & PathPointTypeBezier)'

https://bugs.winehq.org/show_bug.cgi?id=33935

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.52.

[Bug 33935] graphics.c: identical sub-expressions '!(types[i + 1] & PathPointTypeBezier)'

https://bugs.winehq.org/show_bug.cgi?id=33935

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Version|unspecified                 |1.6-rc4