[Bug 23953] New: qemu.exe exhausts file descriptors (regression)

http://bugs.winehq.org/show_bug.cgi?id=23953

Summary: qemu.exe exhausts file descriptors (regression)
           Product: Wine
           Version: unspecified
          Platform: x86
               URL: http://download.savannah.gnu.org/releases/qemu/qemu-0.
                    12.5.tar.gz
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

There is a regression in Wine triggered by qemu.exe:
wine client error:31: pipe: Too many open files
Good: wine-1.1.38
Bad: wine-1.3.0-166-g277040d

Steps to reproduce (courtesy of Kevin Wolf):
- Get the qemu source either from git or a release tar-ball; qemu-0.12.5.tar.gz
will do.
- Install the mingw cross compiling environment (on Fedora: yum install
mingw32-gcc mingw32-SDL mingw32-zlib)
- Unpack and cd to the qemu dir.
- ./configure --target-list=i386-softmmu
--cross-prefix=/usr/bin/i686-pc-mingw32- (this is for Fedora)
- Link the SDL.dll and zlink.dll to the qemu.exe dir so Wine can find them. On
Fedora:
  ln -s /usr/i686-pc-mingw32/sys-root/mingw/bin/zlib1.dll i386-softmmu/
  ln -s /usr/i686-pc-mingw32/sys-root/mingw/bin/SDL.dll i386-softmmu/
- Run qemu:
  wine i386-softmmu/qemu.exe -L pc-bios -hda $DISKIMAGE
- After a few seconds something like:
  "wine client error:3f: pipe: Too many open files" will show up and qemu will
hang.

I'm running a regression test at the moment.

[Bug 23953] qemu.exe exhausts file descriptors (regression)

http://bugs.winehq.org/show_bug.cgi?id=23953

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Michael Stefaniuc   2010-08-09 17:00:48 ---
3e5f7f49fe12e87d7ecd30f0969e99814dfb0e15 is the first bad commit
commit 3e5f7f49fe12e87d7ecd30f0969e99814dfb0e15
Author: Maarten Lankhorst 
Date:   Fri May 21 21:31:26 2010 +0200

winmm: Wake up timer after the timer list is empty.

:040000 040000 5e950b23106cf4b7163609f8095732f263265b9f
fc7a9a21686153efdb3a5afbe8e1ba97b6d85810 M    dlls

Reverting 3e5f7f49fe12e87d7ecd30f0969e99814dfb0e15 on top of
wine-1.3.0-166-g277040d makes the problem go away.

I have CC'ed the author of this commit.

[Bug 23953] qemu.exe exhausts file descriptors (regression)

http://bugs.winehq.org/show_bug.cgi?id=23953

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |winmm&mci
            Version|unspecified                 |1.2-rc2

[Bug 23953] qemu.exe exhausts file descriptors (regression)

http://bugs.winehq.org/show_bug.cgi?id=23953

--- Comment #2 from Michael Stefaniuc   2010-08-09 17:35:35 ---
I've run qemu.exe with +mmtime and I get basically following 3 lines looping
forever:
trace:mmtime:timeSetEvent (1, 4294967295, 0x4050b0, 0054A1C0, 0001);
trace:mmtime:timeSetEvent => 1
trace:mmtime:timeKillEvent (1)

[Bug 23953] qemu.exe exhausts file descriptors (regression)

http://bugs.winehq.org/show_bug.cgi?id=23953

--- Comment #3 from Michael Stefaniuc   2010-08-09 17:36:21 ---
Created an attachment (id=30074)
 --> (http://bugs.winehq.org/attachment.cgi?id=30074)
Full output of WINEDEBUG=+mmtime wine i386-softmmu/qemu.exe -L pc-bios -hda
/j/virt/images/freebsd-71-i386.img >> /tmp/qemu+mmtime.txt 2>&1

[Bug 23953] qemu.exe exhausts file descriptors (regression)

http://bugs.winehq.org/show_bug.cgi?id=23953

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Dan Kegel   2010-08-09 21:29:16 ---
Does the workaround from bug 19615 also help here?

[Bug 23953] qemu.exe exhausts file descriptors (regression)

http://bugs.winehq.org/show_bug.cgi?id=23953

--- Comment #5 from Dan Kegel   2010-08-09 21:30:52 ---
I take that back, this seems like a real leak.

[Bug 23953] qemu.exe exhausts file descriptors (regression)

http://bugs.winehq.org/show_bug.cgi?id=23953

--- Comment #6 from Michael Stefaniuc   2010-08-10 03:49:34 ---
Dan, I didn't try it out yet as it was too late yesterday; I plan to give it a
whirl tonight. But I had looked at the lsof output and it seemed that we are
leaking mmtimer threads.

[Bug 23953] qemu.exe exhausts file descriptors (regression)

http://bugs.winehq.org/show_bug.cgi?id=23953

--- Comment #7 from Dan Kegel   2010-08-10 07:32:54 ---
Yeah, no point in trying the workaround.  A thread leak is a glorious thing.

[Bug 23953] qemu.exe exhausts file descriptors (regression)

http://bugs.winehq.org/show_bug.cgi?id=23953

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.2.x

--- Comment #8 from Dan Kegel   2010-08-10 12:47:01 ---
Maarten sent a patch,
http://www.winehq.org/pipermail/wine-patches/2010-August/091911.html

Nominating for 1.2.x

[Bug 23953] qemu.exe exhausts file descriptors (regression)

http://bugs.winehq.org/show_bug.cgi?id=23953

--- Comment #9 from Michael Stefaniuc   2010-08-10 17:34:52 ---
Tested the fix and it works. As I was testing with a FreeBSD image that
happened to have wine-1.1.29 in it I have compiled that (without ccache):
- It run for 4 CPU hours (didn't finish as it is slooow and I had to power off)
- It fired the timer 3.6 Million times (timeSetEvent/timeKillEvent)
- 47 time tids were used and the calls were pretty easily distributed onto
them.

So this really looks fixed ;)

[Bug 23953] qemu.exe exhausts file descriptors

http://bugs.winehq.org/show_bug.cgi?id=23953

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|qemu.exe exhausts file      |qemu.exe exhausts file
                   |descriptors (regression)    |descriptors

[Bug 23953] qemu.exe exhausts file descriptors

http://bugs.winehq.org/show_bug.cgi?id=23953

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Michael Stefaniuc   2010-08-16 12:44:13 ---
The patch was commited as 6910b0f1439b15d73783bcd276512a517fe8fd83. Marking bug
as resolved.

[Bug 23953] qemu.exe exhausts file descriptors

http://bugs.winehq.org/show_bug.cgi?id=23953

Maarten Lankhorst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Maarten Lankhorst   2010-08-17 10:26:40 ---
*** Bug 22908 has been marked as a duplicate of this bug. ***

[Bug 23953] qemu.exe exhausts file descriptors

http://bugs.winehq.org/show_bug.cgi?id=23953

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard   2010-08-20 12:39:46 ---
Closing bugs fixed in 1.3.1.

[Bug 23953] qemu.exe exhausts file descriptors

http://bugs.winehq.org/show_bug.cgi?id=23953

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.2.x                       |---

--- Comment #13 from Alexandre Julliard  2010-10-08 10:40:48 CDT ---
Removing 1.2.x milestone from bugs fixed in 1.2.1.