https://bugs.winehq.org/show_bug.cgi?id=47321
Bug ID: 47321 Summary: Regression: Painkiller crashes at startup (wined3d_device_create_primary_opengl_context_cs() doesn't check NULL return value from context_acquire()) Product: Wine Version: 4.9 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs@winehq.org Reporter: o.dierick@piezo-forte.be Distribution: ---
Created attachment 64635 --> https://bugs.winehq.org/attachment.cgi?id=64635 painkiller multiplayer demo wine-4.9 terminal output
Painkiller Multiplayer and Singleplayer demos crash at startup in wined3d_device_create_primary_opengl_context_cs().
This is a regression between wine-4.8 and wine-4.9.
The application triggers context_acquire() to return NULL. The return value is not checked in wined3d_device_create_primary_opengl_context_cs() and so it tries to access NULL pointer and crashes.
https://bugs.winehq.org/show_bug.cgi?id=47321
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://www.fileplanet.com/ | |archive/p-29192/Painkiller- | |Multiplayer-Demo Keywords| |download, regression Regression SHA1| |db201072655946662c041a66ee4 | |34c30c245e5b0
--- Comment #1 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Tested with Painkiller Multiplayer Demo: $ du -b PainkillerMultiplayerDemo.exe 143387444 PainkillerMultiplayerDemo.exe $ sha1sum PainkillerMultiplayerDemo.exe c97263f12edd7e8ed7da07d439bb03da239fae1e PainkillerMultiplayerDemo.exe
Tested with Painkiller Singleplayer Demo (https://www.fileplanet.com/archive/p-51403/Painkiller-Single-Player-Demo): $ du -b Painkiller_SP_Demo_Setup.exe 239524995 Painkiller_SP_Demo_Setup.exe $ sha1sum Painkiller_SP_Demo_Setup.exe 095319fb4aa4853c2c4dd60e7df3929f5222b657 Painkiller_SP_Demo_Setup.exe
https://bugs.winehq.org/show_bug.cgi?id=47321
--- Comment #2 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Created attachment 64636 --> https://bugs.winehq.org/attachment.cgi?id=64636 Patch: Check return value from context_acquire()
The attached patch prevents both applications from crashing.
https://bugs.winehq.org/show_bug.cgi?id=47321
pattietreutel katyaberezyaka@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |katyaberezyaka@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=47321
--- Comment #3 from Henri Verbeet hverbeet@gmail.com --- This sounds like a duplicate of bug 47255, does commit d88c403e548cfe2171ac22603197ffbc0e70b4c2 help?
https://bugs.winehq.org/show_bug.cgi?id=47321
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE
--- Comment #4 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- (In reply to Henri Verbeet from comment #3)
This sounds like a duplicate of bug 47255, does commit d88c403e548cfe2171ac22603197ffbc0e70b4c2 help?
Hello,
It is fixed in today's git (c92fdda) so a duplicate indeed.
Regards.
*** This bug has been marked as a duplicate of bug 47255 ***
https://bugs.winehq.org/show_bug.cgi?id=47321
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Closing Duplicate.